[RESOLVED] Suppress class error reporting

Myth_UK_

Whats the best method to suppress errors for a class.

I don't mean $obj = @new MyClass();

I am more interested in class function errors...

public function encrypt($data, $key) {
		if (!isset($data, $key)) throw new CryptographyException('The encrypt function requires 2 arguments.');
}

$obj->encrypt(); // This would throw my exception (good), but I will also get php error message reports (bad).

I don't want to use @ on everything.
Is there a way to use error_reporting(0)... just on the class object(s)?

I thought this would work, @include_once(../classes/crypto.php'); but doesn't.

P.S The php error messages are only logged to a file on my server, but the class itself will be used by others, within their code, so I cannot use error_reporting(0), unless I can make it somehow local to the class.

NogDog

To the best of my knowledge, no.

Personally, I would not want it to, either, as I would prefer to control if/when my web app displays errors via the PHP settings (display_errors and error_reporting).

PS: Throwing the exception should only generate a PHP error if the client code does not use a try/catch block, in which case it should display an error if the developer has display_errors turned on, so that he knows he should, in fact, be using a try/catch. (IMHO, of course, 😉 )

Weedpacket

There are four possibilities that come to mind, of varying degrees of "goodness". In order of ease of implementation:

Do nothing and just stay with the error message: misusing the API so severely in the first place deserves a smackdown 🙂
Provide default null values for the parameters. You'll still be able to write bad calls, but the defaults will mean that the exception is triggered.
Use an error handler to turn error messages into exceptions (PHP provides an [man]ErrorException[/man] class; that page provides an example of registering it with [man]set_error_handler[/man]
Don't list any parameters in the function signature, and extract the arguments from func_get_args(). But this implies that you should be able to skip passing arguments in the call (which is a lie).

Myth_UK_

:o I didn't know you could change error messages into exceptions.

And as for as I know, (which may be wrong), you cannot catch error messages in a try catch block... only exceptions, (unless you change the messages to exceptions).

I just thought if you are using OOP, you should be throwing and catching exceptions ... but then it should be left down to the client if he/she wishes to turn error reporting off etc.

P.S using set_error_handler in a class to change error messages to exceptions... Wouldn't this effect not just the class, but the entire running script???

NogDog

I may have misunderstood the original example a bit, thinking you were concerned about the error message that gets displayed when the exception occurs if it's not caught, versus the error messages that would get displayed for the missing method arguments.

I guess for someone who believes in running production versions of any apps with display_errors turned off, I'm just not worried about it: I want errors displayed while in development mode, and it's not an issue in production mode. Besides, to me, omitting required method args is not so much an exception as it is just plain bad code, which should be flagged as an error and fixed right away during testing. 🙂

And yes, AFAIK, once you turn on the custom error handler, it effects the entire script, not just that class.

Myth_UK_

I normally have error_reporting turned off, rather than display_errors off, for production versions of projects, (not sure which is the best method).

But the classes are going to be made avaiable to the public, and I wanted to override the default error messaging, in favour of exceptions... No problem if PHP can't do this at class level. :o

bradgrafelman

Myth(UK);10947798 wrote:
I normally have error_reporting turned off, rather than display_errors off, for production versions of projects, (not sure which is the best method).

Neither; IMHO, error_reporting should be set to E_ALL on a production server, with display_errors Off and log_errors On.

Myth_UK_

Think I should stick to C++ and C# apps :queasy: