[RESOLVED] how to prevent include() in a loop

peter_schneider

In my php script 'php-x' I have 10 loops, each of them including the same scriptfile 'php-y'.
One parse of 'x' includes 'y' about 100 times total!
I could increase server performance drastically by saving these 100 includes. But I dont want to put the code of 'y' in each of the loops of 'x' because both scripts are long enough by themselves already.
I'm looking for a way around the includes. If I could put the php!-code of 'y' in 'x' once and then refer to it in the loops, that would be a nice solution. Any idea how to do it this way or differently?

dagon

so just included php-y before(outside) the loop

peter_schneider

i need the code of 'y' or a reference to it within the loops! thats why i've used include() so far ...

dagon

so create a function

peter_schneider

a function, i guess, needs a variable processed by it?! in my case 'php y' is just an additional script producing html code depending on whats happened in the loops of 'php x' beforehands.

peter_schneider

I just read:
Any valid PHP code may appear inside a function.
So, this could actually work if I knew what to put in the function's arguments brackets ...?
function my_code_4_loop(????) {
//my code
}

bradgrafelman

I think you're going to have to show us some example code... it's hard to understand what you're talking about without any code to look at.

dagon

well your function may not have any arguments or it may have a a million, with out some actual code, i wouldn't have a clue. You are really not providing enough information on the problem, all i can do is guess\speculate on solutions

peter_schneider

if i could do it this way it'd be solved:

define function without arguments like this:
function my_code_4_loop() {
//my code
}
refer to the code/call the function in a loop like this:
my_code_4_loop();

??? correct?

bradgrafelman

Not sure what your question is... can you use a function that you define? Yes, of course you can, that's the point of defining functions...

peter_schneider

well, one thing i never needed to do so far ... defining functions. I'll try out tonight and let you know how i did 😉

peter_schneider

failure

(sorry, i posted something unintentionally here and then i didnt know how to delete it (still dont know ... thats why i typed failure - couldnt post an empty post))

dagon

peter schneider;10947786 wrote:
failure

sorry but you really do suck at asking questions, do we look psychic ??😕

peter_schneider

i havent got it it working yet ...
so, here is more info concerning the code.

somewhere in 'php x' ...

//define function
my_function() {
//contains the 'php y' code that queries a db and processes misc variables to generate table cells (<td>...</td>)
}

//now open the table
echo '<table><tr>';

          //add a table cell with misc content (instead of including a file here(containing the code of 'php y') I try to call that code through calling a function containing that code)
      while ($num < $some_number) {
            my_function();
   $num++;
	}

//close table
echo '</tr></table>';

if i just include the file with 'php y' everything works fine.
the function construction doesnt work yet. at this time the function doesnt seem to be able to process any varibales set in 'php x' beforehands. It outputs at least something ... but these are more or less just empty tablecells - by far not what the working script would produce.

dagon

I give up trying to help you. If you want to make it far more difficult, for those who go out of their way in their free time to help you, then I have better things to do.

Good Luck.

peter_schneider

I'm sorry dagon - I'm trying to simplify the code to help you understand - its got hundreds of lines - you dont want to read that ...

at this time the problem seems to be that the code in the function, when executed, can not work with variables set outside. a var_dump($variable_from_outside) executed in the function shows NULL!
if i include the code through include() it works fine, not this way though, yet ...

Weedpacket

It might be that you want to use the [man]global[/man] keyword; but it's considered better practice to pass to a function any values that it needs as arguments.

peter_schneider

thats it!
global works but
GLOBALS[]; doesnt work for me - strange.

anyways, also passing as arguments works with same performance as global, just saver I guess.

at the moment it works great for me - doubled parsing speed! 😉

peter_schneider

everybody thanks a lot for your help!