could someone look this over?

[pmnjason]

<?php

//Begin POST Variables
$mfgname = $_POST['mfgname'];
$fname = $_POST['fname'];
$lname = $_POST['lname'];
$email = $_POST['email'];
$email2 = $_POST['email2'];
$addy = $_POST['addy'];
$city = $_POST['city'];
$state = $_POST['state'];
$zip = $_POST['zip'];
$phone = $_POST['phone'];
$vehicle = $_POST['vehicle'];
$vehicle_year = $_POST['vehicle_year'];
$vehicle_engine = $_POST['vehicle_engine'];
$vehicle_trans = $_POST['vehicle_trans'];
//End POST Variables

if ( ereg( "[\r\n]", $fname ) || ereg( "[\r\n]", $lname ) || ereg( "[\r\n]", $email ) ) {
	print("Sorry, an error occurred, please check your entries and try again."); }

if ( !empty($email2) ) {
	$headers .= "BCC: $email2";
}

$to = "[e-mail]"; 

$subject = "Catalog Request via address.com";
$headers = "FROM: me <[e-mail]>\r\nReply-To: ".$fname." ".$lname." <".$email.">\r\n";

$body = "Catalog Request for ".$mfgname." Catalog\n\n";
$body .= $fname." ".$lname."\n";
$body .= $addy."\n";
$body .= $city.", ".$state." ".$zip."\n";
$body .= $email."\n";
$body .= $phone."\n\n";
$body .= "Vehicle Information:\n";
$body .= $vehicle_year." ".$vehicle."\n";
$body .= "Engine: ".$vehicle_engine."\n";
$body .= "Transmission: ".$vehicle_trans."\n\n";
$body .= "thanks\n";
$body .= "http://www.address.com\n";
$body .= "WEB\n";
$body .= "PHONE";

mail($to, $subject, $body, $headers);
?>

it crashes when i don't supply an $email2 variable.

i carry them over with this javascript:

<script language="javascript" type="text/javascript">
<!--

var strFeatures = "height=540,width=420,location=no,menubar=no,toolbar=no,resizable=no,scrollbars=no,top=50,left=50"

var strURL = "/files/HTML/catalogorder.php?mfg="

function OrderCat(mfg,email2) {
 window.open(''+strURL+mfg+'&email2='+email2,'CatalogOrder', strFeatures);
}
// -->
</script>

and so the actual links look like:

javascript:OrderCat('Diamond%20Back','[e-mail]');

If i don't supply an email2 var in the link, it crashes.

any help would be appreciated!

[pmnjason]

so if the link is:

javascript:OrderCat('Diamond%20Back');

then it's crashing it, since there is no $email2 provided.

but i don't know a way around it.

[bradgrafelman]

I don't know what you mean by "it crashes" - it works fine for me. Granted, Javascript inserts "undefined" into the string where the email2 JS variable is used, but that could be solved by adding this to the OrderCat function:

if(email2 == null)
    email2 = '';

EDIT: By "it" did you actually mean your PHP script? If so, it's probably because you don't do any validation in the JS function to replace 'undefined' with an empty value (e.g. what my code above does). If you're instead passing "undefined" in the URL, the mail() function is probably returning false since "BCC: undefined" is a malformed e-mail header.