[RESOLVED] a multitude of a mess

[fontener]

Not sure if I'm echoing the function correctly...

<a href="<?php if($order == "act" && $sort == "ASC"){
  echo add_or_change_parameter("order", "act", "sort", "DESC", "page", "1"); 
}else{
  echo add_or_change_parameter("order", "act", "sort", "ASC", "page", "1");} ?>">Active/Inactive</a>

Here is the function:

<?php
 function add_or_change_parameter($parameter, $value)
 {
  $params = array();
  $output = "?";
  $firstRun = true;
  foreach($_GET as $key=>$val)
  {
   if($key != $parameter)
   {
    if(!$firstRun)
    {
     $output .= "&";
    }
    else
    {
     $firstRun = false;
    }
    $output .= $key."=".urlencode($val);
   }
  }
  if(!$firstRun)
   $output .= "&";
  $output .= $parameter."=".urlencode($value);
  return htmlentities($output);
 }
?> 

The get statements are there... it seems the echoing of the function only returns the first result (in this case: order=act)

also, a part of the query ...ORDER BY $order $sort

Again, thanks for any help in advance!

[Weedpacket]

add_or_change_parameter() expects only two arguments - you're giving it six.

I think this might be an easier way to go about it:

<?php echo change_parameters(array("order"=>"act", "sort"=>"DESC", "page"=>"1"))?>

function change_parameter($parameters)
{
    $parameters += $_GET;
    return htmlentities(http_build_query($parameters, '', '&'));
}

I changed the name a wee bit, because of a bit of a bonus: giving a null value for a parameter removes that parameter from the querystring.

[fontener]

Thanks Weedpacket, this works great (and much cleaner) .. the only thing is, with this new function, the ? is lost so it becomes www.someserver.com/index.phporder=act&sort=DESC&page=1

[laserlight]

You can err... add it in?