Contact Form help

[Cuppa]

Hi people.

Hopefully this should be an easy question to answer for people in the know.

I have a form on my site that people fill out and it sends an e-mail to me. It was working fine, but I need to change one of the boxes to represent a monetary value, i.e £50. Whenever I use the "£" it throws an error as it's not expecting the "£". The string in the php code is:

$string_exp = "^[0-9 .-]+$";

Question is this. What do i need to change so that I can use the £ sign?

Any help is greatly appreciated.

Thanks

Cuppa

[bradgrafelman]

Can you show us more of the code that you're using?

Based on the regexp pattern you showed us, it looks like you're using one of the ereg() functions. If that's the case, you should switch to using one of the [man]PCRE[/man] functions instead, as the ereg() functions have been deprecated and won't be available in newer versions of PHP.

EDIT: Please do not cross-post the same topic across multiple forums.

[Weedpacket]

Also, the ereg functions aren't built to handle anything beyond plain 7-bit ASCII.

[Cuppa]

Thank you for your replies.
This is what I am using, got it from some site I found and adjusted the e-mail bit. What I need if for is the telephone bit to accept the £ sign (if possible). The page the contact form is on can be found here:
http://www.robandlisagetmarried.co.uk/page.php?5

<?php
if(isset($_POST['email'])) {

// EDIT THE 2 LINES BELOW AS REQUIRED
$email_to = "[e-mail]";
$email_subject = "Giftlist Order";


function died($error) {
	// your error code can go here
	echo "We are very sorry, but there were error(s) found with the form your submitted. ";
	echo "These errors appear below.<br /><br />";
	echo $error."<br /><br />";
	echo "Please go back and fix these errors.<br /><br />";
	die();
}

// validation expected data exists
if(!isset($_POST['first_name']) ||
	!isset($_POST['last_name']) ||
	!isset($_POST['email']) ||
	!isset($_POST['telephone']) ||
	!isset($_POST['comments'])) {
	died('We are sorry, but there appears to be a problem with the form your submitted.');		
}

$first_name = $_POST['first_name']; // required
$last_name = $_POST['last_name']; // required
$email_from = $_POST['email']; // required
$telephone = $_POST['telephone']; // not required
$comments = $_POST['comments']; // required

$error_message = "";
$email_exp = "^[A-Z0-9._%-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$";
  if(!eregi($email_exp,$email_from)) {
  	$error_message .= 'The Email Address you entered does not appear to be valid.<br />';
  }
	$string_exp = "^[a-z .'-]+$";
  if(!eregi($string_exp,$first_name)) {
  	$error_message .= 'The First Name you entered does not appear to be valid.<br />';
  }
  if(!eregi($string_exp,$last_name)) {
  	$error_message .= 'The Last Name you entered does not appear to be valid.<br />';
  }
  if(strlen($comments) < 2) {
  	$error_message .= 'The Comments you entered do not appear to be valid.<br />';
  }
  $string_exp = "^[0-9 £$.-]+$";
  if(!eregi($string_exp,$telephone)) {
  	$error_message .= 'The Telphone Number you entered does not appear to be valid.<br />';
  }
  if(strlen($error_message) > 0) {
  	died($error_message);
  }
	$email_message = "Form details below.\n\n";

function clean_string($string) {
  $bad = array("content-type","bcc:","to:","cc:","href");
  return str_replace($bad,"",$string);
}

$email_message .= "First Name: ".clean_string($first_name)."\n";
$email_message .= "Last Name: ".clean_string($last_name)."\n";
$email_message .= "Email: ".clean_string($email_from)."\n";
$email_message .= "Telephone: ".clean_string($telephone)."\n";
$email_message .= "Comments: ".clean_string($comments)."\n";


// create email headers
$headers = 'From: '.$email_from."\r\n".
'Reply-To: '.$email_from."\r\n" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers);  

?>


<!-- include your own success html here -->

Thank you for ordering a gift for Rob and Lisa.  You should recieve a e-mail shortly.
<?
}
?>

Thank you for your assistance

Cuppa

[bradgrafelman]

As suspected, you're using the deprecated ereg*() functions. Weedpacket's already explained why it isn't working.

As such, you should replace ereg() and eregi() with [man]preg_match/man. The notable differences that apply to you between the two styles of regular expression matching are: 1) the PCRE functions require delimiters to be placed before and after the pattern - the common choice is a forward slash ('/'), and 2) eregi() provides a case-insensitive match, a behavior that can be mimicked in a PCRE function by using the 'i' modifier after the ending delimiter, e.g.:

/[a-z]+/

would be made case-insensitive by using:

/[a-z]+/i

[Cuppa]

Thank you for the reply

So the following:

}
  $string_exp = "^[0-9 £$.-]+$";
  if(!eregi($string_exp,$telephone)) {
  	$error_message .= 'The Telphone Number you entered does not appear to be valid.<br />';
  }

would become:

}
  $string_exp = /[0-9 £$.-]+/i;
  if(!eregi($preg_match,$telephone)) {
  	$error_message .= 'The Telphone Number you entered does not appear to be valid.<br />';
  }

Is it a simple case of changing them all like the above? Sorry for the questions but I am new to all this, been reading about it most of the day and it's making my head hurt 🙂

Would the pattern /[0-9 £$.-]+/i allow for the £ to be used?

Thanks

Cuppa

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

As for your modifcations, you have a parse error now - the regexp pattern is still a string, no matter which library of functions you use, thus it must be surrounded with quotes.