Pagination Problem Last Image is Black

creativeink

Here is my page:

http://www.creativeink.ca/new/

The final image in my pagination is black and I cannot figure out why.

Here is my code:

<?php
$host = "";
$user = "";
$pass = "";
$db = "";

mysql_connect($host,$user,$pass) or die("ERROR:".mysql_error());
mysql_select_db($db) or die("ERROR DB:".mysql_error()); 

$max = 14; //amount of articles per page. change to what to want

$p = $_GET['p'];
if(empty($p))
{
$p = 1;
}
$limits = ($p - 1) * $max; 

if(isset($_GET['act']) && $_GET['act'] == "view")

{

$id = $_GET['id'];

$sql = mysql_query("SELECT * FROM photos WHERE id = '$id'");

while($r = mysql_fetch_array($sql))

{

$title = $r['Caption'];
$photo = $r['Photo'];

echo "<div><p>$title</p><p>$photo</p></div>";
}

}else{

//view all the news articles in rows
$sql = mysql_query("SELECT * FROM photos WHERE Gallery='logo' LIMIT ".$limits.",$max") or die(mysql_error());

//the total rows in the table
$totalres = mysql_result(mysql_query("SELECT COUNT(id) AS tot FROM photos"),0);	

//the total number of pages (calculated result), math stuff...
$totalpages = ceil($totalres / $max); 

//the table
echo "<center><table border='0'><tr>";

while($r = mysql_fetch_array($sql))
{

$photos = mysql_num_rows($sql);
for($i = 0; $i<$photos; $i++) {
$row = mysql_fetch_array($sql);
if(is_int($i/7)) {
print "</td></tr><tr><td><div id='clipped_logo'><a href=\"uploads/".$row['Photo']."\" rel=\"enlargeimage::mouseover\" rev=\"loadarea\"><img src=\"uploads/".$row['Photo']."\" border=\"0\" id=\"".$row['id']."\" name=\"".$row['Caption']."\" /></a></div></td>";
}else{
print "<td><div id='clipped_logo'><a href=\"uploads/".$row['Photo']."\" rel=\"enlargeimage::mouseover\" rev=\"loadarea\"><img src=\"uploads/".$row['Photo']."\" border=\"0\" id=\"".$row['id']."\" name=\"".$row['Caption']."\" /></a></div></td>";
}
}

}

//close up the table
echo "</tr></table></center><br />";

for($i = 1; $i <= $totalpages; $i++){ 

//this is the pagination link
echo "<a href='index.php?p=$i'>$i</a>|";
}
}

?>

The href is a javascript swap image that works properly by filling a div I have at the top.

But I cannot figure out the last black image!

Pikachu2000

When I go to the URL you provided, I get nothing at all sent to my browser.

creativeink

Sorry dont know what happend but the page should be there now

Pikachu2000

The image isn't black. There is no image there; the black is the background color as specified in the CSS. In the HTML source, the last image clearly isn't echoed :

<img src="uploads/" border="0" id="" name="" onmouseover="MM_swapImage . . .

Weedpacket

I've taken the liberty of adding bbcode tags to your original post to help with legibility (here's some information about [noparse]

...

[/noparse] and related tags[/url]); you may want to repair the indentation and other formatting.

As for your problem, I notice that you have two nested loops, the outer one fetching records into $r, the inner one fetching records into $row.

Since the outer loop fetches one record from the fourteen, that leaves thirteen for the inner loop, which goes through them all (to fill thirteen of the fourteen cells, using nothing to fill the fourteenth cell), and then both loops finish (the inner because it has run fourteen times and the outer because the result set is exhausted).

In short, that outer loop is redundant.