[RESOLVED] PHP code no longer works: preg_replace

loweauto

I'm having problems with some PHP code that I implemented on a site. It worked when I handed everything over, but after a few months - probably PHP updates, it stopped working. (Not entirely sure of the versions when I made it, but now it's PHP Version 5.2.12-nmm1)

In more detail:

It is a bilingual site, and has duplicate HTML files for both languages, e.g.:

.../eng/index.html
.../deu/index.html

To switch between languages, I implemented the following code (this example is from what appears on the EN version):

<div class="loweAutomobil" id="language">English | <?php $myUrl = "http://".$SERVER_NAME.$REQUEST_URI; $alternativeUrl = preg_replace("/eng/","deu",$myUrl); echo "<a href= ".$alternativeUrl.">Deutsch</a>"; ?></div>

For some reason, it doesn't work anymore as it should (i.e. display "Deutsch" as a link with the current 'eng' in the URL replaced by 'deu').

Instead it goes to: http:localhost/

Does anyone have any ideas as to why? How can I fix it?

You can view the site here: http://loeweautomobil.de/eng/index.html

Thank you for your time!

halojoy

As preg_replace code seem correct
then it is perhaps not found 'eng' in url.
This can be because you use the old, old server/request_uri variables
Now should be:
$SERVER["SERVER_NAME"]
$SERVER["REQUEST_URI"]
.... which gives

<div class="loweAutomobil" id="language">
English | 
<?php 
$myUrl = "http://" . $_SERVER["SERVER_NAME"] . $_SERVER["REQUEST_URI"]; 
$alternativeUrl = preg_replace("/eng/", "deu", $myUrl); 
echo "<a href= ". $alternativeUrl .">Deutsch</a>";
?>
</div>

loweauto

halojoy;10949075 wrote:
As preg_replace code seem correct
then it is perhaps not found 'eng' in url.
This can be because you use the old, old server/request_uri variables
Now should be:
$SERVER["SERVER_NAME"]
$SERVER["REQUEST_URI"]
.... which gives
<div class="loweAutomobil" id="language">
English | 
<?php 
$myUrl = "http://" . $_SERVER["SERVER_NAME"] . $_SERVER["REQUEST_URI"]; 
$alternativeUrl = preg_replace("/eng/", "deu", $myUrl); 
echo "<a href= ". $alternativeUrl .">Deutsch</a>";
?>
</div>

thanks very much!! worked like a charm!!

now i'm going to use str_replace instead...

halojoy

Yes. You are right.
In this case, and where we have such simple basic replace
it is better and most probably runs faster
to use [man]str_replace[/man]

preg_replace() is for situations (more complex) when str_replace() can not do it
The rule is: Use not more force than you need to.

So here you would get

$alternativeUrl = str_replace("eng", "deu", $myUrl);

loweauto

halojoy;10949134 wrote:
Yes. You are right.
In this case, and where we have such simple basic replace
it is better and most probably runs faster
to use [man]str_replace[/man]

preg_replace() is for situations (more complex) when str_replace() can not do it
The rule is: Use not more force than you need to.

So here you would get
$alternativeUrl = str_replace("eng", "deu", $myUrl);

thanks very much.. you're right with the quote 🙂

very helpful!!!! 🙂 🙂 😃