Help with database lookup.

fotofx

Working on a zen-cart. I am trying to modify the zen_get_categories_image function to provide a random product image from within that category if no category image exists. I thought I had it but although no errors, it is not working as I expected. Any obvious errors?? I think my problem is with the "If Null" part.

 function zen_get_categories_image($what_am_i) { 
    global $db; 

$the_categories_image_query= "select categories_image from " . TABLE_CATEGORIES . " where categories_id= '" . $what_am_i . "'"; 
$the_products_category = $db->Execute($the_categories_image_query); 

if ($the_products_category->fields['categories_image'] !=NULL){ 
return $the_products_category->fields['categories_image']; 
} else { 
  $random_product_query= "select products_image from " . TABLE_PRODUCTS . " where master_categories_id= '" . $what_am_i . "'"; 
 $random_product_raw = $db->Execute($random_product_query); 
 $random_product_image_rand = array_rand($random_product_raw,1); 
 $the_products_category->fields['categories_image'] = $random_product_image_rand[0]; 
 return $the_products_category->fields['categories_image']; 
} 
  }

dagon

you want empty() instead of the null check

fotofx

Makes sense but still not working using:

if (empty($the_products_category->fields['categories_image'])){

dagon

this works.

 function zen_get_categories_image($what_am_i) {
    global $db;

$the_categories_image_query= "select categories_image from " . TABLE_CATEGORIES . " where categories_id= '" . $what_am_i . "'";
$the_products_category = $db->Execute($the_categories_image_query);

if (!empty($the_products_category->fields['categories_image'])){
return $the_products_category->fields['categories_image'];
} else {
  $random_product_query= "SELECT products_image FROM " . TABLE_PRODUCTS  . "
  WHERE master_categories_id= '" . $what_am_i . "' ORDER BY rand() LIMIT 1";
  $the_products_category = $db->Execute($random_product_query);
 return $the_products_category->fields['products_image'];

}
  }

fotofx

Saw your reply on Zen site also.. But strange things are happening when I try that. I have many products in each category and they all have images but the "no_picture.gif" image is showing up for every category?????? Can't figure out where it is coming from. Any thoughts?

dagon

i did try it on my cart and it worked, what version are you using?

fotofx

1.3.8

fotofx

I modified the function to your code and modified category_row.php as follows:

//    if (!$categories->fields['categories_image']) !$categories->fields['categories_image'] = 'pixel_trans.gif';
    if (!$categories->fields['categories_image']) {
$categories->fields['categories_image'] = zen_get_categories_image ($categories->fields['categories_id']);
    }

I just commented out the old code and added mine under it.

dagon

not 100% clear on the logic there ,but don't have any time, so as it works- great :-)

good idea to update thread on zen forum for any one else that bumps in to it.

fotofx

Solved, Had to reset the master categories ID from the manager. They default to zero.