[RESOLVED] Need Help with Multiple Forms on 1 page

[everythingis]

Sorry for the long script, but when I test this out & hit submit with empty fields, it refreshes to a blank page instead of giving me an error message for the individual forms that I'm testing. At the bottom is just one of the form sections to give an example instead of posting the whole page.

Don't know where I've gone wrong:

<?php 

$firstname = "";
$lastname = "";
$username = "";
$password = "";
$email = "";


$new_firstname = "";
$new_lastname = "";
$new_username = "";
$confirm_username = "";
$current_password = "";
$new_password = "";
$confirm_password = "";
$new_email = "";
$confirm_email = "";



include_once "includes/scripts/connect_to_mysql.php";

$sql = mysql_query("SELECT * FROM member_profile WHERE user_id='$user_id'");




//******************************************BEGIN NEW FIRST AND LAST NAME FORM***************************************//
if (isset($_POST['parse_var']) == "form_new_name"){

$new_firstname = $_POST['new_firstname'];
$new_lastname = $_POST['new_lastname'];	

$new_firstname = mysql_real_escape_string($new_firstname);
$new_lastname = mysql_real_escape_string($new_lastname);

if (empty($new_firstname) || empty($new_lastname)) {
	$error_msg = "ERROR: Missing Fields Required.";
}else {

$sqlUpdate = mysql_query("UPDATE member_profile SET firstname='$new_firstname', lastname='$new_lastname' WHERE user_id='$user_id'");
    if ($sqlUpdate){
        $success_msg = "Your Account Settings Have Been Updated.";
		exit();           
    } else {
		 $error_msg = "ERROR: Your Account Settings Could Not Be Updated, Please Try Again Later.";
		exit(); 
	}


} //END ELSE FOR MISSING FIELDS
exit(); 
}//***************END NEW FIRST AND LAST NAME FORM






//******************************************BEGIN NEW USERNAME FORM***************************************//
if (isset($_POST['parse_var']) == "form_new_username"){

$new_username = $_POST['new_username'];
$confirm_username = $_POST['confirm_username'];

$new_username = mysql_real_escape_string($new_username);
$confirm_username = mysql_real_escape_string($confirm_username);

if (empty($new_username) || empty($confirm_username)) {
	$error_msg = "ERROR: Missing Fields Required.";
}else {

$sqlUpdate = mysql_query("UPDATE member_profile SET username='$new_username', WHERE user_id='$user_id'");
    if ($sqlUpdate){
        $success_msg = "Your Account Settings Have Been Updated.";
      	exit(); 
    } else {
		$error_msg = "ERROR: Problems connecting to server at this time, please try again later.";
		exit(); 
	}

}//END ELSE FOR EMPTY FIELDS		
exit(); 	
}//***************END EDIT USERNAME FORM




//******************************************BEGIN EDIT EMAIL FORM***************************************//
if (isset($_POST['parse_var']) == "form_new_email"){

$new_email = $_POST['new_email'];
$confirm_email = $_POST['confirm_email'];


$new_email = mysql_real_escape_string($_POST['new_email']);
$confirm_email = mysql_real_escape_string($_POST['confirm_email']);
$emailChecker = mysql_real_escape_string($new_email);

// Add MD5 Hash to the password variable
$db_password = md5($password); 

//ERROR HANDLING
if ($new_email != $confirm_email) {
	$error_msg = "Error: Email Address Did Not Match.";
	exit(); 
}

if (empty($new_email) || empty($confirm_email)) {
	$error_msg = "ERROR: Missing Fields Required.";
}else {	

$sql_email_check = mysql_query("SELECT email, password FROM member_profile WHERE email='$emailChecker' AND password='$db_password' AND user_id='$user_id'");
$email_check = mysql_num_rows($sql_email_check); 

if ($email_check > 0){ 
		$error_msg = "ERROR: Your New Email address is already in use.";
		exit();
} else {

//!!!!!!!!!!!!!    Email User the New Email Verification   !!!!!!!!!!!!!!!!
    $to = "$new_email";

$from = "[e-mail]";
$subject = "so.did.we Account Settings Changed: Confirm New Email Address";
//Begin HTML Email Message
$message = 

  "Hi $firstname,

   Please complete this step to verify your new email address at so.did.we.

   Click, or copy and paste the link below into your browser address bar:

   http://www.sodidwe.com/activate_new_email.php?user_id=$user_id&sequence=$db_password

   See you on the site!
   [e-mail]

   so.did.we
   where strangers become friends"   

   ;
   //end of message
	$headers  = "From: $from\r\n";
    $headers .= "Content-type: text/plain";

mail($to, $subject, $message, $headers);

//!!!!!!!!!!!!!    End Email   !!!!!!!!!!!!!!!!!!
		exit();
		}//END EMAIL CHECK 
	exit();
	}//END ELSE FOR MISSING FIELDS	

exit();
}//***************END NEW EMAIL FORM





//******************************************BEGIN NEW PASSWORD FORM********************************************//
if (isset($_POST['parse_var']) == "form_new_password"){

$current_password = $_POST['current_password'];
$new_password = $_POST['new_password'];
$confirm_password = $_POST['confirm_password'];

$current_password = mysql_real_escape_string($current_password);
$new_password = mysql_real_escape_string($new_password);
$confirm_password = mysql_real_escape_string($confirm_password);

if ($new_password != $confirm_password) {
	$error_msg = "ERROR: Your Passwords Did Not Match.";
	exit(); 
}

$hash_cur_pass = md5($current_password);
$hash_new_pass = md5($new_password);

if (empty($current_password) || empty($new_password) || empty($confirm_password)) {
	$error_msg = "ERROR: Missing Fields Required.";
}else {	

$sql = mysql_query("SELECT password FROM member_profile WHERE user_id='$user_id' AND password='$hash_cur_pass'");
$pass_check_num = mysql_num_rows($sql);

 if ($pass_check_num > 0) {
	 $sqlUpdate = mysql_query("UPDATE member_profile SET password='$hash_new_pass' WHERE user_id='$user_id'");
	 $success_msg = "Your Account Settings Have Been Updated.";
      exit(); 
 } else {
	$error_msg = "ERROR: Your Account Information Does Not Match With Our Files. Please contact the site administrator at [e-mail]";
     exit(); 
 }

exit();	 
 }//END ELSE FOR MISSING FIELD	
exit(); 	
}//***************END NEW PASSWORD FORM





//*****************************************BEGIN DELETE ACCOUNT FORM***************************************//
if (isset($_POST['parse_var']) == "delete_account"){

$username = $_POST['username'];
$del_acct_pass = $_POST['del_acct_pass'];

$username = mysql_real_escape_string($username);
$del_acct_pass = mysql_real_escape_string($del_acct_pass);

$hash_cur_pass = md5($del_acct_pass);


$sqlUpdate = mysql_query("SELECT * member_profile WHERE username='$username' AND password='$hash_cur_pass' AND user_id='$user_id'");
	$pass_check_num = mysql_num_rows($sql);
 	if ($pass_check_num > 0) {
	 	$success_msg = 'Are You Absolutely Sure You Want To Delete Your Account?<br /> <br />
	  	<a class="content" href="edit_account_settings.php?choice=no">NO</a> 
		&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;|&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
		<a class="content" href="edit_account_settings.php?choice=yes">YES</a>';
      exit(); 
	}

}//***************END DELETE ACCOUNT FORM


//***********ACTION TAKEN TO DELETE ACCOUNT IF USER CHOOSES YES************//
if ($_GET['choice'] == "yes") {

$user_pic = ("members/$username/image01.jpg");
if (file_exists($user_pic)) {
	unlink($user_pic);
}
//removes directory
$dir = "members/$username";
rmdir($dir);

include_once "includes/scripts/connect_to_mysql.php";

$sqlTable1 = mysql_query("DELETE * FROM member_profile WHERE user_id='$user_id'"); 
$sqlTable2 = mysql_query("DELETE * FROM member_feed WHERE user_id='$user_id'");
$sqlTable3 = mysql_query("DELETE * FROM calendar_events WHERE user_id='$user_id'");
session_destroy();
$success_msg = "Goodbye! Your Account has been Deleted";
 exit(); 

} else if ($_GET['choice'] == "no") {

include_once 'member_profile.php'; 
exit(); 
}

?>

<form id="form_new_name" name="form_new_name" method="post" action="<?php echo $PHP_SELF;?>" >



<table class="formDetails">



<?php if(isset($error_msg)){?>
			<p class="errorText"><?php echo "$error_msg";?></p>
	<?php }?>
	<?php if(isset($success_msg)){?>
			<p class="successText"><?php echo "$success_msg";?></p>
	<?php }?>





<tr class="formDetails"><p class="eventform">		
	<td class="formField" align="left">Your Name:</td>
	<td class="formDetails" align="left"><?php echo "$firstname $lastname"; ?></td></p>
</tr>

<tr class="formDetails"><p class="eventform">		
	<td class="formField" align="left"><label for="new_firstname">New First Name:</label></td>
	<td class="formDetails" align="left"><input id="new_firstname" name="new_firstname" type="text" size="20" maxlength="100" class="required" />
			<img src="images/notice-note2.png" border="0" width="15" height="15" title='This Field is Required' />
	</td></p>
</tr>

<tr class="formDetails"><p class="eventform">		
	<td class="formField" align="left"><label for="new_lastname">New Last Name:</label></td>
	<td class="formDetails" align="left"><input id="new_lastname" name="new_lastname" type="text" size="20" maxlength="100" class="required" />
			<img src="images/notice-note2.png" border="0" width="15" height="15" title='This Field is Required' />
	</td></p>
</tr>

<tr class="formDetails">
	<td class="formField" align="left"></td>
	<td class="formDetails" align="left"><input type="submit" name="submit" value="Submit Changes" /></td>
	<td><input name="parse_var" type="hidden" value="form_new_name" /></td>
</tr>

</table>

</form>

[bradgrafelman]

First problem I notice is this:

if (isset($_POST['parse_var']) == "form_new_name")

What are you trying to do here? [man]isset/man returns boolean TRUE or FALSE, not strings such as "form_new_name". If you're trying to test the value of $_POST['parse_var'] there, break that up unto two different conditions, e.g.:

if(isset($foo) && $foo == 'something')

[niroshan]

Hi everythingis,

I like to point out some of the issues i see in your code as well,

1.

if (isset($_POST['parse_var']) == "form_new_name"){

As bradgrafelman says isset well return true or false instead of a string. so to check the form submission instead you can simply use,

if(isset($_POST['submit']))
{
}

2. I have seen different blocks to check each and every items in the form. ex:

//*****BEGIN NEW FIRST AND LAST NAME FORM***//
//-- Code --

//*****BEGIN NEW USERNAME FORM***//
//-- Code --

Why dont you check everything in one place and finally update the record once. Because in your case your using so many updates queries and that will effect the performance of your application as well.

3. Why are you using exit() if you wish to display the error message.

if ($sqlUpdate){
$success_msg = "Your Account Settings Have Been Updated.";
exit();

} else {
$error_msg = "ERROR: Your Account Settings Could Not Be Updated, Please Try Again Later.";
exit();
}

If you exit() it will simply exit the whole application process instead of going into the below code execution.

4.

$success_msg = 'Are You Absolutely Sure You Want To Delete Your Account?<br /> <br />
<a class="content" href="edit_account_settings.php?choice=no">NO</a>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;|&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
<a class="content" href="edit_account_settings.php?choice=yes">YES</a>';

Don`t you think javascript confirm would be much more efficient?

Regards,
niroshan

[everythingis]

Oh, thanks, I'll take out those exits(). I thought I needed them for each expression, so that'll help.

The reason why I have several different checks is because this is an optional account edit form, where the user doesn't need to edit all their details, just the specific ones. So, I want it to run separately for each if they decide not to edit certain values.

Also, because there are different forms, I want to make sure that the submit button for each section only affects the specific form that it applies to, so if i only use:

if(isset($_POST['submit'])) 

for each section, how will it distinguish between which button is being pressed?

I entered a hidden field to define each form right below each submit button:

<td><input name="parse_var" type="hidden" value="form_new_name" /></td>
<td><input name="parse_var" type="hidden" value="form_new_username" /></td>
<td><input name="parse_var" type="hidden" value="form_new_email" /></td>
<td><input name="parse_var" type="hidden" value="form_new_password" /></td>
<td><input name="parse_var" type="hidden" value="form_delete_account" /></td>

So is this correct for each section?

if(isset($_POST['parse_var']) && $_POST['parse_var'] == 'form_new_name') 

if(isset($_POST['parse_var']) && $_POST['parse_var'] == 'form_new_username') 

PHP]if(isset($POST['parse_var']) && $POST['parse_var'] == 'form_new_email') [/code]
etc.

[niroshan]

Hi everythingis,

Also, because there are different forms, I want to make sure that the submit button for each section only affects the specific form that it applies to, so if i only use:

Your provided code has only one form thats why i suggested that 🙂

since you have different forms for each section with a hidden field what you have suggested latter will work.

if(isset($_POST['parse_var']) && $_POST['parse_var'] == 'form_new_name') 

Make sure you have the hidden fields inside the relevant form.

Regards,
Niroshan

[everythingis]

Ok, I got the error messages working now, just have to test it with an existing user to see if everything else works properly.

I might need some future help with this so I'll keep the thread open for now.

[Weedpacket]

If this problem is resolved it would be better to mark it as such; if you have another problem later, start a new thread.