Form Validation Help Please?!?!

Adam1234

Hello I am trying to validate a form using 2 files...."form4.php" and "form4.inc"....The form should validate the data placed into the form then direct the user to a summary page after pressing the Submit button. However, I keep getting an error message....

"Parse error: syntax error, unexpected T_ELSE in /Applications/MAMP/htdocs/lesson4/form4.inc on line 150"

I really am struggling with this and I just can't find the problem....I have tried deleting the whole "foreach" loop included in the error message...this eliminates the Parse error but then a whole new set of problems occur so I put it back in. Any help would be GREATLY appreciated! Thank you,

Adam1234

Here is the code.....
Form4.php----------------------------

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>Form 4t</title>

</head>

<body>

<?php

include("form4.inc");

/* loop that displays the form */
  echo "<form action='form4.inc' method='post'>";
  foreach($labels as $field => $label)
  {
    echo "<div id='field'><label for='$field'>$label</label>
            <input id='$field' name='$field' type='text' value='".@$$field."'  

   size='50%' maxlength='65' /></div>\n";
  }





  {
  echo  "<div id='radio'><label for='$field'>Male</label>
  <input type='radio' name='$field' id='$field' value='male'/></div> <br />

  <div id='radiofem'> 
  <label for='$field'>Female</label>
  <input type='radio' name='$field' id='$field' value='female'/> </div>";
   	}		
	echo "<div id='submit'>
  <input type='submit' name= 'submitButton' value='Submit Information'>


</form>";

?>
</body>
</html>

Form4.inc

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>form4.inc</title>
<style type='text/css'>
   <!--
      form {
        margin: 1.5em 0 0 0;
        padding: 0;
      }
      #field {padding-bottom: 1em;}
      label {
        font-weight: bold;
        float: left;
        width: 20%;
        margin-right: 1em;
        text-align: right;
      }
      #submit {
        margin-left: 35%;
      }
   -->
 </style>
</head>

<body>






<?php
/*  Program use: VALIDATE 
 *  Description:  Program checks all the form fields for
 *                invalide content
 */
foreach($_POST as $field => $value)
{
  if(empty($value))
  { 
    $blank_array[] = $field;
  } 


  else 
  {
    $good_data[$field] = strip_tags(trim($value));
  }



if(@sizeof($blank_array) > 0) 
{
  $message = "<p style='color: red; margin-bottom: 0;font-weight: bold'>
       You didn't fill in one or more required fields. 
       You must enter: 
       <ul style='color: red; margin-top: 0; 
           list-style: none' >";
}
}


foreach($blank_array as $value)
{
	{    

		$message .= "<li>$value</li>";
	  }
  	{
	$message .= "</ul>"; 
  echo $message;
  	}


{  
  extract($good_data);
include("form4.inc");

  exit();
    }
}



foreach($_POST as $field => $value)
{
  	if(!empty($value))
  {
    $last_name = "/^[A-Za-z' -]{1,50}$/";
	$first_name = "/^[A-Za-z' -]{1,50}$/";
	$email = "\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b}";
	$phone = "/^[0-9)(xX -]{7,20}$/";
	$order_date ="(19|20)\d\d[- /.](0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])";
	$address = "^[0-9)( A-Za-z-]{7,20}";
	$city ="[A-Za-z ] {50}";
	$state = "/A-Za-z {2}/";
	$radio = "/(male|female)/";
    }

 if(!preg_match($last_name,$value))
  {
    $error_array[] = "$value is not a valid name";
  }
  if(!preg_match($first_name,$value))
  {
    $error_array[] = "$value is not a valid name";
  }
  if(!preg_match($email,$value))
  {
    $error_array[] = "$value is not a valid email";
  }

if(preg_match($phone,$value))
{
    $error_array[] = "$value is not a valid phone number";
  }



  if(!preg_match($radio,$value))
  {
    $error_array[] = "$value is not a valid gender";
  }


  $clean_data[$field] = strip_tags(trim($value));


if(@sizeof($error_array) > 0) 
{
$message = "<ul style='color: red; list-style: none' >";
}
}

  foreach($error_array as $value)

  {
    $message .= "<li>$value</li>";
  }
  {
  $message .= "</ul>"; 
	}
  {
  echo $message;
  extract($clean_data);
}
  exit();	

else
{
  echo "Data is all okay";
} 
}

?>  











<?php


$labels = array( "last_name" => "Last Name",
				"first_name" => "First Name",
				"email" => "Email",
				"phone" => 'Phone',
				'order_date' => "Order Date",
				"address" => "Address",
				"city" => "City",
				"state" => "State");

$radios = array( "male"=> "Male",
				 "female"=> "Female");














?>
</body>
</html>

halojoy

you have an else on line 150 in form4.inc
now PHP only expects an ELSE following an IF
and in this case was not an IF before this else

Adam1234

Thank you halojoy,
I took out the else statement again which gets rid of the parse error, but like before this opens up a whole new can of worms leaving this messages....

Notice: Undefined variable: blank_array in /Applications/MAMP/htdocs/lesson4/form4.inc on line 65

Warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/lesson4/form4.inc on line 65

Notice: Undefined variable: error_array in /Applications/MAMP/htdocs/lesson4/form4.inc on line 136

Warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/lesson4/form4.inc on line 136

I can't figure out what the problem is, in the code I'm to identify when the validation errors occur in the form...but I think I did define everything. Sorry for all the trouble but I've been stumped on this very problem for days now.

Here is the updated code getting rid of the else statement...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>form4.inc</title>
<style type='text/css'>
   <!--
      form {
        margin: 1.5em 0 0 0;
        padding: 0;
      }
      #field {padding-bottom: 1em;}
      label {
        font-weight: bold;
        float: left;
        width: 20%;
        margin-right: 1em;
        text-align: right;
      }
      #submit {
        margin-left: 35%;
      }
   -->
 </style>
</head>

<body>






<?php
/*  Program use: VALIDATE 
 *  Description:  Program checks all the form fields for
 *                invalide content
 */
foreach($_POST as $field => $value)
{
  if(empty($value))
  { 
    $blank_array[] = $field;
  } 


  else 
  {
    $good_data[$field] = strip_tags(trim($value));
  }



if(@sizeof($blank_array) > 0) 
{
  $message = "<p style='color: red; margin-bottom: 0;font-weight: bold'>
       You didn't fill in one or more required fields. 
       You must enter: 
       <ul style='color: red; margin-top: 0; 
           list-style: none' >";
}
}


foreach($blank_array as $value)
{
	{    

		$message .= "<li>$value</li>";
	  }
  	{
	$message .= "</ul>"; 
  echo $message;
  	}


{  
  extract($good_data);
include("form4.inc");

  exit();
    }
}



foreach($_POST as $field => $value)
{
  	if(!empty($value))
  {
    $last_name = "/^[A-Za-z' -]{1,50}$/";
	$first_name = "/^[A-Za-z' -]{1,50}$/";
	$email = "\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b}";
	$phone = "/^[0-9)(xX -]{7,20}$/";
	$order_date ="(19|20)\d\d[- /.](0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])";
	$address = "^[0-9)( A-Za-z-]{7,20}";
	$city ="[A-Za-z ] {50}";
	$state = "/A-Za-z {2}/";
	$radio = "/(male|female)/";
    }

 if(!preg_match($last_name,$value))
  {
    $error_array[] = "$value is not a valid name";
  }
  if(!preg_match($first_name,$value))
  {
    $error_array[] = "$value is not a valid name";
  }
  if(!preg_match($email,$value))
  {
    $error_array[] = "$value is not a valid email";
  }

if(preg_match($phone,$value))
{
    $error_array[] = "$value is not a valid phone number";
  }



  if(!preg_match($radio,$value))
  {
    $error_array[] = "$value is not a valid gender";
  }


  $clean_data[$field] = strip_tags(trim($value));


if(@sizeof($error_array) > 0) 
{
$message = "<ul style='color: red; list-style: none' >";
}
}

  foreach($error_array as $value)
  {
  {
    $message .= "<li>$value</li>";
  }
  {
  $message .= "</ul>"; 
	}
  {
  echo $message;
  extract($clean_data);
}
  exit();	
}	



?>  











<?php


$labels = array( "last_name" => "Last Name",
				"first_name" => "First Name",
				"email" => "Email",
				"phone" => 'Phone',
				'order_date' => "Order Date",
				"address" => "Address",
				"city" => "City",
				"state" => "State");

$radios = array( "male"=> "Male",
				 "female"=> "Female");














?>
</body>
</html>

halojoy

Adam1234
I have been working on your script now for maybe 2-3 hours.
And it has been great fun! 🙂
Because you have some good ideas in your script.

Now it is only 1 page.
To use the include only confused and messed.

Your script is working.
But it is not finished.
Especially the preg_match regex we need help with.
I know a bit, but I am not good with REGEX.
I have fixed small things, so now it looks like

		$last_name = "/^[A-Za-z' -]{1,50}$/";
		$first_name = "/^[A-Za-z' -]{1,50}$/";
		$email = "/\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/";
		$phone = "/^[0-9)(xX -]{7,20}$/";
		$order_date ="#(19|20)\d\d[- /.](0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])#";
		$address = "/^[0-9 A-Za-z-]{7,20}/";
		$city ="/[A-Za-z ]{50}/";
		$state = "/^[A-Za-z]{2}$/";
		$gender = "/male|female/";

Here is the script.
It works and most should be according to your original idea.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>form4.inc</title>
<style type='text/css'>
<!--
form {
margin: 1.5em 0 0 0;
padding: 0;
}
#field {padding-bottom: 1em;}
label {
font-weight: bold;
float: left;
width: 20%;
margin-right: 1em;
text-align: right;
}
#submit {
margin-left: 35%;
}
-->
</style>
</head>

<body>

<?php

if(isset($_POST['submitButton'])){

/* Program use: VALIDATE
* Description: Program checks all the form fields for
* invalide content
*/

// Submitbutton is not a data to validate
unset($_POST['submitButton']);

$blank_array = $good_data = array();
foreach($_POST as $field => $value)
{
	$value = strip_tags(trim($value));
	if(empty($value))
	{
		$blank_array[] = $field;
	}
	else
	{
		$good_data[$field] = $value;
	}
}

if(sizeof($blank_array) > 0)
{
	$message = "<p style='color: red; margin-bottom: 0;font-weight: bold'>
	You didn't fill in one or more required fields.
	You must enter:
	<ul style='color: red; margin-top: 0;
	list-style: none' >";
	foreach($blank_array as $value)
	{
		$message .= "<li>$value</li>";
	}
	$message .= "</ul>";
	extract($good_data);
}
else
{
	$last_name = "/^[A-Za-z' -]{1,50}$/";
	$first_name = "/^[A-Za-z' -]{1,50}$/";
	$email = "/\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/";
	$phone = "/^[0-9)(xX -]{7,20}$/";
	$order_date ="#(19|20)\d\d[- /.](0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])#";
	$address = "/^[0-9 A-Za-z-]{7,20}/";
	$city ="/[A-Za-z ]{50}/";
	$state = "/^[A-Za-z]{2}$/";
	$gender = "/male|female/";

	$error_array = array();
	foreach($_POST as $field => $value)
	{
		$value = strip_tags(trim($value));
		if(!preg_match($$field,$value))
		{
			$error_array[] = "$value is not a valid ".$field;
		}
		$clean_data[$field] = $value;
	}

	if(sizeof($error_array) > 0)
	{
		$message = "<ul style='color: red; list-style: none' >";
		foreach($error_array as $value)
		{
			$message .= "<li>$value</li>";
		}
		$message .= "</ul>";
		extract($clean_data);
	}
	else
	{
		echo "Data is all okay";
	}

}

}// End form submitted

// Start FORM Display part
$labels = array( 
"last_name" => "Last Name",
"first_name" => "First Name",
"email" => "Email",
"phone" => 'Phone',
'order_date' => "Order Date",
"address" => "Address",
"city" => "City",
"state" => "State");
$radios = array( "male"=> "Male", "female"=> "Female");
if(!isset($message))
	$message = '';

/* loop that displays the form */
  echo '<form action="'.$_SERVER['PHP_SELF'].'" method="post">';
  foreach($labels as $field => $label)
  {
  	if(!isset($$field))
  		$$field = '';
    echo "<div id='field'><label for='$field'>$label</label>
            <input id='$field' name='$field' type='text' value='".$$field."'  

   size='50%' maxlength='65' /></div>\n";
  }

  if(!isset($gender))
  		$gender = '';  

  $ch1=$ch2='';
  if($gender=='male')   $ch1 = ' checked="checked"';
  if($gender=='female') $ch2 = ' checked="checked"';
  echo "<div id='radiomale'><label for='radiomale'>Male</label>
  <input type='radio' name='gender' id='radiomale' value='male'$ch1 /></div> <br />
  <div id='radiofem'>
  <label for='radiofem'>Female</label>
  <input type='radio' name='gender' id='radiofem' value='female'$ch2 /></div>";

echo "<div id='submit'>
  <input type='submit' name= 'submitButton' value='Submit Information'></div>
  </form>";
	echo $message; //Error messages

?>
</body>
</html>

Adam1234

Thank you so much halojoy! I really appreciate all the help!