Help with $_POSt as $key => $val

[hydraulics]

Hi guys,

Well im having a little trouble with arrays, im currently building a system but dont want to have to write out $var = 800000000 times over.

So my plan of action is to do a working method as follows

<?php
if($SERVER['REQUEST_METHOD'] == 'POST')
{
if(isset($POST['apply']))
{
$errors = array();
$postdata = array();
foreach($_POST as $key => $value)
{

   $postdata[$key] = trim(strip_tags($value));

  }
     validate_post($postdata, $errors);

}
}
elseif(validate_post() == true)
{
insertdata($postdata, $table='my table');
}
else
{
$errors = '';

//
SHOW FORM + errors
if($errors > 0){foreach($errors as $error => $err){print($err);}}
}

FUNCTIONS

function validate_post($postdata, $errors = null)
{
foreach($postdata as $key => $value)
{
// validate
if(empty($value))
{
array_push($errors, 'No field must be empty!');
}
if($key == 'email')
{
if(preg_match('regex', $value)
{
array_push($errors, 'Email is in-correct')
}
}
return $errors;

}

return true;
}

function insertdata($postdata, $table, $errors = null)
{
foreach($postdata as $key => $value)
{
$query = 'INSERT INTO '.$table.'($key)VALUES('".mysqli_real_escape_string($value)."') ';

if($result->mysqli_query($mysqli, $query))
{
print('HOOOOORAY');
}
else
{
print('DAMN YOU!');
}

}

}

?>

As you can see im not great with arrays, so if anyone could look over my code?

Im not looking for someone to building the code for me but maybe a push in the right direction would be great guys.

Regards,

[dagon]

hydraulics;10950554 wrote:

As you can see im not great with arrays, so if anyone could look over my code?

Im not looking for someone to building the code for me but maybe a push in the right direction would be great guys.

Not actully sure what you are asking. Does the above not work? If so what specifically is the issue?

[Weedpacket]

When posting PHP code, please use the tags described in the FAQ to preserve its formatting and make it easier to read; thank you.

[hydraulics]

dagon;10950570 wrote:

Not actully sure what you are asking. Does the above not work? If so what specifically is the issue?

Thanks for the responce dagon,
Well the above code is an outline of what im trying to achieve, or similar.
The code is written with my very little knowledge of arrays(), I know shame on me PHP101. I basically want to find a way to create a function to validate and input data from ALL postdata from my forms.

// I dont want to write any redundant code for example: ie:
$var = filterString($_POST['']);
$var2 = filterString($_POST['']);
$var3 = filterString($_POST['']);
$var4 = filterString($_POST['']);

$query = '';

//and then have to create a query for each form that needs it.

so lets say I have two(2) forms for example. I want to write it like so:

Applications
validate($postdata), then if true inputdata($postdata, $table='applications')

Contact Form
validate($postdata), then if true inputdata($postdata, $table='contact')

The code is throwing out errors but I dont mind de-bugging myself as long as I know im on the right path.

Thanks,

Weedpacket;10950578 wrote:

When posting PHP code, please use the tags described in the FAQ to preserve its formatting and make it easier to read; thank you.

Ok thanks for the tip.

[Weedpacket]

PHP does have a number of functions for working with arrays. There is, for example [man]array_map[/man]:

$_POST = array_map('filterstring', $_POST);

[man]array_keys[/man] and [man]array_filter[/man]:

$valid_fields = array_keys(array_filter($_POST, 'validate'));
if(count($valid_fields) == count($_POST))
{
    // All fields are valid.
}
else
{
    $invalid_fields = array_diff_key($_POST, array_flip($valid_fields));
    // $invalid fields contains the elements of the $_POST array that validate() rejected.
}

Of course, what validate() would do for each particular field depends on what each particular field is supposed to contain...

[halojoy]

This script is a work I did for Register User.
It puts a very basic form in center of the page.
If the inputs do not validate, a message is displayed below form.
What is left to do is the actual DB INSERT new User.

I use [man]filter[/man]
These are PHP functions to filter, sanitize and validate different data.
For exampe I use the FILTER_VALIDATE_EMAIL flag to check email.

I am sure you will find something useful in my code.
About validating data in $POST as an array:
Remember you have at least one extra field $POST['submit'], which may need to be removed.

This code is a demo. It can be run directly as it is.

<?php

if(!function_exists('filter_var'))
	exit('You need at least PHP 5.2 to use filter_var()');

if(isset($_POST['done'])){
	// trim & filter
	extract(array_map('trim',$_POST));
	$user = filter_var($user,FILTER_SANITIZE_STRING,FILTER_FLAG_NO_ENCODE_QUOTES);
	$pass = filter_var($pass,FILTER_SANITIZE_STRING,FILTER_FLAG_NO_ENCODE_QUOTES);
	$pas2 = filter_var($pas2,FILTER_SANITIZE_STRING,FILTER_FLAG_NO_ENCODE_QUOTES);
	$mail = filter_var($mail,FILTER_SANITIZE_EMAIL);
	$mail = filter_var($mail,FILTER_VALIDATE_EMAIL);
	$city = filter_var($city,FILTER_SANITIZE_STRING,FILTER_FLAG_NO_ENCODE_QUOTES);
	// check & validate
	$msg = '';
	if(strlen($user)<4 || strlen($user)>20)     $msg = 'username 4-20 chars';
	elseif(strlen($pass)<6 || strlen($pass)>12) $msg = 'password 6-12 chars';
	elseif($pas2 != $pass)                      $msg = 'passwords dont match';
	elseif(!$mail)                              $msg = 'enter a valid email';
	elseif(strlen($city)<3 || strlen($city)>25) $msg = 'city 3-25 chars';
	// insert
	if(!$msg){
		// CONNECT DB
		// Check if username is already taken
		// IF NOT
			// Do some string_escape for the database, if needed
			// INSERT INTO database: $user,$pass,$mail,$city
			// Success
			// Message, link
			// exit();
		// ELSE
			// $msg = 'Username taken. Try another';
	}

}else{
	// at startup
	$msg=$user=$pass=$pas2=$mail=$city='';
}

?>
<html><body style="background-color:lightgray;">
<div style="text-align:center;margin:360px 0px 0px 0px;">Register
<form style="width:17em;margin:0px auto;text-align:left;padding:5;border:1px solid black;" method="post">
<div><input type="text"     name="user" value="<?php echo $user ?>"> <label>username</label></div>
<div><input type="password" name="pass" value="<?php echo $pass ?>"> <label>password</label></div>
<div><input type="password" name="pas2" value="<?php echo $pas2 ?>"> <label>pass again</label></div>
<div><input type="text"     name="mail" value="<?php echo $mail ?>"> <label>email</label></div>
<div><input type="text"     name="city" value="<?php echo $city ?>"> <label>city</label></div>
<div><input type="submit"   name="done" value="submit"></div>
</form><?php echo $msg ?></div>
</body></html>