[RESOLVED] Help please, [php errors]

[camaron]

(sorry for my english)

Im having some problems to delete something from my bd,
here is the situation:

I have a file with a route:

delete.php?contra=(md5hash)

and delete.php

<?php
include ("coneccionbla.php");
mysql_query("DELETE FROM club WHERE contra=". $_REQUEST["contra"] .";" ,$coneccionbla);
if (mysql_errno()!=0)
{
	echo "Error , comuniquese con nosotros : ". mysql_errno() . " - " . mysql_error();
	mysql_close($coneccionbla);
} else {
	header("location:index.html");
}
?>

idk whats the problem, please helpp 🙂

[bradgrafelman]

If $_REQUEST["contra"] contains string data, then you must surround its value with single quotes in the SQL query. Strings in SQL - just like PHP - must be delimited with quotes.

Also note that user-supplied data should never be placed directly into a SQL query, else you'll be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize it with a function such as [man]mysql_real_escape_string/man (for string data).

EDIT: Also, if you're getting SQL errors, note that it's not a PHP problem but a SQL problem. It's also helpful if you'd post the exact error message you're getting as well, rather than expecting us to guess what the problem is.

[camaron]

real situation:
delete.php?contra=005d4e88a203fc19bc47b2fe19331b09
this suppose to delete a record 392, but dont delete it D:

Error:

"Error al dessuscribirse, comuniquese con nosotros : 1046 - No database selected"

[bradgrafelman]

Well in addition to the errors I mentioned above, you also have another problem:

1046 - No database selected

Before you can do any operations on a table, you have to select a database first. Try using [man]mysql_select_db/man first.

[camaron]

steel dont working :S
i use this but with other column example "id", and works but with the column "contra" dont works...
maybe is becouse of the md5 hash... idk

[bradgrafelman]

Where do you use [man]mysql_select_db/man ? It doesn't matter which column you try to use, you'll always get an error if you don't select the database first..

[camaron]

whait, going to post all the things...

delete.php

<?php
include ("db.php");
mysql_query("DELETE FROM club WHERE CONTRA=". $_REQUEST["contra"] .";" ,$db);
if (mysql_errno()!=0)
{
	echo "Error al dessuscribirse, comuniquese con nosotros : ". mysql_errno() . " - " . mysql_error();
	mysql_close($db);
} else {
	header("location:index.html");
}
?>

and the db.php

<?php
# FileName="Connection_php_mysql.htm"
# Type="MYSQL"
# HTTP="true"
$hostname_db = "*****";
$database_db = "clubd";
$username_db = "*****";
$password_dbs = "*****";
$friendss = mysql_pconnect($hostname_db, $username_db, $password_db) or trigger_error(mysql_error(),E_USER_ERROR); 
?>

clubd is the bd and club is a table

pd: idk much of php, xD i made all of this with some tutorials on youtube, and the bd.php the dreamweaver do it

[bradgrafelman]

1. Unless you know about "persistent connections" and your host recommends that you use them, I would highly suggest you use [man]mysql_connect/man instead of [man]mysql_pconnect/man, as persistent connections can cause problems if not used correctly.

2. Again, you never use [man]mysql_select_db/man to select which database you want to use (which, incidentally, seems to be available in the $database_db variable).

[camaron]

hmmm i dont know what you are saying me xP
im noob with this things, but the "FROM" select tha table "club"
And the bd.php included select the database that is clubd

I try too with DELETE FROM clubd.club WHERE contra=.... but dont works too

[bradgrafelman]

camaron wrote:

And the bd.php included select the database that is clubd

No, it doesn't. The file db.php never uses [man]mysql_select_db/man, so db.php never selects the database.

camaron wrote:

hmmm i dont know what you are saying me xP

I'm saying quite simply: use [man]mysql_select_db/man to select the database before you perform any queries.

Perhaps its the language barrier that's causing problems? If so... ojalá que puedes entenderme si yo hablo en español:

Necesitas usar la función [man]mysql_select_db/man antes de [man]mysql_query/man para seleccionar la base de datos. Por ejemplo, puedes usarla en "db.php" después de [man]mysql_connect/man o [man]mysql_pconnect/man.

My apologies if my Spanish is hard to understand. :o

[camaron]

xD hablas español rofl, haber, tonces que pongo algo asi

<?php
include ("db.php");
mysql_select_db(club)
mysql_query("DELETE FROM * WHERE CONTRA=". $_REQUEST["contra"] .";" ,$db);
if (mysql_errno()!=0)
{
	echo "Error al dessuscribirse, comuniquese con nosotros : ". mysql_errno() . " - " . mysql_error();
	mysql_close($db);
} else {
	header("location:index.html");
}
?>

pero sigue sin funcar, me tira esto
Parse error: syntax error, unexpected T_STRING in /www/****/htdocs/delete.php on line 4

[bradgrafelman]

I used Spanish just in case you weren't understanding my English correctly. I (and the majority of the boad, more than likely) would prefer that you use English if at all possible. I can speak some Spanish... not enough to help you learn a computer programming language, more than likely. :o

Your problem is that you forgot an ending semicolon after the [man]mysql_select_db/man call that you added. In addition, strings in PHP (for example, the name of the db "club") must be enclosed in quotes.

[camaron]

i add the quotes
mysql_select_db("club")

but steel dont working :S
can i add you on msn? 🙂

[bradgrafelman]

camaron;10951102 wrote:

i add the quotes
mysql_select_db("club")

but steel dont working :S

Check if the function returns FALSE and, if so, output [man]mysql_error/man to see what the error message is.

Also, are you sure "club" is the correct database name? In your db.file, you have this:

$database_db = "clubd";

suggesting that "club" should actually be "clubdb" instead.

camaron;10951102 wrote:

can i add you on msn? 🙂

You can, but I hardly ever use MSN and I would much rather we keep the discussion here on the forums (so that others may participate and/or benefit if they come across this thread while searching).

[camaron]

Also, are you sure "club" is the correct database name? In your db.file, you have this:

yeah

i have to go to sleep :S its late here
anyway, thanks for all the help
can we continue with this tomorrow? 🙂

[bradgrafelman]

camaron wrote:

can we continue with this tomorrow?

Sí - claro. 🙂 Hasta mañana...!

[Weedpacket]

mysql_query("DELETE FROM club WHERE CONTRA=". $_REQUEST["contra"] .";" ,$db); 

Since this contra is a string, it will need to be quoted in the SQL statement.

mysql_query("DELETE FROM club WHERE CONTRA='". $_REQUEST["contra"] ."'" ,$db); 

[camaron]

THANKSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
SSSSSSSSSSSSSS....

Final code:

<?php
include ("db.php");
mysql_select_db("club");
mysql_query("DELETE FROM club WHERE CONTRA='". $_REQUEST["contra"] ."'" ,$db);
if (mysql_errno()!=0)
{
	echo " No se ah podido borrar: ". mysql_errno() . " - " . mysql_error();
	mysql_close($db);
} else {
	header("location:index.html");
}
?>

I use the select_db (thanks brad)
And the ' (thanks weed)

HEROES bradgrafelman AND Weedpacket

[bradgrafelman]

Hey, I'm no hero (although I can definitely picture Weedpacket in a cape). :p

Glad you figured it out. Don't forget to mark this thread resolved using the link on the Thread Tools menu above.

[Weedpacket]

Nononono...definitely no cape. No capes!