Help-Error: Undefined Index

Tonata

Hi Guys please help me, I am trying to update My database through an HTML form. To be more clear, i have a poll management database, I list the polls by generating a dynamic table. The user has operations (Update, Delete, Insert new polls).

The user can perform these operations by clicking on the Table Row

<td><a href="update.php?operation=U&id=<?php echo $polls[$i]['id']?>">Update</a>

it works well there, after clicking on that link, it directs to update.php. there's simply a form there where 1 can enter update values. but when i submit the form i get the following errors.

Notice: Undefined index: text in C:\wamp\www\poll_management\polls\operations.php  on line 46

Notice: Undefined index: choice2 in C:\wamp\www\poll_management\polls\operations.php on line 48

Notice: Undefined index: choice3 in C:\wamp\www\poll_management\polls\operations.php on line 49

Notice: Undefined index: choice4 in C:\wamp\www\poll_management\polls\operations.php on line 50

Notice: Undefined index: choice5 in C:\wamp\www\poll_management\polls\operations.php on line 51

Notice: Undefined index: active in C:\wamp\www\poll_management\polls\operations.php on line 54

Notice: Undefined index: id in C:\wamp\www\poll_management\polls\operations.php on line 55
UPDATE polls SET name = "Reader_Name", text = "", choice1 = "", choice2 = "", choice3 = "", choice4 = "", choice5 = "", validFrom = "0000-00-00", validTo = "0000-00-00", active = "" WHERE id = 0

My operations.php looks like this

case 'U':

$sql = 'UPDATE polls SET
           name = "'.mysql_real_escape_string($_POST['name']).'",
           text = "'.mysql_real_escape_string($_POST['text']).'",
           choice1 = "'.mysql_real_escape_string($_POST['choice1']).'",
           choice2 = "'.mysql_real_escape_string($_POST['choice2']).'",
           choice3 = "'.mysql_real_escape_string($_POST['choice3']).'",
           choice4 = "'.mysql_real_escape_string($_POST['choice4']).'",
           choice5 = "'.mysql_real_escape_string($_POST['choice5']).'",
           validFrom = "'.$_POST['validFrom'].'",
           validTo = "'.$_POST['validTo'].'",
           active = "'.mysql_real_escape_string($_POST['active']).'"
          WHERE id = '.intval($_POST['id']);				

mysql_query($sql, $link);
echo $sql;
exit;

break;

Tonata

OK, i figured where the problem is, somehow is not passing one of my values( "echo $_POST['text'];"). Im using Tiny_mce here as an input... Can any one help me please.

anakadote

Those are just notices, not fatal errors, but you can turn those off using a different error_reporting value, however, they can be helpful during development:

error_reporting(E_ALL ^ E_NOTICE);

The notices mean that your $POST indexes aren't set ($POST['choice1'], etc..) when you submit the form, so make sure that your form method is "post" and not "get".

anakadote

I'd like to see your tinyMCE.init code and your form.

Tonata

Form

<form action="operations.php?operation=<?php echo $_GET['operation']?>&id=<?php echo intval($_GET['id'])?>" method="post" enctype="multipart/form-data" onsubmit="">
<tr><td>Poll Name:</td><td><input type="text" name="name" value="<?php echo $row['name']?>" ></td></tr>
<tr><td>Choice1:</td><td><input type="checkbox" name="choice1" value="x" title="check" <?php if ("x" ==$row['choice1']) echo "checked"?>/></td></tr>
<tr><td>Choice2:</td><td><input type="checkbox" name="choice2" value="x" title="check" <?php if ("x" ==$row['choice2']) echo "checked"?> ></td></tr>
<tr><td>Choice3:</td><td><input type="checkbox" name="choice3" value="x" title="check" <?php if ("x" ==$row['choice3']) echo "checked"?> /></td></tr>
<tr><td>Choice4:</td><td><input type="checkbox" name="choice4" value="x" title="check" <?php if ("x" ==$row['choice4']) echo "checked"?> /></td></tr>
<tr><td>Choice5:</td><td><input type="checkbox" name="choice5" value="x" title="check" <?php if ("x" ==$row['choice5']) echo "checked"?> /></td></tr>
<tr><td>Valid From:</td><td><input type="text" name="validFrom" value="<?php echo $row['validFrom']?>" /></td></tr>
<tr><td>Valid To:</td><td><input type="text" name="validTo" value="<?php echo $row['validTo']?>" ></td></tr>
<tr><td></td><td>Please insert date in YYYY-MM-DD format</td></tr>
<tr><td>Valid To:</td><td><input type="text" name="active" value="<?php echo $row['active']?>" ></td></tr>
<tr><td></td><td>put 1=active AND 0=not active</td></tr>

tinyMCE.init

Text:
<script type="text/javascript" src="jquery/jquery/jquery.js"></script>
<script type="text/javascript" src="tiny_mce/tiny_mce.js"></script>
<script type="text/javascript">
tinyMCE.init({
	// General options
	mode : "textareas",
	theme : "advanced",
	plugins : "safari,spellchecker,pagebreak,style,layer,table,save,advhr,advimage,advlink,emotions,iespell,inlinepopups,insertdatetime,preview,media,searchreplace,print,contextmenu,paste,directionality,fullscreen,noneditable,visualchars,nonbreaking,xhtmlxtras,template,imagemanager,filemanager",

// Theme options
theme_advanced_buttons1 : "save,newdocument,|,bold,italic,underline,strikethrough,|,justifyleft,justifycenter,justifyright,justifyfull,|,styleselect,formatselect,fontselect,fontsizeselect",
theme_advanced_buttons2 : "cut,copy,paste,pastetext,pasteword,|,search,replace,|,bullist,numlist,|,outdent,indent,blockquote,|,undo,redo,|,link,unlink,anchor,image,cleanup,help,code,|,insertdate,inserttime,preview,|,forecolor,backcolor",
theme_advanced_buttons3 : "tablecontrols,|,hr,removeformat,visualaid,|,sub,sup,|,charmap,emotions,iespell,media,advhr,|,print,|,ltr,rtl,|,fullscreen",
theme_advanced_buttons4 : "insertlayer,moveforward,movebackward,absolute,|,styleprops,spellchecker,|,cite,abbr,acronym,del,ins,attribs,|,visualchars,nonbreaking,template,blockquote,pagebreak,|,insertfile,insertimage",
theme_advanced_toolbar_location : "top",
theme_advanced_toolbar_align : "left",
theme_advanced_statusbar_location : "bottom",
theme_advanced_resizing : true,

// Example content CSS (should be your site CSS)
content_css : "css/example.css",

// Drop lists for link/image/media/template dialogs
template_external_list_url : "js/template_list.js",
external_link_list_url : "js/link_list.js",
external_image_list_url : "js/image_list.js",
media_external_list_url : "js/media_list.js",

// Replace values for the template plugin
template_replace_values : {
	username : "Some User",
	staffid : "991234"
}
})
</script>

bradgrafelman

For one thing, this "choice1", "choice2", etc. column naming makes me think you need to find a good tutorial/article (or two) on database normalization.

You're getting the notices about the checkboxes because unchecked checkboxes aren't submitted at all. I think you could benefit here from submitting checkboxes as an array, e.g.:

<input type="checkbox" name="choice[]" value="1">Choice 1<br>
<input type="checkbox" name="choice[]" value="2">Choice 2<br>
<!-- etc. -->

That way, $_POST['choice'] will either be unset (no choices were selected) or it will be an array of values.