Add field to displaying mysql row

Peuplarchie

Good day to you all,
I'm still learning the wicked database world and i found a piece of code which read and display a db table without me telling each colum totle and field name.

Here is my code:


...
if (!mysql_connect($db_host, $db_user, $db_pwd))
    die("Can't connect to database");

if (!mysql_select_db($database))
    die("Can't select database");

// sending query
$result = mysql_query("SELECT * FROM {$table}");
if (!$result) {
    die("Query to show fields from table failed");
}

$fields_num = mysql_num_fields($result);

echo "<h1>Table: {$table}</h1>";
echo "<table border='0' id=\"table\" cellspacing=\"0\" cellpadding=\"0\" align=\"center\"><tr>";
echo "<td id=\"title\">options</td>";
// printing table headers
for($i=0; $i<$fields_num; $i++)
{

$field = mysql_fetch_field($result);
echo "<td id=\"title\">{$field->name}</td>";
}
echo "</tr>\n";
// printing table rows
$s = 0;
while(($row = mysql_fetch_row($result)) !== false){
	$s++;

echo "<tr>";
echo "<td id=\"fields".($s & 1)."\"><a href=\"delete_table_row_db.php?id=" . $s[id]. "\" title=\"DELETE : Row ID #:" . $s[id] . "\"><img src=\"Template/Images/delete.png\" border=\"0\"/></a><INPUT TYPE=\"checkbox\" name=\"" . $row['id'] . "\"></td>";

// $row is array... foreach( .. ) puts every element
// of $row to $cell variable
foreach($row as $cell)

    echo "<td id=\"fields".($s & 1)."\">$cell</td>";

echo "</tr>\n";
}
mysql_free_result($result);

In the part :


<td id=\"fields".($s & 1)."\"><a href=\"delete_table_row_db.php?id=" . $s[id]. "\" title=\"DELETE : Row ID #:" . $s[id] . "\"><img src=\"Template/Images/delete.png\" border=\"0\"/></a><INPUT TYPE=\"checkbox\" name=\"" . $row['id'] . "\"></td>";

What i'm trying to do is to add options to the row, ex: delete, edit...

My only problem is that I cannot find the var to put which would tell which row it is.

Can somebody help me ?
Thanks!

bradgrafelman

You're trying to extract data that's coming from the database out of the variable $s, which is nothing more than a counter variable. The variable that actually holds each row retrieved in the while() loop is $row.

Peuplarchie

I have tried with $row and even $row['id'].
It don't display anything.

bradgrafelman

$row['id'] should give you the value of the column named "id" in the database. If it's not working, show us the PHP code you tried when you used it, and also show us the raw HTML output that was generated.

Peuplarchie

Here is the code I used:



if (!mysql_connect($db_host, $db_user, $db_pwd))
    die("Can't connect to database");

if (!mysql_select_db($database))
    die("Can't select database");

// sending query
$result = mysql_query("SELECT * FROM {$table}");
if (!$result) {
    die("Query to show fields from table failed");
}

$fields_num = mysql_num_fields($result);

echo "<h1>Table: {$table}</h1>";
echo "<table border='0' id=\"table\" cellspacing=\"0\" cellpadding=\"0\" align=\"center\"><tr>";
echo "<td id=\"title\">options</td>";
// printing table headers
for($i=0; $i<$fields_num; $i++)
{

$field = mysql_fetch_field($result);
echo "<td id=\"title\">{$field->name}</td>";
}
echo "</tr>\n";
// printing table rows
$s = 0;
while(($row = mysql_fetch_row($result)) !== false){
	$s++;

echo "<tr>";
echo "<td id=\"fields".($s & 1)."\"><a href=\"delete_table_row_db.php?id=" . $row['id']. "\" title=\"DELETE : Row ID #:" . $row['id'] . "\"><img src=\"Template/Images/delete.png\" border=\"0\"/></a><INPUT TYPE=\"checkbox\" name=\"" . $row['id'] . "\"></td>";

// $row is array... foreach( .. ) puts every element
// of $row to $cell variable
foreach($row as $cell)

    echo "<td id=\"fields".($s & 1)."\">$cell</td>";

echo "</tr>\n";
}
mysql_free_result($result);

The output is hard since it's the href and title property of the link that the variable don't show.

bradgrafelman

Woops, didn't realize which mysql_fetch_*() function you were using.

As the manual states, [man]mysql_fetch_row/man returns an enumerated array, meaning that the array indexes are numbered from 0 to n-1, where n is the number of columns SELECT'ed.

To use associative array indeces (meaning that the index or key used is the actual column name in the SELECT query), use [man]mysql_fetch_assoc/man instead.

Peuplarchie

I don't want to physicly create to the table, only on the display, I would like to have the beginning field to have the option to edi row, delete row.

bradgrafelman

No idea what you're talking about... who said anything about creating a table?

[man]mysql_fetch_row/man returns an array with numeric indexes. You're not using these numeric indexes, you're using the column names (e.g. "id"), meaning you need to use [man]mysql_fetch_assoc/man to fetch an associative array.