Dynamic mysqli query ???

hydraulics

Hi guys,

Any help is greatly appreciated as always!

MY ERROR:
Warning: mysqli_query() [function.mysqli-query]: Couldn't fetch mysqli in D:\Program Files\WebDevelopments\Xampp\xampp\htdocs\vmsStandard\data\config.php on line 65
UNABLE TO SELECT * FROM news [WHERE null ][ORDER BY date][DESC][LIMIT 5]

As you can see my values are being sent to the query which has me a little puzzled.

Source:

function querydb($select_list, $tbl, $condition, $order, $scroll, $limit )
    {
        global $mysqli;
        $_SESSION['errors'] = array();
        $query = "SELECT ".$select_list." FROM ".$tbl." [WHERE ".$condition." ][ORDER BY ".$order."][".$scroll."][LIMIT ".$limit."]";
        if($result = mysqli_query($mysqli, $query))
        {
            $check = mysqli_num_rows($result);
            if(!$check > 0)
            {
                array_push($_SESSION['errors'], 'No results found!');
                return false;
            }
            else
            {
                while($row = mysqli_fetch_array($result))
                {
                    foreach($row as $data)
                    {
                        return  htmlentities($data);
                    }
                    return true;

            }


        }

    }
    else
    {
        array_push($_SESSION['errors'], 'UNABLE TO  SELECT '.$select_list.' FROM '.$tbl.' [WHERE '.$condition.' ][ORDER BY '.$order.']['.$scroll.'][LIMIT '.$limit.']'. mysqli_connect_error());
        return false;
    }
}

$select = querydb('*','news', '', 'date', 'DESC', '5');

bradgrafelman

Your SQL syntax isn't correct for MySQL.

See the MySQL manual for the proper syntax to use for SELECT statements

anakadote

Lose the square brackets:

$query = "SELECT $select_list FROM $tbl WHERE $condition ORDER BY $order $scroll LIMIT $limit";

Also, if your condition is "WHERE null", you're probably not going to return any rows. You can use "WHERE 1" instead.

NogDog

I'm guessing the OP was looking at the manual and included the square brackets that are used in the syntax description there to denote optional elements of the query (but should not be included in the actual query text). 🙂

bradgrafelman

NogDog;10951627 wrote:
I'm guessing the OP was looking at the manual and included the square brackets that are used in the syntax description there to denote optional elements of the query (but should not be included in the actual query text). 🙂

Heh, guess I never thought of reading that syntax literally... good call. :o