Deleting Files from Directory HELP!!

[mdversion1]

I needs some help.

I have this script that lists the files in a directory nicely with checkboxes to remove unwanted files but when I click the "Remove" button nothing happens. It won't delete anything. I think the problem lies in the array that unlinks the files. Any help is greatly appreciated.

Here's the code:

<?php 

// change this to your path (NO TRAILING [ / ]) 

$dir = "/path/to/dir/files"; 
?> 


<form action="view_image_list.php" method="post"> 
<table border=0 cellpadding=2 cellspacing=0 width=380 align=center> 
<tr> 
<td width=40 align=center valign=middle bgcolor=336699 nowrap height=21> 
&nbsp;</td> 
<td width=240 valign=middle bgcolor=336699 nowrap> 
<font size=2 color=FFFFFF><B>File Name</B></font></td> 
<td width=80 align=center valign=middle bgcolor=336699 nowrap> 
<font size=2 color=FFFFFF><B>File Size</B></font></td></tr> 

<?php

// Unlink Array
if ((submit)&&($fid != "")) { 
foreach($fid as $rfn) { 
$remove = "$dir/$rfn";  

unlink($remove); 
} 
}

// List Files in Directory
$handle=opendir($dir);  

while (($file = readdir($handle))!== false){  

    if ($file != "." && $file != "..") { 
 $size = filesize("$dir/$file"); 
$list .= '<tr><td width="40" align="center" valign="middle" bgcolor="93BEE"2 nowrap height="21">'; 
$list .= '<input type="checkbox" name="fid[]" value="'.$file.'"></td>'; 
$list .= '<td width="240" valign="middle" bgcolor="93BEE2" nowrap>'; 
$list .= '<font size="2" color="336699">'.$file.'</font></td>'; 
$list .= '<td align="center" width="80" valign="middle" bgcolor="93BEE2" nowrap>'; 
$list .= '<font size="2" color="336699">'.$size.' Kb</font></td></tr>'; 
    }  

} 
closedir($handle); 
echo $list; 
?> 
<tr> 
<td colspan="3" align="center" valign="middle" bgcolor="336699" nowrap height="21"> 
<font size="2" color="FFFFFF"><input type="submit" value="Remove"></font></td></tr></table>
</form>

[NogDog]

Start with the usual debugging by making sure all errors are being reported, e.g.:

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);

You may find that it's a permissions error or other useful information. If that's not it, try var_dump()-ing or print_r()-ing arrays and variables of interest to find out if they are populated as expected in order to narrow down where the problem is.

[mdversion1]

You know, you look at this stuff over and over sometimes and forget the littles that you should, then you post it and someone points it out then you feel stupid.

the $fid needed to be defined and some other little clean ups.

End results :

<?php 

// change this to your path (NO TRAILING [ / ]) 

$dir = "/path/to/dir/files"; 
?> 


<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post"> 
<table border=0 cellpadding=2 cellspacing=0 width=380 align=center> 
<tr> 
<td width=40 align=center valign=middle bgcolor=336699 nowrap height=21>&nbsp; 
</td> 
<td width=240 valign=middle bgcolor=336699 nowrap> 
<font size=2 color=FFFFFF><B>File Name</B></font></td> 
<td width=80 align=center valign=middle bgcolor=336699 nowrap> 
<font size=2 color=FFFFFF><B>File Size</B></font></td></tr> 
<?php 

$fid= $_POST['fid'];

if (("submit")&&($fid != "")) { 
foreach($fid as $rfn) { 
$remove = "$dir/$rfn";  

unlink($remove); 
} 
} 
$handle=opendir($dir);  

while (($file = readdir($handle))!== false){  

    if ($file != "." && $file != "..") { 
 $size = filesize("$dir/$file"); 
$list .= '<tr><td width="40" align="center" valign="middle" bgcolor="93BEE2" nowrap height="21">'; 
$list .= '<input type="checkbox" name="fid[]" value="'.$file.'"></td>'; 
$list .= '<td width="240" valign="middle" bgcolor="93BEE2" nowrap>'; 
$list .= '<font size="2" color="336699">'.$file.'</font></td>'; 
$list .= '<td align="center" width="80" valign="middle" bgcolor="93BEE2" nowrap>'; 
$list .= '<font size="2" color="336699">'.$size.' Kb</font></td></tr>'; 
    }  

} 
closedir($handle); 
echo $list; 
?> 
<tr> 
<td colspan="3" align="center" valign="middle" bgcolor="336699" nowrap height="21"> 
<font size="2" color="FFFFFF"><input type="submit" value="Remove"></font></td></tr></table>
</form>

Thanks again.

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

Also, don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu.