Displaying values from DB

nummer31

<?php 

[I]//Declaring Variables[/I]
$i = 0;
$lid = 0;
$cnt = 0;

include('connection.php');

[I]//Loop for counting the no. of records in a table and assigning to a variable[/I]
if($_POST['cnt'])
{
$cnt = $_POST['cnt'];
}

else
{
$ret = "Select count(id) from practise";
$ret_exe = mysql_query($ret, $link);
while($sr = mysql_fetch_row($ret_exe))
{
$cnt = $sr['0'];
}
}

[I]//Limiting retrival of data from the database by '10'[/I]
if($_GET['lid'])
{
$lid = 	$_GET['lid'];
}
$link = mysql_connect('localhost', 'root', '');
$db = mysql_select_db('practise1');
$sql = "SELECT *
FROM `practise`
LIMIT ".$lid." , 10";
$r = mysql_query($sql);

[I]//Printing the Headings of each column[/I]
print "<table border='1' align = 'center' width = '400px'>";
print "<td align = 'center' bgcolor = '#3399FF'>ID</td>";
print "<td align = 'center' bgcolor = '#3399FF'>Name</td>";
print "<td align = 'center' bgcolor = '#3399FF'>Roll</td>";
print "<td align = 'center' bgcolor = '#3399FF'>Registration</td>";
print "<td align = 'center' bgcolor = '#3399FF'>Delete</td>";
print "<td align = 'center' bgcolor = '#3399FF'>Edit</td>";


[I]//This Loop is for determining that odd numbered rows gonna have one color and even ones another [/I]
while($sr = mysql_fetch_row($r))
{
if ($i%2==0)
{
print "<tr bgcolor = '#666666'>";
}
else
{
print "<tr bgcolor = '#999999'>";
}
[I]//Assigning each index(array) to each column(td)[/I]
print "<td>".$sr[0]." </td>";
print "<td>".$sr[1]." </td>";
print "<td>".$sr[2]." </td>";
print "<td>".$sr[3]." </td>";
print "<td> <a href=\"delete.php?id=".$sr[0]."\">Delete</a> </td>";
print "<td> <a href=\"edit.php?id=".$sr[0]."\">Edit</a> </td>";
print "</tr>";
//The i that was used in coloring will increase by '1'
$i++;
}
print "</table>";


[I]//Determining when to show 'Next Page' and 'Last Page'[/I]
if($lid+10 < $cnt)
{
print "<a href=\"display.php?lid=".($lid+10)."\"> Next Page >> </a>";
print "<a href=\"display.php?lid=".(($cnt - ($cnt%10)))."\"> Last Page </a>";
}


[I]//Determining when to show 'Previous Page' and 'First Page'[/I]
if($lid>0)
{
print "<a href=\"display.php?lid=".($lid-10)."\"> << Previous Page </a>";
print "<a href=\"display.php\"> << First Page </a>";
}

?>

u guys prolly understood what is the coding for
so, some advice on how to make it better and more flexible
thanx in advance🙂

Weedpacket

First thing to do to make it more flexible: learn CSS.

Use [man]isset[/man] to check for the existence of a submitted data. Use [man]intval[/man] to make sure it's an integer.

Why is $cnt (and a longer variable name wouldn't go amiss) supplied once from $_POST and after that from the database?

Speaking of getting $cnt from the database, you're only getting one field from one row, so there's no point using a loop to do it.

Deletions should not be via <a> links. See The Spider of Doom.

nummer31

Weedpacket;10952032 wrote:
First thing to do to make it more flexible: learn CSS.

Use [man]isset[/man] to check for the existence of a submitted data. Use [man]intval[/man] to make sure it's an integer.

Why is $cnt (and a longer variable name wouldn't go amiss) supplied once from $_POST and after that from the database?

Speaking of getting $cnt from the database, you're only getting one field from one row, so there's no point using a loop to do it.

Deletions should not be via <a> links. See .

But how can i integrate CSS with PHP???
I should use [man]isset[/man] instead of [man]if else[/man] conditions
[man]intval[/man] would be used in case of defining colors for each row
Actually. the $cnt is used to limit the values retrieved from DB should be limited to 10 records per page and its not being posted from DB, it's from the page within. i didn't get it either cause a senior bro did it for me. could u plz me how to make it better?
I understand what u mean but the Delete hyperlinked to another page within the root directory so, shouldn't it be unreachable by a Bot and moreover, it's a Relative Path to the hyperlinked file. What alternative do u suggest?

At last but not the least, thank u very much for ur insight🙂

Weedpacket

nummer31 wrote:
1. But how can i integrate CSS with PHP???

Exactly the same way you integrate HTML with PHP. It doesn't matter. All that matters is that the HTML page the client receives references the stylesheet. No-one cares if the HTML page was dynamically generated or not.

I don't know; it's your script so you should know where the number is supposed to come from But once you've got it you can write [font=monospace]$cnt=min(1, max(10, intval($cnt)));[/font] to make sure it's something sensible (in this case an integer between 1 and 10 inclusive).
I don't know what you mean about the root directory being unreachable; bots aren't magical, they're just http clients and are just as capable of following any link that any other http client (such as a web browser) can follow.