[RESOLVED] PHP, SQL and HTML

John_wilson

Hi All.

I've sure its just me being special.

I have the following code

<?
$user=$_SESSION['user']; 
printf ("user: %s",$user);
$number=$_GET['num'];
printf ("number: %s",$number);
?>
<form method=POST name="update" action="updated.php">
Username: 
<input type=text name="<? echo $user;?>"><br> 
Password: 
<input type=password name="<? echo $number;?>"> 
<input type=submit value="Save"> 
</form>

This is supposed to put the value of user and number in the text boxes. so I can amend them and run and sql query to update the values.

I can print the user and number using

printf

but not echo in the text box.

Ideas?

Thanks

John

bradgrafelman

I changed your [noparse]

..

bbcode tags to

..

[/noparse] tags - please use these in the future when posting PHP code (in order to take advantage of the added syntax highlighting).

As for your problem, you're echoing the values of these variables into the 'name' attribute of the form elements. You're most likely wanting the 'name' attribute to be constant (e.g. 'username' and 'password', or something similar) and instead echo the values into a 'value' attribute.

Few other considerations...

You should start using the full '<?php' tag rather than the '<?' (or '<?=$var;?>') short tag syntax, as the latter has been deprecated for some time now (it's disabled by default and even removed in more recent versions of PHP).
When echo'ing user-supplied data into HTML, you might consider using [man]htmlentities/man (or something of that nature) in order to prevent the data from disrupting your HTML code.
You should always strive to write valid HTML syntax... consider running your resulting HTML pages through something like this and correcting any errors you get. 🙂

John_wilson

Thanks bradgrafelman I wondered how the syntax highlighting worked! I'll use the php tag from now on.

Thanks for the fix, once you put it in the value tag it all works spot on!

The other tips I'll put into practice! the site is only at alpha stages now so changing those tags should be fairly quick!

Another thread resolved! (possibly in record time?)