[RESOLVED] Undefined index: page in .. error for Pagination help

ugurpc

For pagination i try to use following. but i couldnt work. Thanks very much for helpers

error is Notice: Undefined index: page in ...\pagination.php on line 32

line 32 : $page=$_GET['page'];

ilgili kodlar :

...................................
/ Setup vars for query. /
$targetpage = "pagination.php"; //your file name (the name of this file)
$limit = 30; //how many items to show per page
$page=$_GET['page'];
if($page)
$start = ($page - 1) * $limit; //first item to display on this page
else
$start = 0; //if no page var is given, set start to 0

/ Get data. /
$sql = "SELECT * FROM $tbl_name LIMIT $start, $limit";
$result = mysql_query($sql);

/ Setup page vars for display. /
if ($page == 0) $page = 1; //if no page var is given, default to 1.
$prev = $page - 1; //previous page is page - 1
$next = $page + 1; //next page is page + 1
$lastpage = ceil($total_pages/$limit); //lastpage is = total pages / items per page, rounded up.
$lpm1 = $lastpage - 1;
..........................................

NogDog

Check to see if the $GET element is set before trying to use it:

$page = (isset($_GET['page'])) ? (int)$_GET['page'] : 0;

ugurpc

thanks nogdog for the answer,
i changed $page=$GET['page'];
with your offered code
$page = (isset($GET['page'])) ? (int)$_GET['page'] : 0;

then the notice error has been removed but the page gives empty white page at localhost.

but at the web the same codes with or without your offered change gives 2 errors.;

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in ..... /pagination.php on line 25

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in ..... /pagination.php on line 132

these lines are,
$total_pages = mysql_fetch_array(mysql_query($query));
and
while($row = mysql_fetch_array($result))

but localhost doesnt give these errors but only empty page.

i write here all the codes of pagination.php at below;

 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Sayfalama</title>
<link href="style.css" rel="stylesheet" type="text/css" />
</head>

<body>
<?php
	/*
		Place code to connect to your DB here.
	*/
	include('config.php');	// include your code to connect to DB.

$tbl_name="users";		//your table name
// How many adjacent pages should be shown on each side?
$adjacents = 3;

/* 
   First get total number of rows in data table. 
   If you have a WHERE clause in your query, make sure you mirror it here.
*/
$query = "SELECT COUNT(*) as num FROM $tbl_name";
$total_pages = mysql_fetch_array(mysql_query($query));
$total_pages = $total_pages['num'];

/* Setup vars for query. */
$targetpage = "pagination.php"; 	//your file name  (the name of this file)
$limit = 1; 								//how many items to show per page
$page = (isset($_GET['page'])) ? (int)$_GET['page'] : 0;
if($page) 
	$start = ($page - 1) * $limit; 			//first item to display on this page
else
	$start = 0;								//if no page var is given, set start to 0

/* Get data. */
$sql = "SELECT * FROM $tbl_name LIMIT $start, $limit";
$result = mysql_query($sql);

/* Setup page vars for display. */
if ($page == 0) $page = 1;					//if no page var is given, default to 1.
$prev = $page - 1;							//previous page is page - 1
$next = $page + 1;							//next page is page + 1
$lastpage = ceil($total_pages/$limit);		//lastpage is = total pages / items per page, rounded up.
$lpm1 = $lastpage - 1;						//last page minus 1

/* 
	Now we apply our rules and draw the pagination object. 
	We're actually saving the code to a variable in case we want to draw it more than once.
*/
$pagination = "";
if($lastpage > 1)
{	
	$pagination .= "<div class=\"pagination\">";
	//previous button
	if ($page > 1) 
		$pagination.= "<a href=\"$targetpage?page=$prev\">Â« previous</a>";
	else
		$pagination.= "<span class=\"disabled\">Â« previous</span>";	

	//pages	
	if ($lastpage < 7 + ($adjacents * 2))	//not enough pages to bother breaking it up
	{	
		for ($counter = 1; $counter <= $lastpage; $counter++)
		{
			if ($counter == $page)
				$pagination.= "<span class=\"current\">$counter</span>";
			else
				$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
		}
	}
	elseif($lastpage > 5 + ($adjacents * 2))	//enough pages to hide some
	{
		//close to beginning; only hide later pages
		if($page < 1 + ($adjacents * 2))		
		{
			for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//in middle; hide some front and some back
		elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//close to end; only hide early pages
		else
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
		}
	}

	//next button
	if ($page < $counter - 1) 
		$pagination.= "<a href=\"$targetpage?page=$next\">next Â»</a>";
	else
		$pagination.= "<span class=\"disabled\">next Â»</span>";
	$pagination.= "</div>\n";		
}
?>

<?php
	while($row = mysql_fetch_array($result))
	{

	// Your while loop here

	}
?>

<?=$pagination?>
</body>
</html>

bradgrafelman

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

ugurpc wrote:
localhost doesnt give these errors but only empty page.

That's probably because you don't have display_errors set to On and/or error_reporting set to E_ALL as you should when debugging/developing scripts locally. (In fact, it sounds like you've got it backwards - your live production site should not have display_errors set to On but rather utilize the log_errors directive instead.)

As far as the MySQL problems, when debugging MySQL errors the first thing you should do is retrieve the error message returned by the SQL server. To do so, I usually do something like this:

$query = 'SELECT foo FROM bar';
$exec = mysql_query($query) or die('MySQL Error: ' . mysql_error() . "<br>\nQuery: $query");

Make similar modifications to your code and let us know what the actual MySQL error message(s) is/are (as well as pasting the actual SQL query string as well - this helps you visually inspect the actual query that was sent to the SQL server).

ugurpc

Hi nogdog again,

i found my one error.

$tbl_name="users";
my table at database was Users. 1st character was in uppercase.
so i corrected as $tbl_name="Users";

now pagination works even i don't do your offered change at code.
But the data from database is not seen on the page.
what can i do for that ?
you can see here : http://ugurpc.com/work/sayfalama/2/pagination.php

thanks

bradgrafelman

ugurpc;10952503 wrote:
But the data from database is not seen on the page.

Of course it isn't... you never do anything with the data:

        while($row = mysql_fetch_array($result)) 
        { 

    // Your while loop here 

    }

ugurpc

Thanks bradgrafelman;

i will use
```
..
```
tags from now on. i was new to forums posting, sory.

i changed

        while($row = mysql_fetch_array($result)) 
        { 

// Your while loop here 

}

		while($row = mysql_fetch_array($result))
		{
			// Your while loop here
			echo "<table cellpadding=2 cellspacing=2 width=100%><tr>  </tr>";  

			echo "<tr>";  

			echo "<th bgcolor=#FFCC00  width=250px>id</th>";  

			echo "<td bgcolor=#FEE9A9>" . $row[0] . "</td>";    

			echo "</tr>";  

			echo "<tr>";    	
			echo "<tr>";  

			echo "<tr>";  

			echo "<th bgcolor=#FFCC00>pass</th>";  

			echo "<td bgcolor=#FEE9A9>" . $row[2] . "</td>";    

			echo "</tr>";  	
			echo "<tr>";  

			echo "<th bgcolor=#FFCC00>maxdownload</th>";  

			echo "<td bgcolor=#FEE9A9>" . $row[3] . "</td>";    

			echo "</tr>";  	
			echo "<tr>";  

			echo "<th bgcolor=#FFCC00>remarks</th>";  

			echo "<td bgcolor=#FEE9A9>" . $row[4] . "</td>";    

			echo "</tr>";

	}
	echo "</table>";

now it worked. thanks to nogdog and you.

But my question is now : is there any shorter or simple code to display the all data in the table?
or do i need to make many echo's like above everytime.?

thanks

bradgrafelman

ugurpc;10952509 wrote:
do i need to make many echo's like above everytime.?

Well, since you didn't include any line breaks, you could technically reduce all of that code down to 1 echo statement:

            echo "<table cellpadding=2 cellspacing=2 width=100%><tr>  </tr><tr><th bgcolor=#FFCC00  width=250px>id</th><td bgcolor=#FEE9A9>" . $row[0] . "</td></tr><tr><tr><tr><th bgcolor=#FFCC00>pass</th><td bgcolor=#FEE9A9>" . $row[2] . "</td></tr><tr><th bgcolor=#FFCC00>maxdownload</th><td bgcolor=#FEE9A9>" . $row[3] ."</td></tr><tr><th bgcolor=#FFCC00>remarks</th><td bgcolor=#FEE9A9>" . $row[4] . "</td></tr>";

though that doesn't look very pretty.

You could also escape out of PHP mode for the HTML, e.g.

<?php
if($foo) { ?>
<p>This is some HTML</p>
<p>This is a variable: <?php echo $var; ?>!</p>
<?php
}
?>

though I still think that looks like a soupy mess of HTML and PHP mixed together.

You can also just use a single echo statement and include the line breaks, e.g.

echo "This is a long echo statement.

You can include variables ($var) since the string is delimited by double quotes.

This is the end of the long echo statement.";

Other than that, I'm not sure what you're asking. Is there a magic loop_through_database_and_output_the_data_using_HTML_tables() function built into PHP to simplify your code? No. Even if there were, I sure hope it wouldn't output invalid HTML markup as you have used! :p

ugurpc

🙂

since sometimes i will change the database . and new database will have more coulumns from this one.

So i thought that maybe there can be automatic way displaying all data at the table of new database with just making the database connection.

i.e. my wish was similar to loop_through_database_and_output_the_data_using_HTML_tables() function
🙂
this could be with or without html tables..

anyway thanks for the solutions.
my last question is ;
the codes work now with

$page=$_GET['page'];

or using with

$page = (isset($_GET['page'])) ? (int)$_GET['page'] : 0;

which one is better to use and why please.?

after your answer i will close this as resolved thread...

Thanks for now

bradgrafelman

ugurpc wrote:
my wish was similar to loop_through_database_and_output_the_data_using_HTML_tables() function

If that's the case, then make your own function!

Break down your thought process that created all of those echo statements - how did you write that code? If you can break it down into steps, then all you've got to do is translate those steps into PHP code and wrap it around a function() statement. That way, you could simply perform a 'SELECT *' query and pass the resource returned from [man]mysql_query/man to your function, which could then dynamically output column headers and loop through all the rows.

ugurpc wrote:
which one is better to use and why please.?

The latter of the two. Why? You should never reference external data in your code without first verifying that it exists. Turn error_reporting up to E_ALL and you'll see that referencing an item in a $GET, $POST, etc. array that doesn't exist will generate an E_NOTICE level error message.

Plus, using the [man]isset/man (or [man]empty/man) statements in a compact statement like that (using the '?:' ternary operator/syntax) allows you to define a default value for a variable if it wasn't supplied by the user. For example, NogDog's code will give $page a default value of zero if it wasn't found in the $_GET array.

ugurpc

Thank you bradgrafelman for all of the info.
i will try to write my own function(), after i study more about functions

thx.

ugurpc

Hi again,
Although i clicked this as "resolved link" i need to learn that ;

this problem is solved for web.
But this pagination doesn't work at my localhost with the same codes.
same codes works on my demo page

pagination codes :

/* 
		Now we apply our rules and draw the pagination object. 
		We're actually saving the code to a variable in case we want to draw it more than once.
	*/
	$pagination = "";
	if($lastpage > 1)
	{	
		$pagination .= "<div class=\"pagination\">";
		//previous button
		if ($page > 1) 
			$pagination.= "<a href=\"$targetpage?page=$prev\">&#171; previous</a>";
		else
			$pagination.= "<span class=\"disabled\">&#171; previous</span>";	

	//pages	
	if ($lastpage < 7 + ($adjacents * 2))	//not enough pages to bother breaking it up
	{	
		for ($counter = 1; $counter <= $lastpage; $counter++)
		{
			if ($counter == $page)
				$pagination.= "<span class=\"current\">$counter</span>";
			else
				$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
		}
	}
	elseif($lastpage > 5 + ($adjacents * 2))	//enough pages to hide some
	{
		//close to beginning; only hide later pages
		if($page < 1 + ($adjacents * 2))		
		{
			for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//in middle; hide some front and some back
		elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//close to end; only hide early pages
		else
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
		}
	}

	//next button
	if ($page < $counter - 1) 
		$pagination.= "<a href=\"$targetpage?page=$next\">next &#187;</a>";
	else
		$pagination.= "<span class=\"disabled\">next &#187;</span>";
	$pagination.= "</div>\n";		
}

and pagination is shown by the code :

<?=$pagination?>

i am using xampp at localhost and php ver is 5.3

at localhost, data comes from database but pagination doesn't work.
why this pagination doesnt work at localhost?

in my php.ini file at localhost, display_errors are set to On and
error_reporting = E_ALL & ~E_NOTICE & ~E_DEPRECATED

But i can't get any error with this pagination at localhost

any comments?

bradgrafelman

Try getting rid of the "<?=$var;?>" short tag syntax, which has been deprecated and disabled by default for some time now (and even remove altogether in more recent versions of PHP).

In other words, any appearance of "<?" should be changed to "<?php", and "<?=$var;?>" should be "<?php echo $var; ?>" instead.

ugurpc

Thank you very much bradgrafelman
it worked. 🙂

finchkeeper

Hi, I know this is an old thread but I have 2 questions. question 1. is there a new version of this script in php5 or higher?
question 2. why have you used a variable when accessing the db?
you used

$query = "SELECT COUNT(*) as num FROM $tbl_name";

you should have used

$query = "SELECT COUNT(*) as num FROM users";

🙂