Count number of actions

[zzz]

I needed to limit a number certain action could be called, so I added a counter. The idea is once the limit is reached it would stop. For some reason I keep getting the count increased past 4. The code is below, am I missing anything?

if (
		(
	 		($type == 'a' && $_SESSION['key'] != '') ||
	 		($type == 'b' && $_SESSION['key'] != '') ||
	  		 $type == 'c'
		) && 
		$_SESSION['actnCnt'] < 4
	) {

// action here ...

$_SESSION['actnCnt'] ++;
}

[bradgrafelman]

Is there an 'else' condition for that if() statement? Also, where do you initialize $_SESSION['actnCnt'] ?

[zzz]

The first time it initialized after the action takes place. I've tried adding this before if statement:

if (!isset($_SESSION['actnCnt'])) {
     $_SESSION['actnCnt'] = 0;
}

But it did not seem to make a difference...

There is no else condition.

[bradgrafelman]

zzz;10952541 wrote:

The first time it initialized after the action takes place.

Can you show us the code that does that?

I can't see anything wrong with the minimal if() structure you've shown us above, so unless I'm missing something... I'm wondering if the problem isn't elsewhere.

How do you know the count goes above 4? Are you echo'ing the count each time and you actually see it echo out 4, 5, 6, etc. ?

[zzz]

The code resides ina function:

function recordActivity($db, $type) {

if (!isset($_SESSION['actnCnt'])) {
	$_SESSION['actnCnt'] = 0;
}

if (
	(
 		($type == 'a' && $_SESSION['key'] != '') ||
 		($type == 'b' && $_SESSION['key'] != '') ||
  		 $type == 'c'
	) && 
	$_SESSION['actnCnt'] < 4
	) {

	$db->query("INSERT INTO ... ");

	$_SESSION['actnCnt'] ++;
}
}

and I can see the count by doing :

echo 'SESSION"<pre>';
print_r($_SESSION);
echo '</pre>';

These simple things bug me the most...

[zzz]

extra SESSION" in bottom snippet ...