[RESOLVED] Statement returns true

MHovet

I have an 'if' statement that keeps returning true.

Help clue me into what I am doing wrong.

Here is the code

if( (strtoupper($clsORD->ShipToCountry) != 'USA') || (strtoupper($clsORD->ShipToCountry) != 'UNITED STATES') ){
	$useIntl = true;
	$shipmentType = "International";
}

Any help is appreciated.

dagon

you want && (and) not || (or)

MHovet

Thanks for the help, it works but I don't understand why it would not be ||. Because the ShipToCountry could be either one of them.

I also though that if you used && both conditions would have to be true.....

Or does it have to do with the !=

MHovet

MHovet;10952931 wrote:
Thanks for the help, it works but I don't understand why it would not be ||. Because the ShipToCountry could be either one of them.

I also though that if you used && both conditions would have to be true.....

Or does it have to do with the !=

Oh I get it, I just had to read the code from the beginning.

Thanks

dagon

in words,

NOT USA or UNITED STATES

true first statement, true 2nd statement
=international

IS USA

will evaluate as true for the first statement but false for the 2nd as both have to be true (&&) he result is false

with the ||

NOT USA or UNITED STATES
true first statement, true 2nd statement

=international

IS USA
false for the first statement but true for the 2nd, since either one can be true, it will be true =international (not what you want)

I dont know of this is any clearer😃

Weedpacket

Here's a similar test:

($me->age!=23 || $me->age!=57)

In English that would be "my age is not twenty-three or my age is not fifty-seven".

That statement is true if either of its parts is true (because they're joined by OR). If I'm 57 then I'm not 23. if I'm 23 then I'm not 57. And if I'm 4 then I'm neither. In all three cases the statement "my age is not twenty-three or my age is not fifty-seven" is true.

In short:

!(A && B)  ==>  (!A || !B)

If they're not both true then one of them must be false.

It goes the other way, too:

!(A || B)  ==>  (!A && !B)

If neither of them are true then they must both be false.