[RESOLVED] Trouble with for loop

robkir

I'm stuck. I want to read in a cvs comma delimited file into an array.

The data looks like this
1, 1,10
1, 2, 9
1, 3, 8
1, 4, 7
1, 5, 6

when I print the array out its first entry is 1,2,9 instead of 1,1,10. print_r verifies that 1,1,10 is there--so something must be wrong with my for loop (I also tried a while loop, same problem) but I'll be darn if I can figure out where the problem is.

Here's the code

$thisPass = 0;
if (($handle = fopen("10Teams.csv", "r")) !== FALSE) {
    while (($data = fgetcsv($handle, 1000, ",")) !== FALSE) {
        $num = count($data);

    for ($c=0; $c < $num; $c++) {

    //	print "value of this pass is $thisPass ";

    	if($thisPass ==0)
    		{$meetNum=$data[$c];
    		}	
    	if($thisPass ==1)
    		{
    		$teamA=$data[$c];
    		}

    	if($thisPass ==2)
    		{
    		$teamB=$data[$c];
    		$addToArray=1;
    		}

    	$thisPass++;
    	//print "add to array is $addToArray <br/>";
    	if($addToArray ==1)
    		{$match[$i]=array($meetNum, $teamA, $teamB);
    		$addToArray = 0;
    		$thisPass = 0; 	$i++;	
    		}
    }
}
fclose($handle);
}


print "print array <br/>" ; 
for($i=0; $i < 45; $i++) {
list($timeSlot,$teamA,$teamB) = $match[$i];
echo $timeSlot . " " . $teamA . " " . $teamB ."<br/>";

}

echo "print r routine <pre>";
print_r($match);
echo "</pre>";

thanks!
Bob

dagon

array index starts at 0 not 1, and i would use a foreach() in preference to a for()

NogDog

At a quick glance, I'm not sure why, but an equally quick solution might be to use a [man]foreach/man loop (instead of the for() loop), and not have to worry about getting the array indexes correct in the for() loop.

robkir

Hi Dagon,
Isn't the first index at 0? If I put in a print $i statement

for($i=0; $i < 45; $i++) {
print "value of i " .  $i;

It says 0.

I didn't use the foreach statement because I can't figure out how to get values into variables (yeah, I'm little slow, but I can't seem to get a clear explanation of how to do it).

thanks for you help.

Bob

bradgrafelman

Simple example of a foreach loop:

$data = array("Hello", "world");

foreach($data as $val) {
    echo "$val<br>\n";
    // $val will contain the data from each iteration through the array
}

/* output:
         Hello<br>
         World<br>
*/

dagon

my bad, i did not look closer enough

i would replace

{$match[$i]=array($meetNum, $teamA, $teamB); ...

with

{$match[]=array($meetNum, $teamA, $teamB); ...

php will take care of the array key for you.

and

print "print array <br/>" ;
for($i=0; $i < 45; $i++) {
list($timeSlot,$teamA,$teamB) = $match[$i];
echo $timeSlot . " " . $teamA . " " . $teamB ."<br/>";

}

with

print "print array <br/>" ;
foreach ($match as $m)

echo $m[0]. " " . $m[1] . " " . $m[2] ."<br/>";

}

I'm sure there's some more optermisation that could go on in there, but that's a start

robkir

Hi Dagon,
That works! Thanks.