RE: View images stored in MySQL database

jeankaleb

My domain name is www.jeankaleb.com And the code that allows you to store images into a MySQL database can be accessed via the following link: http://www.jeankaleb.com/store.php and to view the image... http://www.jeankaleb.com/getdata.php

However, I have copied and pasted your code as-is? But does not seem to work when I want to VIEW the image. As can be seen when you access the 1st link [store] a broken image link appears.

[I used the <img src="getdata.php?id=2">] as suggested.

the source code associated with the getdata.php is:

<?php

if($id)
 {
    mysql_connect("localhost","user","password") or die ("Could not connect"); 
    mysql_select_db("binary_data");

$query = "select bin_data,filetype from binary_data where id=$id";
$result = MYSQL_QUERY($query);

$data = @MYSQL_RESULT($result,0,"bin_data");
$type = @MYSQL_RESULT($result,0,"filetype");

Header( "Content-type: $type");
echo $data;
   };

?>

Your assistance would be extremely appreciated

Thanking you

Jean kaleb

damienmcd

OK first of all, it is quite bad practice to store the actual image to the DB. You should just store the images to a directory and then store a link to the image in the DB.

Give this a go as it will stop your DB from being overworked unnecessarily.

bradgrafelman

damienmcd is right - why not store the files on the file system?

Also, you reference the variable $id but never define it. Perhaps you meant $_GET['id'] instead? See this manual page for more information about how to use data from external sources (e.g. the query string): [man]variables.external[/man].

EDIT: Also note that user-supplied data should never be placed directly into a SQL query string else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, it must first be sanitized with a function such as [man]mysql_real_escape_string/man (for string data; for numeric data, cast the data to the appropriate type... e.g. for integers cast to (int) or use [man]intval/man).

Finally, when posting for help, you should always give us as much error/debugging information as possible. For example, seeing the following PHP error messages that your script is generating would have been beneficial:

Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/jkaleb/public_html/getdata.php on line 11 
 
Warning: mysql_result(): supplied argument is not a valid MySQL result resource in /home/jkaleb/public_html/getdata.php on line 12 
 
Warning: Cannot modify header information - headers already sent by (output started at /home/jkaleb/public_html/getdata.php:11) in /home/jkaleb/public_html/getdata.php on line 14

sana

Hello,

http://www.rapidshareindex.com/Lynda-com-PHP-with-MySQL-Beyond-the-Basics-DVD-Tutorial-_189772.html

Go through this video where it tells how to upload files and and handle them with

database.This video takes takes through the PHP and MySql concepts using a Photo

Gallery example.

Regards

Sana