[RESOLVED] preg_match and preg_replace

[asucrews]

for some reason, the matching for <flink><flink> is not working. any ideas on what happening?

<?php
function links($string){
	$pattern = "/<ilink ([0-9]+)>([^<]+)<ilink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='?pageid=$id' target='_top'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	$pattern = "/<elink ([0-9]+)>([^<]+)<elink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='links.php?link_name=$id' target='_blank'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	$pattern = "/<flink ([0-9]+)>([^<+])<flink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='links.php?link_name=$id' target='_blank'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	return $string;
}
?>

[asucrews]

after test the function for a while. it matching the ilink, and elink but not flink

i tested by change what string i a giving the function.

ilink = internal link
elink = external link
flink = forms link to

[asucrews]

more testing shows that just stoping after <ilink> pattern and not do any of others...any ideas on what happening.

Test Script

[zypher11]

function links($string){
    $pattern = "/<ilink ([0-9]+)>(.*?)<ilink>/";
    if(preg_match($pattern, $string, $matches)){
        $id = $matches['1'];
        $title = $matches['2'];
        $replacement = "<a href='?pageid=$id' target='_top'>$title</a>";
        $string = preg_replace($pattern, $replacement, $string, 1);
    }
    $pattern = "/<elink ([0-9]+)\>(.*?)<elink>/";
    if(preg_match($pattern, $string, $matches)){
        $id = $matches['1'];
        $title = $matches['2'];
        $replacement = "<a href='links.php?link_name=$id' target='_blank'>$title</a>";
        $string = preg_replace($pattern, $replacement, $string, 1);
    }
    $pattern = "/<flink ([0-9]+)\>(.*?)<flink>/";
    if(preg_match($pattern, $string, $matches)){
        $id = $matches['1'];
        $title = $matches['2'];
        $replacement = "<a href='links.php?link_name=$id' target='_blank'>$title</a>";
        $string = preg_replace($pattern, $replacement, $string, 1);
    }
	return $string;
}

[asucrews]

okay, i tried that and changing ilink and flink but skipping elink.

also the function will be scan whole page for these patterns so there might be one, two or more or even none, so is there something better the while for this?

[zypher11]

deleted

[zypher11]

Ok that was my bad, misread what you were trying to do. thought you only were replacing each once.

function links($string){
	$pattern = "/<ilink ([0-9]+)>(.*?)<ilink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='?pageid=$id' target='_top'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	$pattern = "/<elink ([0-9]+)\>(.*?)<elink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='links.php?link_name=$id' target='_blank'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	$pattern = "/<flink ([0-9]+)\>(.*?)<flink>/";
	while(preg_match($pattern, $string, $matches)){
		$id = $matches['1'];
		$title = $matches['2'];
		$replacement = "<a href='links.php?linkname=$id' target='_blank'>$title</a>";
		$string = preg_replace($pattern, $replacement, $string, 1);
	}
	return $string;
}

will work for you lol

[zypher11]

Of course if i wasn't so tired and paid attention i could have simply said something like:

"in the last while loop where it says $pattern = "/<flink ([0-9]+)>([^{<+])<flink>/";} it should be $pattern = "/<flink ([0-9]+)>([^{<]+)<flink>/";} (move the plus outside the brackets..."

lol... but problem solved regardless :p