[RESOLVED] Use of include several times

phprooky

Hi everyone,
I have a main page where I have to bring data from 3 different tables in my database and the way I'm doing it is by creating 3 different php pages where I connect to my database and select the data I want. Then in my main page all I do is this:

include('events/my_page1.php');
include('events/my_page2.php');
include('events/my_page3.php');

The data from my_page1 is showing pretty well on my main page, but not the others. I already check those pages and they are selecting the values well because I added an echo mysql_result and I can see the data, but not in my main page.
This is my_page2.php

$host=""; // Host name 
$username=""; // Mysql username 
$password=""; // Mysql password 
$db_name=""; // Database name 
$tbl_name=""; // Table name 
 //Connect to server and select databse.
$con=mysql_connect("$host", "$username", "$password"); 
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
$db_selected = mysql_select_db("$db_name", $con);
mysql_select_db("$db_name")or die("cannot select DB");

$sql= "select post from my_table2 order by id desc limit 1";
$result_s1=mysql_query($sql,$con);

$sql2= "select post1 from my_table2 order by id desc limit 1";
$result_s2=mysql_query($sql2,$con);

$sql3= "select post2 from my_table2 order by id desc limit 1";
$result_s3=mysql_query($sql3,$con);

$sql4= "select post3 from my_table2 order by id desc limit 1";
$result_s4=mysql_query($sql4,$con);
echo mysql_result($result_s1,0);
mysql_close($con);

Can you guys please help me?

bradgrafelman

Sounds like the first thing you need to do is optimize all of your SQL queries (probably down into only a couple of queries).

For example, in the code snippet above, you only echo the result from the first query, so why do you even execute the other three at all? If you did need their values, however, there's no reason to use four separate queries rather than just:

$sql= "select post, post1, post2, post3 from my_table2 order by id desc limit 1";

Then again, those numbered columns strongly suggest that your database isn't normalized. Creating a normalized DB schema is one of the first steps in designing an application's data structure - it's something you should do before you even write a single line of code, IMHO.

phprooky

Hi brad and thanks for your quick reply,
If I change my select the way you suggest, how can I display each value? For example: I need to display post, post1, post2, etc. in a different place in my main page using echo.
Can you help me on that?
Thanks in advance!!

bradgrafelman

With your current DB structure, you could use [man]mysql_fetch_assoc/man to retrieve the row (since you only want the first row) as an associative array where the column names are used as indexes in the array.

phprooky

Hi again brad,
The example that I saw here http://www.php.net/mysql_fetch_assoc says that if you want only one row then you don't need to use a loop the way they are explaining, so how can I bring only the row I want with those 4 columns of data and display them using echo?
For example: if I make the following select as you suggested:
$sql= "select post, post1, post2, post3 from my_table2 order by id desc limit 1";
How can I display post, post1, post2 and post3 using echo?
Do I have to do something like this:
echo mysql_result($sql,post);
echo mysql_result($sql,post1);
echo mysql_result($sql,post2);
echo mysql_result($sql,post3);

bradgrafelman

phprooky wrote:
if you want only one row then you don't need to use a loop the way they are explaining, so how can I bring only the row I want with those 4 columns of data and display them using echo?

By not using a loop. 🙂 Just call the [man]mysql_fetch_assoc/man function once rather than in a loop.

phprooky wrote:
How can I display post, post1, post2 and post3 using echo?
Do I have to do something like this:

Well no, since the manual page for [man]mysql_result/man states that the second parameter should be an integer.

Besides, like I said, it'd be easier to simply call [man]mysql_fetch_assoc/man once.

$row = mysql_fetch_assoc($exec);
echo "Post: " . $row['post'] . "<br>Post1: " . $row['post1'] . " ... etc.";

phprooky

Ohhh, I get it now!!
Yep, it is working now just like you suggested.
Thanks a lot for your help Brad!!!