upload file

kclark

I can't get my file to upload. Other than that, my script works fine.

<?php
$db = JFactory::getDBO();

$form=$_POST['urnform'];//figuring out which form is submitted

$urnid=$_POST['urnid'];//getting case #

$urncompany=$_POST['urncompany'];

if($urncompany == "1")
$urncompanyname = "batesvilleurns";//Batesville
elseif($urncompany == "3")
$urncompanyname = "batesvilleurns";//Batesville with 300 X 235 pic size
elseif($urncompany == "4")
$urncompanyname = "auroraurns";//Aurora
elseif($urncompany == "6")
$urncompanyname = "churchchapel";//Church & Chapel
elseif($urncompany == "7")
$urncompanyname = "crescent";//Crescent
elseif($urncompany == "2")
$urncompanyname = "infinityurns";//Kelco
elseif($urncompany == "8")
$urncompanyname = "madelyn";//Madelyn
else
$urncompanyname = "matthewsurns";//Matthews

//if($casketcompany2 == "1")
//$prefix = "a";//Aurora
//else
$prefix = "";//the rest


if($form == "Delete Urn")
echo "";
else
{
$HTTP_POST_FILES['userfile']['tmp_name'];
$HTTP_POST_FILES['userfile']['name'];
$HTTP_POST_FILES['userfile']['size'];
$HTTP_POST_FILES['userfile']['type'];

if($userfile == "none")
{
  echo "Problem: no file uploaded";
  exit;
}

if($userfile_size=="0")
{
  echo "Problem: uploaded file is zero length";
  exit;
}

//if($userfile_type != "text/plain")
//{
//  echo "Problem: file is not plain text";
//  exit;
//}

//if(!is_uploaded_file($userfile))
//{
//  echo "Problem: possible file upload attack";
//  exit;
//}

$upfile="images/$urncompany/$urnid.jpg";

//if(!copy($userfile,$upfile))
//{
//  echo "Problem: Could not move file into directory";
//  exit;
//}

copy($userfile,$upfile);

//echo "File uploaded successfully<br><br>";
//$fp=fopen($upfile, "r");
//$contents=fread($fp,filesize($upfile));
//fclose($fp);

//$contents=strip_tags($contents);
//$fp=fopen($upfile,"w");
//fwrite($fp,$contents);
//fclose($fp);

}


$photo="images/$urncompanyname/$prefix$urnid.jpg";

//update record
if($form == "Edit Urn")
$query ="UPDATE urns SET urnid='$urnid', material='$_POST[material]', picture='$photo', name='$_POST[name]', 
 price='$_POST[price]', feature1='$_POST[feature1]', feature2='$_POST[feature2]', materialid='$_POST[materialid]', 
 dimensions='$_POST[dimensions]', urncompany='$urncompany', capacity='$_POST[capacity]', series='$_POST[series]', 
 active='$_POST[active]' where urnid = '$urnid'";
//line 70
//Delete Record
elseif($form == "Delete Urn")
$query = "DELETE from urns where urnid = '$urnid'";
//insert record
elseif($form == "Add Urn")
$query ="INSERT INTO urns (urnid, material, picture, name, price, feature1, feature2, materialid, 
dimensions, urncompany, capacity, series, active)
VALUES
('$urnid','$_POST[material]','$photo','$_POST[name]','$_POST[price]',
'$_POST[feature1]','$_POST[feature2]','$_POST[materialid]','$_POST[dimensions]','$urncompany','$_POST[capacity]',
'$_POST[series]','$_POST[active]')";
else
print "no form entered";

$result = mysql_query($query)
	or	die("Couldn't execute sql.");

if($form == "Edit Urn")
echo "<center>The <b><u>$_POST[name]</b></u> record has been updated.</center>";

elseif($form == "Delete Urn")
echo "<center>The <b><u>$_POST[name]</b></u> record has been deleted.</center>";

elseif($form == "Add Urn")
echo "<center>A record for <b><u>$_POST[name]</b></u> has been added. $_POST[userfile_name]</center>";

else
echo "Ain't Nuthin Happn'in";
?>

bradgrafelman

Several issues:

```
$form=$_POST['urnform'];//figuring out which form is submitted 

$urnid=$_POST['urnid'];//getting case # 

$urncompany=$_POST['urncompany']; 
```
If any of these external variables don't exist, you'll generate E_NOTICE level errors by trying to access them. It's better to test that external data exists (e.g. using [man]isset/man or [man]empty/man) first.

if($urncompany == "1") 
$urncompanyname = "batesvilleurns";//Batesville 
elseif($urncompany == "3") 
$urncompanyname = "batesvilleurns";//Batesville with 300 X 235 pic size 
elseif($urncompany == "4") 
$urncompanyname = "auroraurns";//Aurora 
elseif($urncompany == "6") 
$urncompanyname = "churchchapel";//Church & Chapel 
elseif($urncompany == "7") 
$urncompanyname = "crescent";//Crescent 
elseif($urncompany == "2") 
$urncompanyname = "infinityurns";//Kelco 
elseif($urncompany == "8") 
$urncompanyname = "madelyn";//Madelyn 
else 
$urncompanyname = "matthewsurns";//Matthews

Looks like this is information that you should be storing in some sort of a database (either a DBMS such as MySQL or even a structured flat-file database that you manage yourself).

$HTTP_POST_FILES most likely doesn't exist. These $HTTP types of variables have long ago been deprecated and disabled by default. Instead, you should be using one of the variables found on this manual page: [man]reserved.variables[/man] (for example, $FILES should seem appropriate for this situation).

These lines of code:

$HTTP_POST_FILES['userfile']['tmp_name']; 
$HTTP_POST_FILES['userfile']['name']; 
$HTTP_POST_FILES['userfile']['size']; 
$HTTP_POST_FILES['userfile']['type'];

do absolutely nothing. Not sure what you were expecting them to do?

```
if($userfile == "none")
```
$userfile (and many others after it) is never defined.
```
copy($userfile,$upfile); 
```
Not only is $userfile an undefined variable, but if you're attempting to move the uploaded file here then you should be using [man]move_uploaded_file/man instead.
You should never place user-supplied data directly into a SQL query string else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize it with a function such as [man]mysql_real_escape_string/man (for string data).

kclark

I have changed the upload part as stated below. It works great. How can I add to it to resize the image to 169px tall and 133px wide?

if ($_FILES['file']['error'] > 0)
    {
    echo "Return Code: " . $_FILES['file']['error'] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES['file']['name'] . "<br />";
    echo "Type: " . $_FILES['file']['type'] . "<br />";
    echo "Size: " . ($_FILES['file']['size'] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES['file']['tmp_name'] . "<br />";

if (file_exists("images/" . $_FILES['file']['name']))
  {
  echo $_FILES['file']['name'] . " already exists. ";
  }
else
  {
  move_uploaded_file($_FILES['file']['tmp_name'],
  "images/$companyname/$materialdir/$prefix$casketnumber.jpg");      
//"images/" . $companyname . "/" . $materialdir/$prefix$casketnumber . ".jpg");
      //"images/" . $_FILES['file']['name']);//change to Timp folder
      // "C:/upload/" . $_FILES['file']['name']);//change to Timp folder
      //echo "Stored in: " . "C:/xampp/htdocs/Timp/UserLogin/upload/" . $_FILES["file"]["name"];
       echo "Stored in: images/$companyname/$materialdir/$prefix$casketnumber.jpg";
      }
    }

bradgrafelman

kclark wrote:
How can I add to it to resize the image to 169px tall and 133px wide?

One way would be to use the [man]GD[/man] library. For an example, see the manual page for [man]imagecopyresampled/man (specifically, take a look at "Example #2 Resampling an image proportionally").

kclark

I added the following based upon your recommendation of Example #2. My image is getting uploaded, but it is not getting resized. Is there a way to resize it as it is being uploaded? I have listed all of my code that relates to my photo upload.

$pictureupload=$_POST['pictureuploaded'];//figuring out if picture has been uploaded

if($pictureupload == "Yes")
 $Picture="Obit Pics/$ID.jpg"; 
elseif($pictureupload == "Flag")
 $Picture="Obit Pics/veteran.jpg"; 
else
 $Picture="";
//$Photo="$Picture"

//*******************
$fileName = $_FILES['file']['name'];
$tmpName  = $_FILES['file']['tmp_name'];
$fileSize = $_FILES['file']['size'];
$fileType = $_FILES['file']['type'];

if($pictureupload == "Yes")
{
// The file
//$filename = $filename;

// Set a maximum height and width
$width = 133;
$height = 169;

// Content type
header('Content-type: image/jpeg');

// Get new dimensions
list($width_orig, $height_orig) = getimagesize($filename);

$ratio_orig = $width_orig/$height_orig;

if ($width/$height > $ratio_orig) {
   $width = $height*$ratio_orig;
} else {
   $height = $width/$ratio_orig;
}

// Resample
$image_p = imagecreatetruecolor($width, $height);
$image = imagecreatefromjpeg($filename);
imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

// Output
imagejpeg($image_p, null, 100);
}
//*******************
if($form == "Delete Record")
echo "";
else
{
if ($_FILES['file']['error'] > 0)
    {
    echo "Return Code: " . $_FILES['file']['error'] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES['file']['name'] . "<br />";
    echo "Type: " . $_FILES['file']['type'] . "<br />";
    echo "Size: " . ($_FILES['file']['size'] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES['file']['tmp_name'] . "<br />";

if (file_exists("Obit Pics/$ID.jpg"))
  {
  echo "Obit Pics/$ID.jpg already exists.";
  }
else
  {
  move_uploaded_file($_FILES['file']['tmp_name'],
  "Obit Pics/$ID.jpg");      
  //"images/" . $_FILES['file']['name']);//change to Timp folder
  // "C:/upload/" . $_FILES['file']['name']);//change to Timp folder
  //echo "Stored in: " . "C:/xampp/htdocs/Timp/UserLogin/upload/" . $_FILES["file"]["name"];
   echo "Stored in: Obit Pics/$ID.jpg";
  }
} 
}

PHPology

Try this function, altho it is a quick thing I mocked up but does the job.
If you want to resize PNG's add that in to but beware that when assigning quality for PNG's its between 1-9 top of my head.

function params as title belowed. Hope this helps.

function resize_image($width, $height, $quality = 90, $filename, $filename_resized)
	{
		//get file extension
		$i = strrpos($this->Filename,".");
		if (!$i) {
			return "";
		}
		$l = strlen($this->Filename) - $i;
		$ext = substr($this->Filename, $i+1, $l);
		$ext = strtolower($ext);
		//end file extension

	$size = getimagesize($filename);
$ratio = $size[0] / $size[1];
 if ($ratio >= 1){
      $scale = $width / $size[0];
 } else {
      $scale = $height / $size[1];
 }
// make sure its not smaller to begin with!
 if ($width >= $size[0] && $height >= $size[1]){
      $scale = 1;
 }

	// echo $fileext;
	if($ext == "jpg")
	{
		$im_in = imagecreatefromjpeg($filename);
		$im_out = imagecreatetruecolor($size[0] * $scale, $size[1] * $scale);
		imagecopyresampled($im_out, $im_in, 0, 0, 0, 0, $size[0] * $scale, $size[1] * $scale, $size[0], $size[1]);
		imagejpeg($im_out, $filename_resized, $quality);
	}
	elseif($ext == "gif")
	{
		$im_in = imagecreatefromgif($filename);
		$im_out = imagecreatetruecolor($size[0] * $scale, $size[1] * $scale);
		imagecopyresampled($im_out, $im_in, 0, 0, 0, 0, $size[0] * $scale, $size[1] * $scale, $size[0], $size[1]);
		imagegif($im_out, $filename_resized, $quality);
	}
	imagedestroy($im_out);
	imagedestroy($im_in);
}

kclark

will your code just resize or upload and resize?

bradgrafelman

kclark wrote:
will your code just resize or upload and resize?

Read through it and find out! 🙂

However, there are a couple of issues with that function that you'll have to fix before you can use it:

The function assumes that you're using it in an OOP context (hence the appearance of $this). Since you aren't, you'll have to make some modifications.
The function erroneously assumes that the text after the first period is considered the file extension; it's actually supposed to be the text after the last period in the file name.
With this code:
```
    // make sure its not smaller to begin with! 
     if ($width >= $size[0] && $height >= $size[1]){ 
          $scale = 1; 
     } 
```
it sets the scale factor to one, since the image already fits within the restrictions. I would think that a much better route to take would be to bypass the image processing altogether and simply stop at that point.

EDIT: Also forgot to mention... the function also erroneously assumes that JPEG files can only consist of the "jpg" extension (hint: add a period before the image type and you've got a second possibility :p, though there are still 4 others...).

kclark

Sorry I am just not getting it. Over a week later and still no luck.

kclark

Ok,
I have the following code that correctly uploads file to the correct directory and names it exactly as I want it to. But I am not getting it resized properly or maybe I was thinking differently about resizing. I am currently cropping pictures in a photo editing program down to 169 X 133 px. An 8 X 10 photo cropped to the section that I would like using the ratio of 169 X 133px may be 1352 X 1064 px but I will RESIZE the cropped image it in the program from 1352 X 1064 px down to 169 X 133px so that it will load much quicker and it will display correctly. So I may have a misunderstanding on what resizing code does. After doing a few uploads with the resizing code, my files are much larger than the files that I have done the old way that I was doing it. So I assume that my image files are not actually getting resized down to what I specify in my code. But anyway that is my long question and my code that I have working so far is below.

// file needs to be jpg,gif,bmp,x-png and 4 MB max
	if (($_FILES["file"]["type"] == "image/jpeg" || $_FILES["file"]["type"] == "image/pjpeg" || $_FILES["file"]["type"] == "image/gif" || $_FILES["file"]["type"] == "image/x-png") && ($_FILES["file"]["size"] < 4000000))
	{


	// some settings
	$max_upload_width = 133;
	$max_upload_height = 169;

	// if user chosed properly then scale down the image according to user preferances
	if(isset($_REQUEST['max_width_box']) and $_REQUEST['max_width_box']!='' and $_REQUEST['max_width_box']<=$max_upload_width){
		$max_upload_width = $_REQUEST['max_width_box'];
	}    
	if(isset($_REQUEST['max_height_box']) and $_REQUEST['max_height_box']!='' and $_REQUEST['max_height_box']<=$max_upload_height){
		$max_upload_height = $_REQUEST['max_height_box'];
	}	


	// if uploaded image was JPG/JPEG
	if($_FILES["file"]["type"] == "image/jpeg" || $_FILES["file"]["type"] == "image/pjpeg"){	
		$image_source = imagecreatefromjpeg($_FILES["file"]["tmp_name"]);
	}		
	// if uploaded image was GIF
	if($_FILES["file"]["type"] == "image/gif"){	
		$image_source = imagecreatefromgif($_FILES["file"]["tmp_name"]);
	}	
	// BMP doesn't seem to be supported so remove it form above image type test (reject bmps)	
	// if uploaded image was BMP
	if($_FILES["file"]["type"] == "image/bmp"){	
		$image_source = imagecreatefromwbmp($_FILES["file"]["tmp_name"]);
	}			
	// if uploaded image was PNG
	if($_FILES["file"]["type"] == "image/x-png"){
		$image_source = imagecreatefrompng($_FILES["file"]["tmp_name"]);
	}


	$remote_file = "Pics/$ID.jpg";
	imagejpeg($image_source,$remote_file,100);
	chmod($remote_file,0644);



	// get width and height of original image
	list($image_width, $image_height) = getimagesize($remote_file);

	if($image_width>$max_upload_width || $image_height >$max_upload_height){
		$proportions = $image_width/$image_height;

		if($image_width>$image_height){
			$new_width = $max_upload_width;
			$new_height = round($max_upload_width/$proportions);
		}		
		else{
			$new_height = $max_upload_height;
			$new_width = round($max_upload_height*$proportions);
		}		


		$new_image = imagecreatetruecolor($new_width , $new_height);
		$image_source = imagecreatefromjpeg($remote_file);

		imagecopyresampled($new_image, $image_source, 0, 0, 0, 0, $new_width, $new_height, $image_width, $image_height);
		imagejpeg($new_image,$remote_file,100);

		imagedestroy($new_image);
	}

	imagedestroy($image_source);

   }