[RESOLVED] Foreach loop with (multidimensional?) array

Major_Disaster

Hello - i would really appreciate some help with this. I think its quite a simple issue and i can see why its not working - just dont know how to fix it!

I have a stock search form. The top half of which, users enter their contact details and the bottom half are the stock results. The user searches for a product, enters their details, checks the products they want and enters the corresponding quantities. They then hit send and it will be mailed away.

I have some basic error checking on each field, for example:

		// Check to make sure that the First Name field is not empty, and that it does not contain badwords or exploits
		if(trim($_POST['first-name']) == '' ) {
			$error['first-name'] = "You didn't enter your <b>First Name</b>.";
		} else if (preg_match($badwords, trim($_POST['first-name'])) !== 0 || preg_match($exploits, trim($_POST['first-name'])) !== 0) {
			$error['first-name'] = "You entered a <b>First Name</b> which contains unacceptable or explicit words.";
		} else {
			$first_name = trim(filter_var($_POST['first-name'], FILTER_SANITIZE_STRING, FILTER_FLAG_NO_ENCODE_QUOTES));
			unset($error['first-name']);
		}

If there are any errors they are then displayed:

		// If there are any errors
		if(isset($error)) { 
			echo '<h1>Your Message Has Not Been Sent</h1>';
			echo '<p>Unfortunately your message was <b>not</b> sent as the following errors were detected:</p>';
			echo '<ul>';

		foreach($error as $errorViolation){
			echo '<li> '.$errorViolation.' </li>';
		}

		echo '</ul>';
		echo '<p>Please <a href="javascript:history.go(-1)">go back and correct these errors.</a></p>';
		exit();
	}

My problem is, i am trying to ensure that for each product checked a corresponding quantity is also entered. I have:

		// Foreach of the parts selected (the id array), select the value corresponding to each key
		foreach($_POST['id'] as $key=>$value){

		$quantity_value = $_POST['quantity'][$key];

		if(trim($quantity_value) == '') {
			$error['quantity'] = 'You didn\'t enter a <b>Quantity</b> for ' . $_POST['part-number'][$key];
		} elseif(preg_match($badwords, trim($quantity_value)) !== 0 || preg_match($exploits, trim($quantity_value)) !== 0) {
			$error['quantity'] = 'You entered a <b>Quantity</b> which contains unacceptable or explicit words for ' . $_POST['part-number'][$key];
		} else {
			$quantity_value = trim(filter_var($_POST['company-name'], FILTER_SANITIZE_STRING, FILTER_FLAG_NO_ENCODE_QUOTES));
			unset($error['quantity']);
		}

	}

Which kinda works, but as you can probably see each for multiple parts (with multiple quantites missing), the foreach loops through and overwrites any previous error - meaning i am only left with one error message - when there should be one for each missing part. I want to write something like:

$error['quantity'][$key] = 'You didn\'t enter a <b>Quantity</b> for ' . $_POST['part-number'][$key];

But that breaks the errors while loop (the error just displays Array). Sorry i was rather long winded in my explanation. Any help would be greatly appreciated

Cheers

bradgrafelman

When you're looping through the errors, first check if the value is an array or not using [man]is_array/man. If it is, nest another foreach() loop inside there to output all of the "sub-errors" within that error.

Major_Disaster

Brilliant. Absolutely perfect. Thanks

		// If there are any errors
		if(isset($error)) { 
			echo '<h1>Your Message Has Not Been Sent</h1>';
			echo '<p>Unfortunately your message was <b>not</b> sent as the following errors were detected:</p>';
			echo '<ul>';

		foreach($error as $errorViolation){

			if(is_array($errorViolation)){
				foreach($errorViolation as $errorArray){
				echo '<li> '.$errorArray.' </li>';
				}
			} else {
			echo '<li> '.$errorViolation.' </li>';
			}
		}

		echo '</ul>';
		echo '<p>Please <a href="javascript:history.go(-1)">go back and correct these errors.</a></p>';
		exit();
	}

(Right?) Im slightly worried that it took me longer to type the question that produce my solution!

bradgrafelman

Try it out and see, but it looks right.

Major_Disaster

Yep it works! Oh, one final question.

I thought it would be good to write something along the lines of:

[pre]

You didn't enter a Quantity for item number 1 - part number xyz.

[/pre]

Just by pulling the ID from the id array. However, since the array begins at id[0] it doesn't look right with "item number 0", so i am simply trying to add one on, but can't get the syntax right, any ideas:

$error['quantity'][$key] = 'You didn\'t enter a <b>Quantity</b> for item number ' . $_POST['id'][$key] + 1. ' - part number <b>' . $_POST['part-number'][$key] .'</b>.';

Thanks again

bradgrafelman

With no space between the period and the number one, PHP doesn't realize you're trying to use concatenation rather than the floating-point number "1."

Major_Disaster

Hmm, just get:

[pre]1 - part number xyz[/pre]

(Using:

				$error['quantity'][$key] = 'You didn\'t enter a <b>Quantity</b> for item number ' . $_POST['id'][$key] + 1 . ' - part number <b>' . $_POST['part-number'][$key] .'</b>.';

bradgrafelman

Try surrounding the numeric expression with parenthesis (). If that doesn't work, post a new copy of that line.

Major_Disaster

Hey,

Thanks for the continued support but its still not working. Tried parenthesis and got the same as before. Tried:

$error['quantity'][$key] = 'You didn\'t enter a <b>Quantity</b> for item number ' . $_POST['id'][$key + 1] . ' - part number <b>' . $_POST['part-number'][$key] .'</b>.';

Which only works for the first parts, not the last (im guessing becuase it becomes empty?)

Could you please clarify what you mean by "post a new copy of that line"

Cheers

EDIT:

				$value = $_POST['id'][$key] + 1;
				$error['quantity'][$key] = 'You didn\'t enter a <b>Quantity</b> for item number ' . $value . ' - part number <b>' . $_POST['part-number'][$key] .'</b>.';

Works. Odd.

bradgrafelman

This:

$_POST['id'][$key + 1]

is wrong, because here you're accessing a different key in the array entirely.

Simply adding the parenthesis should've worked:

. ($_POST['id'][$key] + 1) .

Major_Disaster

Yep that works.

I was doing:

. $_POST['id'][$key] + (1) .

Whoops! Thanks again for all the help. Im really impressed with this forum.

Cheers for the support