Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource

[pat0000]

Hello everyone!

I have installed a file Upload manager but on the login page I get this error:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /hermes/bosweb/web149/b1499/glo.tavcom/UserFiles/includes/functions.php on line 122

I have attached the "functions.php" file

Please help, Thank you in advance

[pat0000]

Or this is the code:

<?php
function getUser($userID){
		$sqll="SELECT id,username FROM users WHERE id='".$userID."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=$row11["username"]; 
		return $processor;
}
function getExtensions(){
		$processor = array();
		$sqll="SELECT * FROM extensions ORDER BY name ASC";
		$result1=mysql_query($sqll);
		while($row11=mysql_fetch_assoc($result1)){
		$processor[]=$row11["name"]; 
		}
		return $processor;
}

function getCommentCount($fileID){
		$sqll="SELECT COUNT(id) as countme FROM messages WHERE fileID='".$fileID."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		return $row11["countme"];
}

function getUploadDir($user){
		$sqll="SELECT id,upload_dir FROM users WHERE id='".$user."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		return $row11["upload_dir"];
}

function send_mail($subject="Notification",$message="") {
			$upload_notify_email = getSystemMail();
			$from = 'AdvancedFileManager@'.$_SERVER['HTTP_HOST'];
			$return_path = '-f '.$from ;
			mail($upload_notify_email,$subject,$message,"From: $from\nX-Mailer: PHP/ . $phpversion()");
}
function get_gravatar($email, $size = "80"){  

return '<img src="http://www.gravatar.com/avatar/'.md5($email).'?s=80&d='.urlencode(default_avatar).'" width="'.$size.'px" height="'.$size.'px" />'; } 

//GET SYSTEM EMAIL TO SEND NOTICE TO
function getSystemMail(){
		$sqll="SELECT notify_email FROM settings WHERE id='1'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=$row11["notify_email"]; 
		return $processor;
}
//TO SEND OR NOT TO SEND. THAT IS THE QUESTION.
function sendNotice($type){
	    $sqll="SELECT ".$type." FROM settings WHERE id='1'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=$row11[$type]; 
		if($processor=="1"){ return true; } else { return false;} 
}

function sendNoticeMsg($fileID){
	//get user from file 
	//send email to user and admin.
	$tempUID = getFileInfo($fileID);
	$userID=$tempUID[3];
	$userInfo = getUserInfo($userID);

/*mail(getSystemMail(),"New message for file ".getFileTitle($fileID)."!", getUser($_SESSION["idUser"])." added message for file ".getFileTitle($fileID),"From: $from\nX-Mailer: PHP/ . $phpversion()"); 
mail($userInfo[1],"New message for file ".getFileTitle($fileID)."!", getUser($_SESSION["idUser"])." added message for file ".getFileTitle($fileID),"From: $from\nX-Mailer: PHP/ . $phpversion()");*/
mail(getSystemMail(),"New message for file ".getFileTitle($fileID)."!", getUser($_SESSION["idUser"])." added message for file ".getFileTitle($fileID),"MIME-Version: 1.0\n Content-type: text/html; charset=utf-8\n From: 'AdvancedFileManager' <noreply@".$_SERVER['HTTP_HOST']."> \n");
mail($userInfo[1],"New message for file ".getFileTitle($fileID)."!", getUser($_SESSION["idUser"])." added message for file ".getFileTitle($fileID),"MIME-Version: 1.0\n Content-type: text/html; charset=utf-8\n From: 'AdvancedFileManager' <noreply@".$_SERVER['HTTP_HOST']."> \n");
}
//GET USER EMAIL / NAME BY USER ID
function getUserInfo($userID){
		$sqll="SELECT id,username,email FROM users WHERE id='".$userID."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=array();
		$processor[0]=$row11["username"]; 
		$processor[1]=$row11["email"]; 
		return $processor;
}

//GET FILE INFO BY FILE ID
function getFileInfo($id){
		$sqll="SELECT * FROM files WHERE id='".$id."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=array();
		$processor[0]=$row11["title"]; 
		$processor[1]=$row11["extension"]; 
		$processor[2]=$row11["path"]; 
		$processor[3]=$row11["userID"];
		return $processor;
}
//GET FILE INFO BY FILE ID
function getFileTitle($id){
		$sqll="SELECT * FROM files WHERE id='".$id."'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		$processor=$row11["title"]; 
		return $processor;
}


function getReg(){
		$txt=false;
		$sqll="SELECT allow_registrations FROM settings WHERE id='1'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		if($row11["allow_registrations"]=="1"){ $txt = true; }
		return $txt;
}

function autoApprove(){
		$txt=false;
		$sqll="SELECT auto_approve FROM settings WHERE id='1'";
		$result1=mysql_query($sqll);
		$row11=mysql_fetch_assoc($result1);
		if($row11["auto_approve"]=="1"){ $txt = true; }
		return $txt;
}

// ACTIVITY LOG FUNCTION
function addLog($user,$action){

$sSQL="INSERT INTO activitylogs (date,userID,description) VALUES (NOW(),'".$user."','".$action."')"; 
		$result = mysql_query($sSQL) or die("Invalid query: " . mysql_error() . "$sSQL");
		$actID = mysql_insert_id();
}

//FILE UPLOADER 
function uploadFile($inputFile, $sFolderPictures)
{ 
                $image_path=$inputFile['tmp_name'];
                $photoFileNametmp = $inputFile['name'];
                $fileNamePartstmp = explode(".", $photoFileNametmp);
                $fileExtensiontmp = strtolower(end($fileNamePartstmp)); // part behind last dot
               // $arrAllow=array("jpeg", "jpg", "png", "gif");//, "BMP", "TIFF"
	//	if (!in_array($fileExtensiontmp, $arrAllow)) { 
		//	$err.= "Picture's extension should be .jpg, .jpeg, .png, or .gif<br />";
	//	}
                if($inputFile['size']>20971520)
                {
                                $ssize=sprintf("%01.2f", $inputFile['size']/1048576);
                                $err= "Your file is ".$ssize.". Max file size is 20 MB.";
                }              

                if(!isset($err))
                {                                                                              

                                $newFile=$_SERVER['DOCUMENT_ROOT'].$sFolderPictures;//print $newFile;
                                $ret=move_uploaded_file($inputFile['tmp_name'],$newFile);
                                if(!$ret)
                                {?>
                                                Upload failed. No file recieved    <?php                           }
                                else
                                {
                                                $imgPath=$sFolderPictures;
                                }
                }
                else 
                { 
                                                ?>Upload failed. No file recieved
<?php  }
                if(file_exists($inputFile['tmp_name']))
                {
                                @unlink($inputFile['tmp_name']);
                }
                return $imgPath;
}        


function randomPassword(
$length=8, //string length
$uselower=1, //use lowercase letters
$useupper=1, // use uppercase letters
$usespecial=0, //use special characters
$usenumbers=1, //use numbers
$prefix=''
)
{
    $key = $prefix;
// Seed random number generator
    srand((double)microtime() * rand(1000000, 9999999));
    $charset = "";
    if ($uselower == 1) $charset .= "abcdefghijkmnopqrstuvwxyz";
    if ($useupper == 1) $charset .= "ABCDEFGHIJKLMNPQRSTUVWXYZ";
    if ($usenumbers == 1) $charset .= "0123456789";
    if ($usespecial == 1) $charset .= "~#$%^*()_+-={}|][";
    while ($length > 0) {
        $key .= $charset[rand(0, strlen($charset)-1)];
        $length--;
    }
    return $key;
}
?>

[NogDog]

99.9% of the time that means your mysql_query() failed, but you have no error-checking to see if it returned false (and find out what's wrong).

[pat0000]

Thank you NogDog. I mean everything seems to be working fine, except I get this message where a "New User" PHP script is..

In other words, I think something on this code is causing it:

<a href="forgot_password.php">Forgot password?</a> &nbsp;&nbsp;

	<?php
	$allow_reg = getReg();
	if($allow_reg){
    ?>
   <a href="user_registration.php">New User</a>
    <?php } ?>

[NogDog]

If you look at the getReg() function...

function getReg(){
        $txt=false;
        $sqll="SELECT allow_registrations FROM settings WHERE id='1'";
        $result1=mysql_query($sqll);
        $row11=mysql_fetch_assoc($result1);
        if($row11["allow_registrations"]=="1"){ $txt = true; }
        return $txt;
}

The code just assumes that the mysql_query() works, but apparently it is not. In order to trap the error, you could change it to something like:

function getReg(){
        $txt=false;
        $sqll="SELECT allow_registrations FROM settings WHERE id='1'";
        $result1=mysql_query($sqll);
        if($result == false) {
            user_error(mysql_error() . "<br />\n$sqll");
            return false;
        }
        $row11=mysql_fetch_assoc($result1);
        if($row11["allow_registrations"]=="1"){ $txt = true; }
        return $txt;
}

The code that calls that function would then need to check to see if it returned false, and if so, output an appropriate user-friendly error. Based on your display_error settings, the function will either display the debug information as an error message, or log it to your PHP error log (preferred for production version).

[pat0000]

I really appreciate your help! Thank you for taking the time to review my files.

I have changed the code as you told me, and now I get a different error:

SELECT allow_registrations FROM settings WHERE id='1' in /hermes/bosweb/web149/b1499/glo.tavcom/UserFiles/includes/functions.php on line 109

[bradgrafelman]

There probably isn't an error; note that NogDog had a typo in his code snippet here:

        $result1=mysql_query($sqll); 
        if($result == false) { 

(notice the two similar-but-different variable names used there).

[pat0000]

Thanks both for your help.. I'm sorry, let me clarify what the error is...

There is a login page at my site,

http://tavcomstudio.com/UserFiles/

and where I am getting the error is supposed to say Create a new account... but instead a get this error:

SELECT allow_registrations FROM settings WHERE id='1' in

[bradgrafelman]

There is no error. Read my post above.

[shamly]

I don't see mysql_connect anywhere in the code.

Also after

$result1=mysql_query($sqll); 

you can check for the number of returned rows using mysql_num_rows.