[RESOLVED] Sending Email with PHP code

[elearnindia]

I am trying to send plain/text email to gmail using the following PHP code:

<?php
if(isset($_POST['email'])) {

   // EDIT THE 2 LINES BELOW AS REQUIRED
  $email_to = "[e-mail]";
  $email_subject = "Sree Vizag Marketing-Tiles Enquiry";


  $first_name = $_POST['name']; // required
  $email_from = $_POST['email']; // required
  $phone = $_POST['phone']; // not required
  $comments = $_POST['comments']; // required


  $email_message .= "First Name: ".$first_name."\n\n";
  $email_message .= "Email: ".$email_from."\n\n";
  $email_message .= "Telephone: ".$phone."\n\n";
  $email_message .= "Comments: ".$comments."\n";

 //create email headers
  $headers = "From: $email_from";
  'Reply-To: '.$email_from."\r\n" .
  'X-Mailer: PHP/' . phpversion();


 $mail_sent = @mail($email_to, $email_subject, $email_message, $headers);


 echo $mail_sent ? "Mail sent" : "Mail failed";
}
?>

Using this code the email does not show up in the gmail inbox.Any kind of help will be appreciated.

srinivas.

[bradgrafelman]

For one, you should never use a user-supplied e-mail address in the "From" e-mail header; instead, you should always use a valid e-mail address on your domain.

Also note that this code:

      $headers = "From: $email_from"; 
      'Reply-To: '.$email_from."\r\n" . 
      'X-Mailer: PHP/' . phpversion(); 

is equivalent to this:

      $headers = "From: $email_from"; 

since you're not actually adding (or "concatenating") the last two string pieces onto the end of $headers. That's a good thing, actually, considering you also don't have any line breaks (specifically, a CRLF) after the From header anyway.

[sneakyimp]

I think your script might be vulnerable to email header injection.

Just because you send mail doesn't mean it will necessarily arrive. You may find our email best practices article helpful.

[elearnindia]

Hello bradgrafelman,

I have modified header with concatenation as follows:

//create email headers
$headers = "From: $email_from\n";
$headers .="Reply-To: .$email_from\n";
$headers .= "X-Mailer: PHP/" . phpversion();

Still not getting email in the inbox
of gmail.Is there anything more to be done in the
headers injection.The PHP mail/B function
is returning true.

[elearnindia]

sneakyimp;10956279 wrote:

I think your script might be vulnerable to email header injection.

Just because you send mail doesn't mean it will necessarily arrive. You may find our email best practices article helpful.

Respected sneakyimp,

Please help me with header injection
for plain/text email.Looking forward to your kind
help.

elearnindia.

[sneakyimp]

Those two links should explain everything pretty well. Do you have a particular question that you need answered?