[RESOLVED] Sending an email from a website form

[BalloonBoy]

I'm trying to create a simple form. When filled out on my site it is emailing to me but all the fields are not being sent. Here is the php code:

<?
$subject="from ".$_GET['name'];
$headers= "From: [e-mail]";
mail("[e-mail]", $subject,  "

Contact Form 

 ". "Email: " .$_GET['email'] .$_GET['message'].";

" . $headers);
echo ("Thank you for taking the time to fill out the form. Your message has been received. All issues will be responded to in the order which they were received.");
?>
<script>
	resizeTo(300, 300)
	//window.close()
</script

and here is the code on my site:

<h4>Contact form</h4>
                <form id="form" method="get"  target=”_blank” action="contact.php"> 
                  <div>
                    <label>Enter your name</label>
                    <input type="name" />
                  </div>
                  <div>
                    <label>Enter your e-mail</label>
                    <input type="email" />
                  </div>
                  <div>
                    <label>Enter your message</label>
                    <textarea name="message" cols="1" rows="1"></textarea>
                  </div>
                  <div class="buttons"><a href="#" class="link5" onclick="document.getElementById('form').submit()"><em><b>submit</b></em></a><a href="#" class="link5" onclick="document.getElementById('form').reset()"><em><b>reset</b></em></a></div>

The email is received but the only filled out information being sent is the message. However it is being sent like this:

subject: from

Contact Form

Email: This is the test message

From: [e-mail]

I cant seem to figure out why the email isn't being sent properly. Any help is much appreciated. Thanks.

[bradgrafelman]

Hello, and welcome to PHPBuilder!

As for your code, there are several issues I see...

1. You should never use the '<?' (or "<?=(expression);?>") short tag syntax since it has been deprecated and disabled by default. Instead, all of your PHP scripts should always use the full "<?php" tag for PHP code.

2. You never check to see if the external variables you're referencing actually exist. Common practice is to use [man]isset[/man] or [man]empty/man to ensure that external data (anything in the $_GET array, for example) exists before accessing/using it.

3. Instead of using the $headers variable to supply the mail() function with additional headers, you're simply concatenating its value onto the end of the message.

4. You never check to see if PHP was able to queue the message for deliver successfully or not (e.g. checking whether mail() returns boolean TRUE or FALSE).

5. In your <form> tag, you have "curly" quotes (e.g. &#8221; versus ") around the target attribute. These should be normal double quotes instead.

6. The values "name" and "email" are not valid for the type attribute of an INPUT element. Perhaps you meant to specify the name attribute instead (and give the type attribute a value that makes sense, such as "text")?

[BalloonBoy]

All issues have been resolved. Thanks for your help.