Submit buttons not working

DKY

I have the following code and i can't figure out why the submit buttons do nothing.

echo"<form name='form' method='post' action='".$_SERVER["PHP_SELF"]."' enctype='multipart/form-data'><button type='submit' id='submitsettings' name='UserSettings'>Submit</button>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<button type='submit' id='submitlogout' name='LogOut'>Submit</button></form>";

and at the very top of my page I have:

ob_start();
require("connect.php");
require("Menus.php");

$connectmysql = mysql_connect($host,$user,$password) or die ($cantconnectmysqlmessage);
$db = mysql_select_db($database,$connectmysql) or die ($cantconnectdatabasemessage);

if (((isset($_POST["LogOut"])) && ($_POST["LogOut"] == "Submit")))
{
	$past = time() - 100;
	//this makes the time in the past to destroy the cookie
	setcookie(ID_my_site, gone, $past);
	setcookie(Key_my_site, gone, $past);
	header("Location: oosignin.php");
}

if (((isset($_POST["UserSettings"])) && ($_POST["UserSettings"] == "Submit")))
{
	$OrderNumber = $_GET['OrderNumber'];
	$OrderQuery2 = "SELECT * FROM tblorders WHERE OrderNumber = '".$OrderNumber."'";
	$OrderResult2 = mysql_query($OrderQuery2) or die(mysql_error()."<BR>".$DispQuery2);
	while ($Row2 = mysql_fetch_assoc($OrderResult2))
	{
		header("Location: oousersettings.php?username=".$Row2['username']);
	}
}

NogDog

I think you need to set the value you're checking for as a "value" attribute in the <button> tag, i.e. the text between the <button> and </button> tags is not sent as part of the form data.

DKY

Okay, so I did this (added the value part)

<button type='submit' id='submitsettings' name='UserSettings' value='Submit'>Submit</button>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<button type='submit' id='submitlogout' name='LogOut' value='Submit'>Submit</button>

and dropped the value validation like this

if (isset($_POST["LogOut"]))
{
	$past = time() - 100;
	//this makes the time in the past to destroy the cookie
	setcookie(ID_my_site, gone, $past);
	setcookie(Key_my_site, gone, $past);
	header("Location: oosignin.php");
}

if (isset($_POST["UserSettings"]))
{
	$OrderNumber = $_GET['OrderNumber'];
	$OrderQuery2 = "SELECT * FROM tblorders WHERE OrderNumber = '".$OrderNumber."'";
	$OrderResult2 = mysql_query($OrderQuery2) or die(mysql_error()."<BR>".$DispQuery2);
	while ($Row2 = mysql_fetch_assoc($OrderResult2))
	{
		header("Location: oousersettings.php?username=".$Row2['username']);
	}
}

and it still doesn't work...

dagon

add print_r($_POST) to check what values are being posted.

NogDog

And don't forget to refresh the form page in your browser to get the new form mark-up. (I hate when I do that. 😉 )

NogDog

You know, I started playing around with this because I vaguely remember someone else having a problem with submit-type <button> tags.

<html><head><title>test</title></head><body>
<form action="" method="post">
   <button type="submit" name="one">No Value</button>
   <button type="submit" name="two" value="button 2">Has a Value</button>
</form>
<?php
if(!empty($_POST))
{
   echo "<pre>".print_r($_POST,1)."</pre>";
}

Output in Firefox and in Google Chrome when clicking first he "No Value" button and then the "Has a Value":

Array
(
    [one] => 
)
===============
Array
(
    [two] => button 2
)

Same sequence with IE:

Array
(
    [one] => No Value
)
==================
Array
(
    [two] => button 2
)

So it looks like you should be good to go if you use an explicit value attribute, but you cannot depend on consistent results without it (and I'd put money on IE being an incorrect implementation of the standards).

DKY

Hmm, I did a ctrl+F5 to refresh but it still doesn't work. I click on the buttons and nothing happens at all so I'm not sure where to put the print_r($_POST) and/or if it will work at all if clicking the button does nothing...

dagon

put the print_r() on the first line of the page you submit to.

DKY

I sent a PM.

I have it submit to itself, so I'm echoing it at the top of the page. It says "Array ( ) 1" when I click and when I don't.

dagon

why not use input type='submit' ?

dagon

enctype='multipart/form-data' is only needed for submitting files

NogDog

DKY;10956492 wrote:
I sent a PM.

I have it submit to itself, so I'm echoing it at the top of the page. It says "Array ( ) 1" when I click and when I don't.

The page you sent a link for seemed to work OK for me in both FF and IE, however it seemed that the buttons only worked if you clicked in the top half of the button image itself, which might possibly have something to do with the styling. Are you using a negative bottom margin, perhaps?

DKY

The code for the logout button is the same as the oousersettings.php?username=user page. I don't understand it.

Dagon,
It's just some code I found with a cool mouse over button change feature. Although now that you mention it my mouse over is gone.

The problem must be my CSS somewhere...