Help with PHP Redirect Using Header()

gigabyte

Hi All,

I'm looking for some help using the code below. I just want a simple redirect to happen after the form is submitted however no matter what I do I can't get it to redirect. The page just refreshes. Any help would be greatly appreciated! I've bolded values that I changed for posting here - they are correct in the actual site code. I also just changed the redirect to google.com for example purposes.

<?php
// START NECESSARY MODIFICATIONS

// your name
$recipientname = "[B]NAME[/B]";

// your email
$recipientemail = "[B]EMAIL@EMAIL.COM[/B]";

// subject of the email sent to you
$subject = "[B]SUBJECTHERE[/B]";

// send an autoresponse to the user?
$autoresponse = "yes";

// subject of autoresponse
$autosubject = "Thank you!";

// autoresponse message
$automessage = "[B]Thanks you![/B]";

// END NECESSARY MODIFICATIONS

?>

</head>
<body>

<?php
if($_POST['submitform']) {

$Name = $HTTP_POST_VARS['textfield'];
$Email = $HTTP_POST_VARS['textfield2'];

// check required fields
$dcheck = explode(",",$require);
while(list($check) = each($dcheck)) {
if(!$$dcheck[$check]) {
$error .= "Missing $dcheck[$check]<br>";
}
}

// check email address
if ((!ereg(".+\@.+\..+", $Email)) || (!ereg("^[a-zA-Z0-9_@.-]+$", $Email))){
$error .= "Invalid email address<br>";}

// display errors
if($error) {
?>
<b>Error</b><br>
<?php echo $error; ?><br>
<a href="#" onClick="history.go(-1)">try again</a>
<?php
}
else
{

$browser = $HTTP_USER_AGENT;
$ip = $REMOTE_ADDR;

// format message
$message = "[B]SUBMITFORM FOR[/B] $recipientname:

Name: $Name
Email: $Email

-----------------------------

Browser: $browser
User IP: $ip";

// send mail and print success message
mail($recipientemail,"$subject","$message","From: $Name <$Email>");

if($autoresponse == "yes") {
$autosubject = stripslashes($autosubject);
$automessage = stripslashes($automessage);
mail($Email,"$autosubject","$automessage","From: $recipientname <$recipientemail>");
}
header("Location: http://www.google.com");
}
}
else {
?>
<div class="fatlossoptin">
  <div class="fatlossoptincontent">
<form name="contactform" action="<?php echo $PHP_SELF; ?>" method="post">
<input type="hidden" name="require" value="Name,Email">
<br>
<table width="240" border="0" cellspacing="0" cellpadding="5" align="center">
        <tr>
          <td width="71">Name:</td>
          <td width="169">
              <input type="text" name="textfield" id="NAMEIDHERE" class="text" />
            </td>
        </tr>
        <tr>
          <td>Email:</td>
          <td><input type="text" name="textfield2" id="EMAILIDHERE" class="text" /></td>
        </tr>
        <tr>
          <td colspan="2" align="center"><input type="submit" class="button" value=""/></td>
        </tr>
      </table>
    </form>
  </div>
</div>
<?php } ?>

dagon

you can't use header after output.

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP. It is a very common error to read code with include(), or require(), functions, or another file access function, and have spaces or empty lines that are output before header() is called. The same problem exists when using a single PHP/HTML file.

gigabyte

How can I redirect after the form is submitted then? Somehow use header at the top of the PHP and call it after the form is submitted?

dagon

re-arange the php, so there's no output before the header call.

gigabyte

I tried moving this block:

// send mail and print success message 
mail($recipientemail,"$subject","$message","From: $Name <$Email>"); 

if($autoresponse == "yes") { 
$autosubject = stripslashes($autosubject); 
$automessage = stripslashes($automessage); 
mail($Email,"$autosubject","$automessage","From: $recipientname <$recipientemail>"); 
} 
header("Location: http://www.google.com");

... to the very top of the file, just after the if($_POST['submitform']) { and just before the </head> but I get nothing. Funnily I got the emails but the redirection still doesn't go anywhere. This is painful!

NogDog

Well, normally your HTML does not start with a closing </head> tag, which suggests to me that either there is more code before what you've shown us, or else this file is included/required by another file, which is where the <html> and <head> tags are? If so, then you either need to rearrange things so that all the PHP processing which leads up to the header() call happens before anything gets output to the browser, or else you will need to incorporate output buffering (see [man]ob_start/man), which does add a bit of extra processing load (not a big deal, but something to consider when weighing that against the time it would take to refactor your script.)

gigabyte

It's a sidebar in wordpress. The blog shows this on the side to enter in some detail, and then redirect you to another page. I've removed the head and body tags as I assume they're not required.

NogDog

But if this code is in the sidebar file, it's likely that file is loaded by another file, most likely the index.php file. If so, you either need to move the logic that ends up executing the header into that file (again before any function or text that generates output, or you could stick an ob_start() at the very start of that index.php file to buffer all output until all of the PHP processing is done.