[RESOLVED] Linking to and displaying data

coco1985

Hi,

I am trying to link to page that shows some of the data in a table. It's not working right because if the table has for example, 3 rows of data, three links show up. I just want there to be one link and when you click the link, it will show all three rows of data. Also, when I click the link, only one row of data shows up. Can someone help me?

Here is the code for the page with the link:

}

$query = "SELECT clientid,clientname,date,utilityco,account,reason,notes,amount from claims"; 
$result = mysql_query($query) or die('Sorry, could not get data at this time ');

if (mysql_num_rows($result) == 0) 
{ 
  echo "<h3>Sorry, there are no claims posted at this time, please try back later.</h3>"; 
} else 
{ 
  while($row=mysql_fetch_array($result, MYSQL_ASSOC)) 
{ 
	$clientid = $row['clientid'];
	$clientname = $row['clientname']; 
	$date = $row['date']; 
	$utilityco = $row['utilityco']; 
	$account = $row['account']; 
	$reason = $row['reason']; 
	$notes = $row['notes']; 
	$amount = $row['amount']; 

echo "<a href=\"index.php?content=showclaims&id=$clientid\">Refund Claims</a>\n"; 
} 
}
?>

Here is the code for the target page:

<?php
$con = mysql_connect("localhost", "test", "test") or  die('Sorry, could not connect to server');

mysql_select_db("tristem", $con) or die('Sorry, could not connect to database');

$clientid = $_GET['id'];

$query = "SELECT clientid,clientname,date,utilityco,account,reason,notes,amount from claims where clientid = $clientid";

$result = mysql_query($query) or die('Sorry, could not find data requested'); 
$row = mysql_fetch_array($result, MYSQL_ASSOC) or die('No records retrieved'); 
$clientid = $row['clientname']; 
$clientname = $row['clientname']; 
$date = $row['date']; 
$utilityco = $row['utilityco']; 
$account = $row['account']; 
$reason = $row['reason'];
$notes = $row['notes']; 
$amount = $row['amount']; 



echo "<h1>$clientname</h1><br><br>\n";

echo "<h3>Date:</h3> $date <br><br>\n"; 
echo "<h3>Utility Company:</h3> $utilityco <br><br>\n"; 
echo "<h3>Accounts:</h3> $account <br><br>\n"; 
echo "<h3>Reason:</h3> $reason <br><br>\n"; 
echo "<h3>Notes:</h3> $notes <br><br>\n"; 
echo "<h3>Amount:</h3> $amount <br><br>\n"; 


echo "<br><br>\n";

?>

bradgrafelman

coco1985 wrote:
I just want there to be one link

Then why are you using a while() loop to loop through the entire MySQL result set (which you haven't LIMIT'ed at all)?

In other words (to answer my own rhetorical question :p), remove the while() loop in the first code snippet and instead simply call the mysql_fetch_*() function once (note: it'd be slightly shorter to simply use [man]mysql_fetch_assoc/man rather than specifying the MYSQL_ASSOC mode for the generic [man]mysql_fetch_array/man function). You should also add a "LIMIT 1" clause to your SQL query so that the MySQL server doesn't bother collecting more than one result since you don't care about the rest.

EDIT: Also, when posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags (versus the generic

 bbcode tags) as they make your code much easier to read and analyze.

coco1985

Cool, that worked! You rock!! I think I did it....

Then why are you using a while() loop to loop through the entire MySQL result set (which you haven't LIMIT'ed at all)?

-I really have no idea what I'm doing.

Do you know how to make it to where when I click on the link, all the data for that clientid shows up? Instead of just one row?

Thanks!

bradgrafelman

coco1985;10956705 wrote:
Do you know how to make it to where when I click on the link, all the data for that clientid shows up? Instead of just one row?

Use a while() loop. 🙂

coco1985

Wow, you are fast! And thank you again 🙂

bradgrafelman

Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu above.

Also, note another optimization you could/should make in your first code snippet is to remove all of the columns from the SELECT query except for clientid, since that appears to be the only column from which you actually need data.

coco1985

One more question,

I got the while loop working repeating the data. How do you take a piece of data out, like the client name, and not repeat it over and over? I just want that piece to show up one time at the top of the page.

bradgrafelman

Easiest way might be to perform a separate SELECT query (to retrieve just that column) once, and then process all of the other data in the loop.

coco1985

bradgrafelman;10956712 wrote:
Easiest way might be to perform a separate SELECT query (to retrieve just that column) once, and then process all of the other data in the loop.

doh! I should have thought of that. Thanks again!