if in switch function problem

[PHPzX]

Here is my function

function IsValidSkin($skinid) {
	if ($skinid>299 || $skinid<1) return false;
	switch ($skinid) {
		case 3; case 4; case 5; case 6; case 8; case 17; case 42; case 50; case 61; case 65; case 71; case 74; case 86; case 92; case 268; case 99; case 119;
                if($row['Sex'] == "1")  echo' case14';
			return false;
			break;
	}	
	return true;
}

But the case that in the row sex if isn't working.

Thanks for help.

[bradgrafelman]

In a [man]switch[/man] structure, the "case" clause(s) should be terminated with a colon, not a semicolon.

EDIT: Oops, disregard that... apparently using a semicolon is an alternative syntax (one I've never seen before).

[NogDog]

$row is not defined anywhere in the function. Perhaps you need to pass it as another paramter (or just the 'Sex' element)?

PS: I'd probably eschew the switch() and do something like:

<?php
function IsValidSkin($skinid, $sex)
{
   if ($skinid > 299 || $skinid < 1) {
      return false;
   }
   $ids = array(3,4,5,6,8,17,42,50,61,65,71,74,86,92,268,99,119);
   if (in_array($skinid, $ids) && $sex == "1") {
      echo ' case14';
      return false;
   }
   return true;
}

Not sure what the actual logic is you want if the skinId is one of those values in the array, so that may not be exactly what you want.