Strange MySQL error...

SP8600

Can't seen to find an answer to this one myself so hopefully some one here will know. When using the below code I get the output "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1"
Any idea's?
Thanks for any help

<?php

include_once("globals.php");

connect_mysql();

$email = $_GET["email"];

$resultNewsletter = mysql_query("SELECT * FROM newsletter WHERE email = $email")or die(mysql_error());
$rowsNewsletter = mysql_num_rows($resultNewsletter);

if ($rowsNewsletter == 1) {
	echo "Email allready subscribed to Newsletter";
}

else {

mysql_query("INSERT INTO newsletter (id, email) VALUES('NULL', '$_GET[email]')") or die(mysql_error());

echo ("Done");

}


?>

NogDog

In the first query, you need single quotes around '$email', while in the second query you need to remove the quotes around NULL (it's a SQL keyword, not a string literal). In any case you can save yourself a query by making the email column unique in the DB table, then just do the insert and check for a duplicate key error. (Regarding the NULL, you don't even need that in the insert, just leave out that column.)

// mysql connection stuff, then...
$email = mysql_real_escape_string($_GET['email']); // *always* sanitize user inputs to SQL
$sql = "INSERT INTO newsletter (email) VALUES('$email')";
$result = mysql_query($sql);
if($result == false)
{
   if(mysql_errno() == 1062) // duplicate key error
   {
      echo "Email allready subscribed to Newsletter";
   }
   else
   {
      error_log(mysql_error()."\n$sql");
      echo "Sorry, there was a database error which has been logged for the SysAdmin to look at.";
   }
}
else
{
   echo "Done.";
}

SP8600

Thanks for that answer... Have changed to that however now I seem to be getting this error:

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: Access denied for user 'beta'@'localhost' (using password: NO) in /home/public_html/beta/_data/newsletterSidebar.php on line 5

NogDog

Make sure you have done your connection to mysql (mysql_connect()) before calling that function.