Problem after server change

MichaelHe

I have earlier ask a question about getimagesize that didn't work after server change... I have now found out that it wasn't getimagesize that didn't work but the script around it...

I've simplified the script to only where the problem is... And exchanged the getimagesize function with echo "ok"; just to make debugging easier..

<?
if($_POST){
  IF($upload>''){echo "ok";}
}

?>
<form enctype="multipart/form-data" method="post" action='<?=$_SERVER[PHP_SELF]?>'>
<input name="upload" type="file">
<input type="submit" name="Submit" value="Upload">
</form>
<?

This very simple script simply writes OK on the screen when something is put in the field for upload...
The problem is that it doesn't work on the new server... I have just tried uploading the script on another website which is still at the old host compagny, and here it works fine... But if I upload it on the new server at the new host compagny it doesn't work...

Could it be different versions of PHP or what could be the reason why such a simple function doesn't work..

Does anyone have an idea ?

best
Michael

bradgrafelman

Some comments about the code above:

Instead of doing this:
```
if($_POST){
```
it would probably be better if you use [man]empty/man or [man]isset/man to check for the presence of a specific form entity that you're expecting (such as a submit button, for example).
$upload is an undefined variable. Perhaps you meant $_FILES['upload'] instead? See these manual pages for examples on handling external data and/or file uploads (respectively): [man]variables.external[/man] and [man]features.file-upload[/man].
This doesn't really make much sense:
```
IF($upload>'')
```
You're checking to see if a variable (undefined, at the moment) is.. greater than.. a string? Is PHP greater than a banana? Is Billy less than a vuvuzela? Perhaps you should be using [man]empty/man or [man]isset/man instead?

Note, however, if you're trying to check if a file was uploaded, you should instead 1) use [man]isset/man to verify that $_FILES['upload'] exists and, if so, 2) check the error code PHP returned to make sure that the upload succeeded (see this manual page for more info: [man]features.file-upload.errors[/man]).
Note that the "<?" (and "<?=(expression);?>") short tags have been deprecated and disabled by default by recent versions of PHP (and removed altogether, IIRC, from future versions of PHP).

Instead, you should always use the full "<?php" opening tags for all PHP code.

Your code probably worked before because your old host had the highly deprecated "register_globals" directive enabled. See this manual page for an explanation why this directive has been not only deprecated and disabled by default but even declared a possible security risk: [man]security.globals[/man].