query not working

[harkly]

I am doing a search and for some reason I get different results when I use the following

#1

$query = mysql_query("Select * FROM user WHERE userID = '$userID' AND gender=$genderPref");

vs.
#2

$query = mysql_query("Select * FROM user WHERE userID = '$userID' AND gender=1");

I am using a form that is passing the genderPref as 1, please see the bottom for code

The results should be ...

UserID: userID, gender, genderPref
So all should be gender=1

Results for #1, it is pulling "nester" which is not a 1 and it is missing 2 others
UserID: test4, 1, 2
UserID: nester, 2, 1
UserID: neer, 1, 2

Results for #2
UserID: test4, 1, 2
UserID: kelly, 1, 2
UserID: adfggg, 1, 1
UserID: neer, 1, 2

I input this just to be sure what was being passed and it all looks good.

  echo "Gender looking for $genderPref <br>";

<?php

  require_once('zipcode.class.php');

  include('library/login.php');
  login();
  mysql_select_db('test');

  $gender=$_POST["gender"];
  $genderPref=$_POST["genderPref"];
  $ageMin=$_POST["ageMin"];
  $ageMax=$_POST["ageMax"];
  $smoke=$_POST["smoke"];
  $religion=$_POST["religion"];
  $zip_code=$_POST["zip_code"];

  $today = date("Y");
  $year1 = $today-$ageMin;
  $year2 = $today-$ageMax;

  echo "Gender looking for $genderPref <br>";

$z = new zipcode_class;
$zips = $z->get_zips_in_range($_POST['zip_code'], $_POST['miles'], _ZIPS_SORT_BY_DISTANCE_ASC, true);

if ($zips === false) {
    echo 'Error: '.$z->last_error;
} else {
    $zips_in_range = implode(',', array_keys($zips) );
}

$result = mysql_query("SELECT userID FROM user WHERE zip IN (". $zips_in_range .")");

while ($row = mysql_fetch_assoc($result) )
  {
    foreach ($row as $userID)
      {
        extract($row, EXTR_PREFIX_SAME, "userID");


$query = mysql_query("Select * FROM user WHERE userID = '$userID' AND gender=1");

  while ($r=mysql_fetch_array($query)) 
        {
                 $userID=$r["userID"];
                 $bd_year=$r["bd_year"];
                 $gender=$r["gender"];
                 $genderPref=$r["genderPref"];
                 $photo_1=$r["photo_1"];
                 $city=$r["city"];
                 $state=$r["state"];
                 $zip=$r["zip"];
                 $age = $r['age'];

          echo " UserID: $userID, $gender, $genderPref <br>";
        }
  }
  }
?>

form...

<select class='selectsex' name='gender'>
  <option value='1'>Women</option>
  <option value='2'>Men</option>
</select>

<br><br>


<select class='selectsex' name='genderPref'>
  <option value='1'>Women</option>
  <option value='2'>Men</option>
  <option value='3'>Either</option>
</select>

[sneakyimp]

Fetching all the users in the nearby zips and then looping through those and running a query for each one to fetch additional information is inefficient. Seems to me you could run just one query, but I'm not really sure what you are trying to accomplish. You have tried to fetch users with gender=1. I'm sort of unclear on what you are trying to do.

Also, you completely fail to check mysql_query returns any errors. Your indenting is also very sloppy. I've cleaned the code a bit here:

<?php

require_once('zipcode.class.php');

include('library/login.php');
login();
mysql_select_db('test');

$gender=$_POST["gender"];
$genderPref=$_POST["genderPref"];
$ageMin=$_POST["ageMin"];
$ageMax=$_POST["ageMax"];
$smoke=$_POST["smoke"];
$religion=$_POST["religion"];
$zip_code=$_POST["zip_code"];

$today = date("Y");
$year1 = $today-$ageMin;
$year2 = $today-$ageMax;

echo "Gender looking for $genderPref <br>";

$z = new zipcode_class;
$zips = $z->get_zips_in_range($_POST['zip_code'], $_POST['miles'], _ZIPS_SORT_BY_DISTANCE_ASC, true);

if ($zips === false) {
    echo 'Error: '.$z->last_error;
} else {
    $zips_in_range = implode(',', array_keys($zips) );
}

$result = mysql_query("SELECT userID FROM user WHERE zip IN (". $zips_in_range .") AND")
	or die('user in zip query failed');



while ($row = mysql_fetch_assoc($result) ) {
	foreach ($row as $userID) {
		extract($row, EXTR_PREFIX_SAME, "userID");
		$query = mysql_query("Select * FROM user WHERE userID = '$userID' AND gender=1")
			or die('second query failed');

	while ($r=mysql_fetch_assoc($query)) {
		$userID = $r["userID"];
		$bd_year = $r["bd_year"];
		$gender = $r["gender"];
		$genderPref = $r["genderPref"];
		$photo_1 = $r["photo_1"];
		$city = $r["city"];
		$state = $r["state"];
		$zip = $r["zip"];
		$age = $r['age'];

		echo " UserID: $userID, $gender, $genderPref <br>";
	}
}
}
?>