help with email form to send attachments

[apparentlyrich]

Hi all,

Would very much appreciate it if you all could help me with a form I'm trying to build for a project. I'll post the code of the form and the php processor below.

Basically, I need the form to force users to fill out required fields, validate e-mail addresses AND allow users to send files (via the upload file button) which is all then sent to an email address.

Any help would be much appreciated.

Here's the code:

The form:

<form id="Enquiries" name="Enquiries" method="post" action="enquiryprocess3.php">
	<tr>
	  <td colspan="2" align="center"><strong>*</strong> Indicates a required field.<br />
      <?=$errorString?><br />
      <? echo $email_error?></td>
	  </tr>
	<tr>
    <td><label for="Name">* Name:</label></td>
    <td colspan="2"><input name="Name" type="text" id="Name" size="25" maxlength="80" value="<?=Name?>"/></td>
  </tr>
   <tr>
    <td><label for="Company Name">Company Name:</label></td>
    <td colspan="2"><input name="Company Name" type="text" id="CompanyName" size="25" maxlength="80" value="<?=CompanyName?>"/></td>
  </tr>
  <tr>
    <td><label for="Telephone">* Telephone:</label></td>
    <td colspan="2"><input name="Telephone" type="text" onkeyup="javascript:this.value=this.value.replace(/[^0-9]/g, '');" id="Telephone" size="25" maxlength="11" value="<?=Telephone?>"/></td>
  </tr>
  <tr>
    <td height="26"><label for="Email">* Email:</label></td>
    <td colspan="2"><input name="Email" type="text" id="Email" size="25" maxlength="80" value="<?=Email?>"/></td>
  </tr>
  <tr>
    <td valign="top"><label for="Postal Address">Postal Address:</label></td>
    <td colspan="2"><textarea name="Postal Address" id="PostalAddress" cols="30" rows="4" value="<?=PostalAddress?>"></textarea></td>
  </tr>
  <tr>
    <td valign="top"><label for="Message">* Message:</label></td>
    <td colspan="2"><textarea name="Message" id="Message" cols="30" rows="4" value="<?=Message?>"></textarea></td>
  </tr>
  <tr>
    <td><label for="Upload File">Upload File:</label></td>
    <td colspan="2"><input name="Upload File" id="UploadFile" type="file" value="<?=UploadFile?>"/></td>
  </tr>
  <tr>
    <td></td>
    <td align="right"><input name="Submit" id="Submit" type="submit" value="Send" /></td>
    <td align="left"><input name="Reset" id="Reset" type="reset" value="Reset this form" /></td>
  </tr>
  </form>

The current process model:

<?php
/*
 *  Specify the field names that are in the form. This is meant
 *  for security so that someone can't send whatever they want
 *  to the form.
 */
$allowedFields = array(
    'Name',
    'CompanyName',
	'Telephone',
    'Email',
    'Telephone',
	'PostalAddress'
	'Message',
	'UploadFile',
);

// Specify the field names that you want to require...
$requiredFields = array(
    'Name',
	'Telephone',
    'Email',
    'Message',
);

/* If e-mail is not valid show error message */
if (!preg_match("/([\w\-]+\@[\w\-]+\.[\w\-]+)/", $requiredFields['Email']))
{
    $email_error("E-mail address not valid");
}
// Loop through the $_POST array, which comes from the form...
$errors = array();
foreach($_POST AS $key => $value)
{
    // first need to make sure this is an allowed field
    if(in_array($key, $allowedFields))
    {
        $$key = $value;

    // is this a required field?
    if(in_array($key, $requiredFields) && $value == '')
    {
        $errors[] = "The field $key is required.";
    }
}
}

// were there any errors?
if(count($errors) > 0)
{
    $errorString = '<p>There was an error processing the form.</p>';
    $errorString .= '<ul>';
    foreach($errors as $error)
    {
        $errorString .= "<li>$error</li>";
    }
    $errorString .= '</ul>';

// display the previous form
include 'contact.php';
}
else
{
// Obtain file upload vars
$fileatt      = $_FILES['fileatt']['tmp_name'];
$fileatt_type = $_FILES['fileatt']['type'];
$fileatt_name = $_FILES['fileatt']['name'];

if (is_uploaded_file($fileatt)) {
  // Read the file to be attached ('rb' = read binary)
  $file = fopen($fileatt,'rb');
  $data = fread($file,filesize($fileatt));
  fclose($file);

  // Generate a boundary string
  $semi_rand = md5(time());
  $mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

  // Add the headers for a file attachment
  $headers .= "\nMIME-Version: 1.0\n" .
              "Content-Type: multipart/mixed;\n" .
              " boundary=\"{$mime_boundary}\"";

  // Add a multipart boundary above the plain message
  $message = "This is a multi-part message in MIME format.\n\n" .
             "--{$mime_boundary}\n" .
             "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
             "Content-Transfer-Encoding: 7bit\n\n" .
             $body . "\n\n";

$body = "Dear Barry,
The following enquiry has been submitted from the website:

Name: $Name
Company: $CompanyName
Telephone: $Telephone
E-mail: $Email
Postal Address: $Address
Message: $Message

End of message
";


  // Base64 encode the file data
  $data = chunk_split(base64_encode($data));

  // Add file attachment to the message
  $message .= "--{$mime_boundary}\n" .
              "Content-Type: {$fileatt_type};\n" .
              " name=\"{$fileatt_name}\"\n" .
              //"Content-Disposition: attachment;\n" .
              //" filename=\"{$fileatt_name}\"\n" .
              "Content-Transfer-Encoding: base64\n\n" .
              $data . "\n\n" .
              "--{$mime_boundary}--\n";
}

// Send the message
$to = "[e-mail]";
$subject = "Enquiry from Blissett Design, Print and Media Website";


$ok = mail($to, $subject, $message, $headers);
if ($ok) {
	$theResults = <<<EOD
<html>
<head>
<title>Blissett Design, Print and Media | Make An Enquiry</title>
<style type="text/css">
<!--
#apDiv1 {
	position:absolute;
	left:300px;
	top:50px;
	width:750px;
	height:450px;
	z-index:1;
	background-image: url("http://www.blissettdigital.co.uk/images/contact_bg.jpg");
}
#apDiv2 {
	position:absolute;
	left:332px;
	top:50px;
	width:649px;
	height:378px;
	z-index:2;
}
p {
	font-family: Arial;
	font-size: 14px;
	color: #FFFFFF;
}
h1 {
	font-family: Georgia;
	font-size: 47px;
	color: #D67445;
	text-align: right;
}
#apDiv3 {
	position:absolute;
	left:-14px;
	top:220px;
	width:194px;
	height:105px;
	z-index:3;
}
-->
</style>
</head>

<body bgcolor="#000000">
<div id="apDiv1">
<div id="apDiv2">
  <h1>Thank You</h1><hr />
  <p>&nbsp;</p>
  <p>Your message has been received. We will get back to you shortly.</p>
  <p>Yours Sincerely,<br />
  Blissett Design, Print and Media</p>
 <div id="apDiv3"><img src="http://www.blissettditigal.co.uk/images/logo.png" /></div>
</div>
</div>
</body>
</html>
EOD;
echo "$theResults";

} else {
	$theError = <<<EOD

<html>
<head>
<title>Blissett Design, Print and Media | Make An Enquiry</title>
<style type="text/css">
<!--
#apDiv1 {
	position:absolute;
	left:300px;
	top:50px;
	width:750px;
	height:450px;
	z-index:1;
	background-image: url("http://www.blissettdigital.co.uk/images/contact_bg.jpg");
}
#apDiv2 {
	position:absolute;
	left:332px;
	top:100px;
	width:649px;
	height:378px;
	z-index:2;
}
p {
	font-family: Arial;
	font-size: 14px;
	color: #FFFFFF;
}
h1 {
	font-family: Georgia;
	font-size: 47px;
	color: #D67445;
	text-align: right;
}
#apDiv3 {
	position:absolute;
	left:-14px;
	top:220px;
	width:194px;
	height:105px;
	z-index:3;
}
-->
</style>
</head>

<body bgcolor="#000000">
<div id="apDiv1"></div>
<div id="apDiv2">
  <h1>Sorry</h1><hr />
  <p>&nbsp;</p>
    <b>Your form could not be processed.</b><br />
Please re-submit the form.
<p><a href="enquiries.php">Click here to go back to the form</a></p>
</div>
</body>
</html>
EOD;
echo "$theError";

}

I keep getting a Parse error: syntax error, unexpected $end in /home/apparen3/public_html/enquiryprocess2.php on line 147 error, so I'd really appreciate the help!

[bradgrafelman]

You've got spaces after the heredoc identifiers.

Also, when posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

[apparentlyrich]

I've adjusted the following:

$body.  "Dear Barry,\n"
		"The following enquiry has been submitted from the website:\n\n"
		"Name: $Name\n" 
		"Company: $CompanyName\n" 
		"Telephone: $Telephone\n" 
		"E-mail: $Email\n" 
		"Postal Address: $Address\n" 
		"Message: $Message\n\n" 
		"End of message."; 

But am still getting errors. I am now getting: Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /home/blissett-digital/WWW/public_html/enquiryprocess4.php on line 92

I apologise for my lack of php knowledge as I am still learning it. Can someone please tell me how to get the processor script working or recommend an alternative?

[apparentlyrich]

I've removed the spaces but am still getting the error.

Any ideas?

[bradgrafelman]

You have a bunch of string pieces thrown together with nothing between them. To join two separate string pieces, you need to use the concatenation operator (a period) between them.

See this manual page for more info: [man]operators.string[/man].

[apparentlyrich]

bradgrafelman;10957745 wrote:

You have a bunch of string pieces thrown together with nothing between them. To join two separate string pieces, you need to use the concatenation operator (a period) between them.

See this manual page for more info: [man]operators.string[/man].

Thank you for your reply.

Thank you for the link to the manual. However, I would really like to keep the forced line breaks in the code in order to format the $body message.

[bradgrafelman]

apparentlyrich wrote:

However, I would really like to keep the forced line breaks in the code in order to format the $body message.

Er... okay? Not sure how that has any relevance to the issue at hand?

[apparentlyrich]

Apologies,

I'm just trying to understand where the broken/incomplete strings are. I figured that those there were causing the problem, but if they were, I was also wondering how I could re-work the code so that I could maintain that formatting for the $body message.

[bradgrafelman]

Read my post above:

bradgrafelman wrote:

You have a bunch of string pieces thrown together with nothing between them. To join two separate string pieces, you need to use the concatenation operator (a period) between them.

Then read the manual page I linked to.

To join one string to another, you must use the concatenation operator - you can't simply throw all the string pieces next to each other.

[apparentlyrich]

Sorry for being so thick.

As per your instruction, I've changed the code to look like this:

$body =  "Dear Barry,\n" .
		"The following enquiry has been submitted from the website:\n\n" .
		"Name: $Name\n" .
		"Company: $CompanyName\n" .
		"Telephone: $Telephone\n" .
		"E-mail: $Email\n" .
		"Postal Address: $Address\n" .
		"Message: $Message\n\n" .
		"End of message.";

but when I try to submit the form, I get the Parse error: syntax error, unexpected $end in /home/blissett-digital/WWW/public_html/enquiryprocess4.php on line 243 error.

The rest of the code remains untouched and all spaces have been removed. Any ideas as to what is stopping the form form processing properly?

[bradgrafelman]

Unexpected $end errors almost always point to a mismatched number of '{' and '}' braces. However...

One problem I noticed in your code snippet above is that you're using the heredoc syntax (e.g. "<<<EOD") yet you didn't watch the whitespace carefully (as the manual forewarns those who use the heredoc/nowdoc syntax). You can not have any whitespace after (or before) the ending delimiter, thus "<<<EOD " (which is what you have) is not the same as "<<<EOD", nor is "EOD; " (again, what you have) the same as "EOD;" (on a line by itself).

[apparentlyrich]

I went in and deleted all spaces after every line in the code, including the spaces before or after heredoc declarations. So I'm pretty sure it's not that.

Do you think you can spot where the missing brace(s) are?

Thank you again for all your help.

[bradgrafelman]

Post a new copy of your code so that we can see what you're working with now.

[apparentlyrich]

Here's the updated code for the form processor:

<?php 
/* 
*  Specify the field names that are in the form. This is meant 
*  for security so that someone can't send whatever they want 
*  to the form. 
*/ 
$allowedFields = array( 
    'Name',
    'CompanyName',
    'Telephone',
    'Email',
    'Telephone',
    'PostalAddress',
    'Message',
    'UploadFile',
);

// Specify the field names that you want to require... 
$requiredFields = array( 
    'Name',
    'Telephone',
    'Email',
    'Message',
);

/* If e-mail is not valid show error message */ 
if (!preg_match("/([\w\-]+\@[\w\-]+\.[\w\-]+)/", $requiredFields['Email']))
{
    $email_error("E-mail address not valid");
}
// Loop through the $_POST array, which comes from the form... 
$errors = array();
foreach($_POST AS $key => $value)
{
    // first need to make sure this is an allowed field 
    if(in_array($key, $allowedFields))
    {
        $$key = $value;

    // is this a required field? 
    if(in_array($key, $requiredFields) && $value == '')
    {
        $errors[] = "The field $key is required.";
    }
}
}

// were there any errors? 
if(count($errors) > 0)
{
    $errorString = '<p>There was an error processing the form.</p>';
    $errorString .= '<ul>';
    foreach($errors as $error)
    {
        $errorString .= "<li>$error</li>";
    }
    $errorString .= '</ul>';

// display the previous form 
include 'enquiries2.php';
}
else
{
// Obtain file upload vars 
$fileatt      = $_FILES['fileatt']['tmp_name'];
$fileatt_type = $_FILES['fileatt']['type'];
$fileatt_name = $_FILES['fileatt']['name'];

if (is_uploaded_file($fileatt)) {
  // Read the file to be attached ('rb' = read binary) 
  $file = fopen($fileatt,'rb');
  $data = fread($file,filesize($fileatt));
  fclose($file);

  // Generate a boundary string 
  $semi_rand = md5(time());
  $mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

  // Add the headers for a file attachment 
  $headers .= "\nMIME-Version: 1.0\n" .
              "Content-Type: multipart/mixed;\n" .
              " boundary=\"{$mime_boundary}\"";

  // Add a multipart boundary above the plain message 
  $message = "This is a multi-part message in MIME format.\n\n" .
             "--{$mime_boundary}\n" .
             "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
             "Content-Transfer-Encoding: 7bit\n\n" .
             $body . "\n\n";

$body .=  "Dear Barry,\n" .
		"The following enquiry has been submitted from the website:\n\n" .
		"Name: $Name\n" .
		"Company: $CompanyName\n" .
		"Telephone: $Telephone\n" .
		"E-mail: $Email\n" .
		"Postal Address: $Address\n" .
		"Message: $Message\n\n" .
		"End of message.";


  // Base64 encode the file data 
  $data = chunk_split(base64_encode($data));

  // Add file attachment to the message 
  $message .= "--{$mime_boundary}\n" .
              "Content-Type: {$fileatt_type};\n" .
              " name=\"{$fileatt_name}\"\n" .
			  "Content-Disposition: attachment;\n" . 
              " filename=\"{$fileatt_name}\"\n" . 
              "Content-Transfer-Encoding: base64\n\n" .
              $data . "\n\n" .
              "--{$mime_boundary}--\n";
} 

// Send the message 
$to = "[e-mail]";
$subject = "Enquiry from Blissett Design, Print and Media Website";


$ok = mail($to, $subject, $message, $headers);
if ($ok) {
    $theResults = <<<EOD
<html>
<head>
<title>Blissett Design, Print and Media | Make An Enquiry</title>
<style type="text/css">
<!--
#apDiv1 {
    position:absolute;
    left:300px;
    top:50px;
    width:750px;
    height:450px;
    z-index:1;
    background-image: url("http://www.blissettdigital.co.uk/images/contact_bg.jpg");
}
#apDiv2 {
    position:absolute;
    left:332px;
    top:50px;
    width:649px;
    height:378px; 
    z-index:2;
}
p {
    font-family: Arial;
    font-size: 14px;
    color: #FFFFFF;
}
h1 {
    font-family: Georgia;
    font-size: 47px;
    color: #D67445;
    text-align: right;
}
#apDiv3 {
    position:absolute;
    left:-14px;
    top:220px;
    width:194px;
    height:105px;
    z-index:3;
}
-->
</style>
</head>

<body bgcolor="#000000">
<div id="apDiv1">
<div id="apDiv2">
  <h1>Thank You</h1><hr />
  <p>&nbsp;</p>
  <p>Your message has been received. We will get back to you shortly.</p>
  <p>Yours Sincerely,<br />
  Blissett Design, Print and Media</p>
<div id="apDiv3"><img src="http://www.blissettditigal.co.uk/images/logo.png" /></div>
</div>
</div>
</body>
</html>
EOD;
echo "$theResults";

} else {
    $theError = <<<EOD
<html>
<head>
<title>Blissett Design, Print and Media | Make An Enquiry</title>
<style type="text/css">
<!--
#apDiv1 {
    position:absolute;
    left:300px;
    top:50px;
    width:750px;
    height:450px;
    z-index:1;
    background-image: url("http://www.blissettdigital.co.uk/images/contact_bg.jpg");
}
#apDiv2 {
    position:absolute;
    left:332px;
    top:100px;
    width:649px;
    height:378px;
    z-index:2;
}
p {
    font-family: Arial;
    font-size: 14px;
    color: #FFFFFF;
}
h1 {
    font-family: Georgia;
    font-size: 47px;
    color: #D67445;
    text-align: right;
}
#apDiv3 {
    position:absolute;
    left:-14px;
    top:220px;
    width:194px;
    height:105px;
    z-index:3;
}
-->
</style>
</head>

<body bgcolor="#000000">
<div id="apDiv1"></div>
<div id="apDiv2">
  <h1>Sorry</h1><hr />
  <p>&nbsp;</p>
    <b>Your form could not be processed.</b><br />Please re-submit the form.<p><a href="enquiries.php">Click here to go back to the form</a></p>
</div>
</body>
</html>
EOD;
echo "$theError";
}

[bradgrafelman]

You've still got whitespace after the heredoc identifiers in that code snippet.

EDIT: Actually, looks like it's hard to tell... the forum appears to be modifying the code snippet. Can you just rename the file to have a .txt (plain text) file extension and attach it to your next post?

EDIT2: Okay, so I cheated and used my moderator abilities to "edit" your post and copy the exact text you posted. :p

The whitespace is indeed not there; instead, your problem is that the '{' on line 63 (above the "Obtain file upload vars" code comment) is never closed.

[apparentlyrich]

Thank you for all your help.

[sneakyimp]

Brad, you have the patience of Job.

[bradgrafelman]

apparentlyrich;10957784 wrote:

Thank you for all your help.

No problem; don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu above.

sneakyimp;10957793 wrote:

Brad, you have the patience of Job.

Thanks. Most of my other qualities can probably be summed up by this smiley: :evilgrin:

[apparentlyrich]

bradgrafelman;10957817 wrote:

No problem; don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu above.

Thanks. Most of my other qualities can probably be summed up by this smiley: :evilgrin:

@ I'll be sure to do that and give you mad props for helping me with this problem. You really have been extremely patient and very helpful - you've restored my faith in forums like these!

UPDATE: The main part of the processor now works (Thanks bradgrafelman) and when the e-mail is sent the user is taken through to the defined thank you page. My next problem is that when the e-mail is sent however, no attachments come through with the e-mail and the message from defined in $body is not shown. What does come through to the user is this:

--
Content-Type: ;
name=""
Content-Transfer-Encoding: base64

Any ideas on how I can get the attachment to be attached to the e-mail and get the message as defined in $body to show in the actual e-mail?

Thanks again.

[bradgrafelman]

Couple issues I see here:

  // Add the headers for a file attachment 
  $headers .= "\nMIME-Version: 1.0\n" . 
              "Content-Type: multipart/mixed;\n" . 
              " boundary=\"{$mime_boundary}\""; 

  // Add a multipart boundary above the plain message 
  $message = "This is a multi-part message in MIME format.\n\n" . 
             "--{$mime_boundary}\n" . 
             "Content-Type: text/plain; charset=\"iso-8859-1\"\n" . 
             "Content-Transfer-Encoding: 7bit\n\n" . 
             $body . "\n\n"; 

1. Why do you begin the $headers variable with a line break?

2. Why do you use the '.=' operator when $headers was never defined (as far as I can see, anyway) before then?

3. The "boundary=" bit should directly follow the semicolon in the Content-Type header, however you've inserted a line break before it.

4. You use a line feed ("\n") to separate headers, yet RFC2822 ("Internet Message Format") defines a line as a string of data followed by a CRLF ("\r\n" in PHP). While it is true that some "poor quality Unix" MTA's do some replacement on line ending characters, have you at least tried using "\r\n" to begin with?

EDIT: Also, rather than hashing [man]time/man for the MIME boundary (which only changes once every 1000 milliseconds! :p) you might hash something even more dynamic such as [man]uniqid/man.