mysql_num_rows() expects parameter 1 to be resource, boolean given

[gunderjj]

I keep getting this error? Warning:
mysql_num_rows() expects parameter 1 to be
resource, boolean given in
/usr/local/apache2/htdocs/checkout/mysql.php

on line 40

This is the code:

// connect to MySQL
$connection = mysql_connect($host, $user, 
$password);
if (!$connection) {
    die('Could not connect: ' . mysql_error());
}
// call stored proc
$query="CALL 
dba.checkout_review('$Fname','$Lname')";
$result=mysql_query($query,$connection) or 
die (mysql_error());

if (!mysql_num_rows($result)) {
echo "Hello, ".$Fname." ".$Lname.".<br />";
echo "Access granted on ".$server.".<br />";
echo "You will recieve an email shortly with 
the password for the live_review account<br 
/>";
echo "This account will expire in 4 hours. After 
that it will need to be checked out again. 
Questions please contact 
[e-mail]<br />";
} else {
while ($row = mysql_fetch_array($result, 
MYSQL_NUM)) {
printf($row[0], $row[1]);
}
}
mysql_close($connection);
}

Any ideas?

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

gunderjj wrote:

Any ideas?

Of course, considering this same question gets asked at a frequency of around once per week. :/

Read the error message carefully; instead of a resource, you gave mysql_num_rows() a boolean for the first parameter. What's the first parameter you gave it? The result of [man]mysql_query/man.

Why did [man]mysql_query/man return a boolean? Read the manual and figure out what a boolean (hint: more specifically, boolean FALSE) return type means.

What's the cause of the error? Ask MySQL, it will tell you: [man]mysql_error/man.

[gunderjj]

okay so it does not like my if statement: if (!mysql_num_rows($result)). I am guessing $result returned false because the procedure I called worked okay so nothing was returned. I am trying to catch if something is returned, then I want it to output what was returned. The returned value can either return nothing it it works or a sentence if it does not work. What would be better to catch this if mysql_num_rows is not the best?

[bradgrafelman]

Oops - didn't read your code carefully enough.

Can you show us how the stored procedure is defined? For stored procedures, you're either going to get a TRUE or FALSE response from mysql_query(), telling you whether or not the procedure was successfully called.

As far as checking its response, you'll have to SELECT the 'OUT' (or INOUT?) parameter you defined in the procedure.

[gunderjj]

This is actually for a process to checkout a read-only user account and then it will expire every 4 hours in mysql. I am now creating the php front end. This is all ran by stored procedures, about 7 of them. I basically call a stored procedure and send a first name and last name when calling it. It runs multiple other procedures setting a password to a random password, calling a function to send an email, and writing a line into a table referencing the persons name and when they checked out the account. I have one of the procedures returning back a string saying the account is already checked out if a flag is set in a table. If the flag is not set then nothing is returned. I probably should have done this a different way. Do you want the code for all the procedures?

[sql]

drop procedure if exists dba.checkout_review;
delimiter $$
create procedure checkout_review (in fname varchar(20), in lname varchar(20))
begin
set @N=(select count(Expired) from dba.live_review_checkout where Expired='N');
set @Ocupied=(
if @N >= 1 then select concat('The account has been checked out already. If you can not wait until the 4 hour expire period please contact [e-mail]');
else
set @userId=(select id from dba.live_review_users where First_Name=fname and Last_Name=lname);
if @userId is Null then call dba.insert_checkout_users (fname,lname); set @userId=(select id from dba.live_review_users where First_Name=fname and Last_Name=lname); call expire_time (@userId);
else call expire_time (@userId);
end if;
if @N = 0 then
call reset_random_pass ('live_review'); set @=(select LOWER(email_address) from dba.live_review_users where First_Name=fname and Last_Name=lname); set @=(select password from dba.live_review_password); Do sys_exec(concat('/home/mysql/cronjobs/checkout_email.sh',' ', @,' ', @));
end if;
end if;
end$$
delimiter ;

[/sql]

[zekemorgan]

// connect to MySQL
$connection = mysql_connect($host, $user, 
$password);
if (!$connection) {
    die('Could not connect: ' . mysql_error());
}
// call stored proc
$query="CALL 
dba.checkout_review('$Fname','$Lname')";
$result=mysql_query($query,$connection) or 
die (mysql_error());

if (mysql_num_rows($result) != 0) {
echo "Hello, ".$Fname." ".$Lname.".<br />";
echo "Access granted on ".$server.".<br />";
echo "You will recieve an email shortly with 
the password for the live_review account<br 
/>";
echo "This account will expire in 4 hours. After 
that it will need to be checked out again. 
Questions please contact 
[e-mail]<br />";
} else {
while ($row = mysql_fetch_array($result, 
MYSQL_NUM)) {
printf($row[0], $row[1]);
}
}
mysql_close($connection);
}

[/QUOTE]

I believe you need to make a comparison statement instead of a true/false statement. Try above 🙂

[gunderjj]

This does not quite work zekemorgan. When I put in the if (mysql_num_rows($result) != 0) It always prints out under the if statement and I only want it to print out the echos if no rows are returned, the problem is that I am getting true returned because I am calling a stored proc. Not sure the best way to go about this?

[zekemorgan]

Sorry I made haste when posting to solve the error without reading what you are trying to accomplish. Set if(mysql_num_rows($result) == 0) if you want the if statement to be true when no rows are returned. Hope this helps.

[gunderjj]

Tried that. I get the error
Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /usr/local/apache2/htdocs/checkout/mysql.php on line 42
When it returns true or works. It does return back rows, but it is true because the stored proc ran without error.

[gunderjj]

Problem solved. The easiest thing to do was have it return a line if the stored proc ran fine and a line if it didnt. Then I just printed out the results.

[some1]

Hello, i'm getting this warning all the time, I tried to solve it but i couldnt. can somebody help me plz?

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /localhost/Library/books.php on line 258

$result1 = mysql_query($lquery);
mysql_close();
}

 if($found || (!$_POST['search'] && !$_GET['search']))
   {
     echo "<table border=1>";

---------->>> for($counter=0; $counter < mysql_num_rows($result1); $counter++)
{
mysql_connect("","Liberary","");
mysql_selectdb("Liberary");

[bradgrafelman]

Why are you closing the connection to MySQL immediately after executing the query without a) verifying the query executed successfully, or b) actually doing anything with the result set (assuming there is one).

[some1]

That is a long code, do u want me to send to u?

bradgrafelman;10982343 wrote:

Why are you closing the connection to MySQL immediately after executing the query without a) verifying the query executed successfully, or b) actually doing anything with the result set (assuming there is one).

[some1]

Hi bradgrafelman

here is the code from starts the if-loop

if($found)
{
mysql_connect("","","");
mysql_selectdb("");

         //have to check this out from the MYSQL!!!

         $lquery = "SELECT writer_name, name_book, published, books.id_book, books.id_writer, \

books.id_genre, books.language, books.piece, books.serial_n, books.material_type, books.isbn, book\
s.index_term, books.price FROM writer, books
WHERE books.id_writer = writer.id_writer and books.id_book IN " . $id_book . "
GROUP BY name_book";
$result1 = mysql_query($lquery);
mysql_close();
}
}

 else
   {
     mysql_connect("","","");
     mysql_selectdb("");

     $lquery = "SELECT writer_name, name_book, published, books.id_book, books.id_writer, book\

ss.id_genre, books.price
FROM writer, books
WHERE books.id_writer = writer.id_writer
GROUP BY name_book";
$result1 = mysql_query($lquery);
mysql_close();
}
}

 else
   {
     mysql_connect("","","");
     mysql_selectdb("");

     $lquery = "SELECT writer_name, name_book, published, books.id_book, books.id_writer, book\

ss.id_genre, books.price
FROM writer, books
WHERE books.id_writer = writer.id_writer
GROUP BY name_book";
$result1 = mysql_query($lquery);
mysql_close();
}
if($found || (!$POST['search'] && !$GET['search']))
{
echo "<table border=1>";

----------->>>>>> for($counter=0; $counter < mysql_num_rows($result1); $counter++)

   {
         mysql_connect("","","");
         mysql_selectdb("");

          $tquery = "SELECT  genre FROM genreb

WHERE id_genre= " . mysql_result($result1, $counter, "id_genre");
$result2 = mysql_query($tquery);
mysql_close();

          echo "<tr><td width=135>";
          PrintImage(mysql_result($result1,$counter,"id_book").".jpg");
          echo "</td><td>";
          echo "<u><b>" . mysql_result($result1, $counter, "writer_name") . "</b></u><br>";
          echo mysql_result($result1, $counter, "name") . "<br>";
          echo "<i>Laji: " . mysql_result($result2, 0,  "genre") . "</i><br>";
          echo "Tekij&#228;: " . mysql_result($result2, 0, "writer");

          echo "Julkaisu vuosi: " . mysql_result($result1, $counter, "published") . "<br>";
          echo "<b>Hinta: " . mysql_result($result1, $counter,  "price") . "</b><br>";
          echo "</td>";
          echo "<td align=center>";
          if($_GET['search'])
            echo "<form method=POST action=shopping_cart.php?search=" . $_GET['search'] . ">";
          else
            echo "<form method=POST action=shopping_cart.php>";
          echo "<input type=hidden name=search value=" . $_GET['search'] . ">";
          //Have to check this OUT!
          //The buttons
          echo "" . mysql_result($result1, $counter, "id_book") .">

<br><br><input type=submit value='Lis&#228; koriin' />";
echo "" . mysql_result($result1, $counter, "id_book") .">
<br><br><input type=submit value='Lis&#228;tiedot' />";
echo "" . mysql_result($result1, $counter, "id_book") .">
<br><br><input type=submit value='Varaa' />";
echo "</form>";
//kpl = piece
//Addition to cart...
echo "</td></tr>";
}
echo "</table>";
}
else
{
echo "Valitettavasti haulla ei l&#246;ytynyt";
}

[bradgrafelman]

My previous question still stands... why are you closing the connection and then later trying to use it?

[ninjacl]

complicated 🙁