[RESOLVED] how to rewrite

realcoder

i want to rewrite url of my script Seo friendly
please little guide me
which rules i use
& how
for example this is the eactual url of my script

http://localhost/proj/songs.php?movie=Kajrare
i want to rewrite every url which is songs.php?movie=moviename
look like
songs/movie/moviename.html
or only look like localhost/proj/movie/moviename.html
i know we can do this
but i am very new so don't know the exact rule 😕
thanks in advance

realcoder

i have try this code after searching putting in .htaccess

RewriteEngine on
RewriteRule ^{movie/([^/.]+)/?$} songs.php?movie=$1 [L]

but nothing change ???

TheoGB

Hey,

I used this article to learn the techniques I got working:
http://techie-buzz.com/ask-techie/create-seo-friendly-urls-using-mod-rewrite-and-php-part-1.html

Going by that, if you want something of the form:
songs/movie/moviename.html
or
proj/movie/moviename.html

Try changing your RewriteRule to be
^{songs/movie/([^/.]+).html$} songs.php?movie=$1 [L]
or
^{proj/movie/([^/.]+).html$} songs.php?movie=$1 [L]

In the first place the ^ (caret) means there's nothing before so you need to specify the higher level of 'songs' or 'proj'. Then you need to specify the .html extension bit. I think that will work but I'm not 100%, just guessing.

realcoder

RewriteEngine On
RewriteRule ^{proj/movie/([^/.]+).html$} songs.php?movie=$1 [L]

not working any 🙁 nothing chhange

realcoder

sorrry working
but wanna ask now how i change alll link to songs/movie/moviename.html

becoz how is it possible ?
mean menually after giving this in url movie/moviename.html i got the movie
but how can i change all link becoz alll links are generating automatically 😕
it's confusing any idea

TheoGB

You'll have to rewrite the system that's generating the links internally on your site, I'm afraid. If your site's generated via PHP this shouldn't be TOO hard.

I use Smarty as a templating engine and I use that to create the appropriate links. But yes, wherever a link is generated that you would rather is the rewritten form you'll need to make your system generate the rewritten form instead of the old form.

realcoder

this is my movies.php code
u can see here automatically show new adedd movie
how i generate the link which look like this
http://www.hostrox.com/proj/movie/Kajrare.html

and also work
how i write code any idea ???

<?php
session_start();
include "inc.php";
$id = $_GET['id'];


$page_name = $_SERVER['PHP_SELF'];
$start = $_GET['start'];
if(!isset($start)){
    $start = 0;
}
$limit = 30;
$back = $start - $limit;
$next = $start + $limit;



$noOfCols=5;
$que1 = "SELECT * FROM movies where catid='$id'";
$exe2 = mysql_query($que1);
$count = mysql_num_rows($exe2);
?>
<html>
<head><title>Movies....</title>
<link rel="stylesheet" type="text/css" href="proj.css" />
</head>
<body>
<table width="900" border="1" align="center">
<tr><td height="100%" align="left" valign="top" colspan="3"><?php include "head.php"; ?></td></tr>
<tr><td width="150" align="left" valign="top">
<?php include "catg.php"; ?>
</td><td>
<table align="center">
<?php
$que = "SELECT * FROM movies where catid='$id' limit $start,$limit";

$exe = mysql_query($que);
while($get = mysql_fetch_array($exe))
{
    if($i==0)
        echo '<tr>';

echo "<td height='150' align='left' valign='top'><a href='songs.php?movie=".$get['name']."'>".$get['name']."<br/><img width='100' height='130' border='0' src='".$get['picture']."' /></a></td>";

$i++;
if($i==$noOfCols)
{
    echo '</tr>';
    $i=0;
}
}


?>
</table>
<?php
echo "<table align='center'><tr><td align='center'>";
if($back >= 0){
    echo "<a href='$page_name?id=$id&start=$back'>Prev</a>&nbsp;";
}
$j = 1;
for($i=0; $i < $count ; $i = $i + $limit){
if($i <> $start){
    echo "<a href='$page_name?id=$id&start=$i'>$j</a>&nbsp;";
}
else{
    echo $j;
}
$j++;
}
if($next < $count){
    echo"<a href='$page_name?id=$id&start=$next'>NeXt</a>&nbsp;";
    }
    echo "</td></tr></table>";



?>
</td>
<td width="150" align="left" valign="top"><?php include "right.php" ?></td>
</tr>
<tr>
<td colspan="3" align="center" valign="top"><?php include "footer.php" ?></td>
</tr>
</table>
</body>
</html>

realcoder

i think this is the code where i have to make changings

<?php
$que = "SELECT * FROM movies where catid='$id' limit $start,$limit";

$exe = mysql_query($que);
while($get = mysql_fetch_array($exe))
{
if($i==0)
echo '<tr>';
echo "<td height='150' align='left' valign='top'><a href='songs.php?movie=".$get['name']."'>".$get['name']."<br/><img width='100' height='130' border='0' src='".$get['picture']."' /></a></td>";

[/QUOTE]

TheoGB

Yes that looks like one of the places. To conform to the way you rewrote your URL above, songs/movie/moviename.html you'd need to do it like this:

echo "<td height='150' align='left' valign='top'><a href='songs/movie/".$get['name'].".html'>".$get['name']."<br/><img width='100' height='130' border='0' src='".$get['picture']."' /></a></td>";

realcoder

thanks

TheoGB

Your code is still very unsafe if you are planning to put it out in the 'real world'.

You need to make sure you apply mysql_real_escape_string() to any variable you pass into a database query that you cannot be 100% sure of.

http://php.net/manual/en/function.mysql-real-escape-string.php

This cartoon illustrates what an SQL Injection attack is:
http://xkcd.com/327/

But essentially if someone substituted a genuine id value for something like

0; drop table movies

then you'll find yourself without a database table.

bradgrafelman

TheoGB wrote:
You need to make sure you apply mysql_real_escape_string() to any variable you pass into a database query that you cannot be 100% sure of.

One minor correction; that function should only be used to sanitize string data as for other types of data (numeric, etc.) it isn't appropriate.

EDIT: For example, the string:

0; drop table movies

contains no characters that [man]mysql_real_escape_string/man needs to escape.

TheoGB

Ah yeah... Be vigilant, basically. 😃

realcoder

well i wanna ask one question
if we writing the main link in our file like this
<a href='songs/movie/".$get['name'].".html'>
then why we writing in .htaccess for chanigng link from songs.php?movie=movie to movie/moviename.html
because there is no link like this songs.php?movie=moviname which that change
we changing that manually from our file 😕
what is this all matter 😕
any little guaidence or explanation about this

TheoGB

Well when you write out a RewriteRule you're specifying two parts. The first part is the URL that someone clicks on and the second part is the URL that you want to process.

So right now you've asked that Apache treat any URL that conforms to:
songs/movie/[ANY TEXT AT ALL HERE APART FROM / or .].html

and instead process the URL
songs.php?movie=[THE TEXT THAT WAS AFTER movie/ AND BEFORE .html]

The point is that both URLs will work but you're trying to make sure the second form of the URL is never picked up. So that means that inside your site you have to write your URLs to point to the new address form.

One thing to note is that images and style sheets, if given as links via relative paths will need to have full paths.

realcoder

ok thanks i got the point
infact we give in .htaccess that conerert our move/moviename.hml url to songs.php?movie=moviename
basically ware giving instrucion that convert html type url to a string type of php 🙂 but actually show us the simple html url

realcoder

RewriteRule ^{movie/(.).html} songs.php?movie=$1 [L,QSA]
well can u little explanation of this all rewrite rule i have dowload the charsheet
but stil m confuse about few things
as they mention that string start with ^
& end with $
but what is $1
why 1 is with $
(.) and why we write these in brackets
how i know that where m exactly passing variable in sting ???
and how much explanation u can telll

bradgrafelman

realcoder wrote:
as they mention that string start with ^
& end with $

If those two characters are used at the beginning or end of the pattern (respectively), then yes, they match start-of or end-of string.

realcoder wrote:
but what is $1

It's a placeholder to represent the first matched subpattern in the pattern string. $2 would represent the second subpattern, etc. etc.

quote=realcoder and why we write these in brackets [/quote]If by "brackets" you meant "parenthesis", then the answer is that the parenthesis mark a subpattern (see my response above).

realcoder wrote:
how i know that where m exactly passing variable in sting ???

No idea what you're asking there.

For a general guide on regular expression syntax, I've always found this to be a very helpful resource.

TheoGB

bradgrafelman;10958416 wrote:
If by "brackets" you meant "parenthesis"

FYI: While Americans use parenthesis and brackets differently, in English (i.e. British English) a bracket is a standard term for all four symbols: (, {, [ or < with the latter three being referenced 'curly brackets', 'square brackets' or 'elbow/angle brackets' respectively. We do sometimes use 'curly braces' but again, we would specify the shape to avoid confusion. 🙂

(I only discovered this peculiarity of US English recently.)

WRT the ^ at the start, doesn't it actually mean 'nothing before this', so that if you have the rule

^{name/detail.html$} detail.php

it won't submatch to

http://server.com/anotherplace/name/detail.html

This is what was implied to me.

bradgrafelman

TheoGB wrote:
WRT the ^ at the start, doesn't it actually mean 'nothing before this', so that if you have the rule

^{name/detail.html$} detail.php

it won't submatch to

http://server.com/anotherplace/name/detail.html

Yes, that's when the ^ and $ are used as start-of or end-of string anchors. For reference, more info about these two anchors can be found here