Obeject Issue

lowe_22

Hi,

I've just started experimenting with OOP and have created a simple script. However, for some reason the class doesn't seem to be working at all - I' wondering if it' because my server is running php5 and I don't know what changes to syntax there are etc.
Anyway, here is the script. I'd really appreciate any feedback on what could be going wrong!

lowe_22

Apologies, I hit enter by mistake and apparently there is no "edit" option of posts you've already made!

Here is the code:

<?php

class Products
{
   var $name;
   function getName()
   {
      return $this->$name;
   }

   function addProduct($name, $price, $sale, $desc, $status, $category)
   {
      $sql = "INSERT INTO products VALUES($name, $price, $sale, $desc, $status, $category)";
     if(mysql_query($sql))
     {
    	 return true;
     }
   }
}


?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
        "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title>Products</title>
</head>
<body>
       	<?php

   	   $products = new Products();
   	   if($products->addProduct("Product 1","23.50","1","This is a description","Staus","2"))
   	   {
   	   echo "Product Added";
   	   }

   	?>
</body>
</html>

NogDog

One problem I see is in your SQL: you need to quote any non-numeric values in the VALUE() clause. You need to add some "rainy day" code to deal with things when they don't work as expected (non-sunny-day cases 😉 ). For instance, you return true if mysql_query() is not false, so why not add an else to log/output error info, and then return false? Likewise, where you call that method in the body of the script, you check for true, and again you could add an else clause to notify the user that something went wrong.

PS: The "edit" button only appears after you have a few more posts that you currently have, and even then, only for a certain amount of time after you make the post (unless you're a moderator).