[RESOLVED] value in save button doesn't get sent to JAVASCRIPT

jrough

I'm trying to pass the nationalDrugCode and id to a Javascript AJAX function
in order to save it in mysql, but the ndc doesn't get passed, only the id. Below is my while loop where the rows get displayed and the save button. I need to pass the record id as so I can do the SQL, UPDATE nationalDrugCode where id= xxx . I know the nationalDrugCode is not getting passed because I have two alerts.

On the 3rd column of data, the nationalDrugCode, you can see where I'm trying to pass it. What is happening now to the record now is the ndc value in the db is getting clobbered but the new value isn't saved. I think something is not quite right with that input line in the HTML I attach the $id to the input id so it picks it up in the getElementById . thanks,

while ($row = mysql_fetch_assoc($result)){

    $id=$row['id'];
    $bu=$row['bu'];
    $nationalDrugCode=$row['nationalDrugCode'];
    $error_flag=$row['error_flag'];


    //save button on data rows
    echo "<td style='border:solid black 1px;padding:2px;' align='center' nowrap>";
    echo "<a href='#' onClick='saveRecord($id)' title='SaveRecord'>
        <img src='../images/save-icon-trans.png' width='20' border='0'>
</a><br /><div id='txt$id' name='tag$id'><div>\n";


    echo "<td style='border:solid black 1px;padding:5px;'>$id\n";
    echo "<td style='border:solid black 1px;padding:5px;'>$bu\n";

    echo "<td style='border:solid black 1px;padding:5px;'><input type='text'  size='15' name='nationalDrugCode$id' id='nationalDrugCode$id'  value='$nationalDrugCode'>\n";
    echo "<td style='border:solid black 1px;padding:5px;'>$error_flag\n";   

}//while end


<script type="text/javascript">
	function saveRecord(id) {

        alert(id);

        var answer=confirm("Save this record?")
                if(!answer){return;}

        get1="id="+id;
        get1="&nationalDrugCode="+document.getElementByID("nationalDrugCode" + id).value;

        alert(get1);


           // alert(get1);
	if ( window.XMLHttpRequest ) {// code for IE7+, Firefox, Chrome, Opera, Safari
	  xmlhttp=new XMLHttpRequest();
	}else{ // code for IE6, IE5
	  xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
	  if ( xmlhttp.readyState==4 && xmlhttp.status==200 && apply2All!='Y' ) {
	    document.getElementById("txt" + id).innerHTML=xmlhttp.responseText;
	  }
	}
	xmlhttp.onreadystatechange=function() {
	}
            alert(get1);
	xmlhttp.open("GET","saveRecord.php?" + get1,true);
	xmlhttp.send();


}

Thanks,

Krik

Is your browser reporting javascript errors? I usually do my initial testing of javascript in FireFox with the FireBug addon. It gives fairly good direction on where my code is failing. Including some fairly good direction on any errors with AJAX, which can be the very difficult to track.

get1="id="+id;
get1="&nationalDrugCode="+document.getElementByID("nationalDrugCode" + id).value;

There is 2 problems, both with the second "get1" variable.

First you need to use different quotes around "nationalDrugCode" or escape the quotes (\").

Next, it is overriding the first "get1" you need to use the += assignment operator.

get1="id="+id;
get1+="&nationalDrugCode="+document.getElementByID('nationalDrugCode' + id).value;

jrough

Thanks for those two corrections, didn't fix it though. I hit the saverecord.php page to test whether the XMLHTTP happened, echo the GET vars, id and nationalDrugCode and don't get a value for nationalDrugCode. The update saveRecord.php page seems fine. I can't see anything about the javascript in Firebug. The problem seems to be on this line. IT doesn't get the nationalDrugCode value.
get1+="&nationalDrugCode="+document.getElementByID('nationalDrugCode' + id).value;

$id=$_GET['id'];
$nationalDrugCode=$_GET['nationalDrugCode'];  

echo "the id is".$id."\n";
echo "the ndc is".$nationalDrugCode."<br />";


$sql="UPDATE `pharm_cart_order`.cart_inventory SET ";
$sql.="nationalDrugCode='$nationalDrugCode' ";
$sql.="WHERE id='$id' ";
  	$result=mysql_query($sql);
  	if ( !$result ) {die("<font color='red'>Invalid query:</font>" . mysql_error() . "<br>$sql");}
//}

echo "<font color='red'>&nbsp;&nbsp;Saved</font>\n";

I changed a little in the javascript, there is no save all button. I only want to save the record row by row. Let me know if you see anything else. This looks like it should work. I'm not getting a nationalDrugCode value in the alert or GET.
Maybe the problem is in the html?


<script type="text/javascript">
	function saveRecord(id) {

        alert(id);

        var answer=confirm("Save this record?")
                if(!answer){return;}

        get1="id="+id;
        get1+="&nationalDrugCode="+document.getElementByID('nationalDrugCode' + id).value;

        alert(get1  );

	if ( window.XMLHttpRequest ) {// code for IE7+, Firefox, Chrome, Opera, Safari
	  xmlhttp=new XMLHttpRequest();
	}else{ // code for IE6, IE5
	  xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");

	}

            alert(get1);
	xmlhttp.open("GET","saveRecord.php?" + get1,true);
	xmlhttp.send();


}

jrough

Is this line right for the HTML input?The value of $nationalDrugCode should get input into the javascript by getElementId right but it isn't so maybe something on this line is wrong?THANKS,

    echo "<td style='border:solid black 1px;padding:5px;'><input type='text' size='15' name='nationalDrugCode$id' id='nationalDrugCode$id'  value='$nationalDrugCode' ;\">\n";

Krik

Spelling error, getElementByID should be getElementById

Krik

jrough;10959075 wrote:
Is this line right for the HTML input?The value of $nationalDrugCode should get input into the javascript by getElementId right but it isn't so maybe something on this line is wrong?THANKS,
    echo "<td style='border:solid black 1px;padding:5px;'><input type='text' size='15' name='nationalDrugCode$id' id='nationalDrugCode$id'  value='$nationalDrugCode' ;\">\n";[/QUOTE]
not quite
echo "<td style='border:solid black 1px;padding:5px;'><input type='text' size='15' name='nationalDrugCode$id' id='nationalDrugCode$id'  value='$nationalDrugCode'>\n";

jrough

it works now, thanks!