need to set js var with php data

landysaccount

Hello.

I'm trying to change a form value with javascript from a php script. I know I can do it with php with changing value field but wanted to learn how to do so with javascript and php.

This is what I'm trying to do:

if( isset($_SESSION['cust_id']) ){
    echo "<script type='text/javascript'>";
        echo "var cust_name = '" . $_SESSION['fname'] . " " . _SESSION['lname'] . "';";
        echo "  form.newTicket.name.value = '" . $_SESSION['fname'] . " " . $_SESSION['lname'] . "';";
        // also tried this
        echo "  document.getElementByName('name').value = cust_name";
    echo "</script>\n";
    }


<form name="newTicket">
  <input type="text" name="name">
</form>

This doesn't work. Just wondering if there's a technique I can use to set variables in javascript with php.

Thanks in advanced for your help.

avihai1

try using it in a function.

<?php
     if( isset($_SESSION['cust_id']) ){
    echo "<script type='text/javascript'>";
	echo "function setVar() {";
        echo "var cust_name = '" . $_SESSION['fname'] . " " . $_SESSION['lname'] . "';";
        echo "  document.getElementById('name').value = '" . $_SESSION['fname'] . " " . $_SESSION['lname'] . "';";
		echo " }";
    echo "</script>\n";
    }
	?>

add to the body tag the onload event:

<body onload='setVar()'>

add an id to the input:

<input type='text' name='name' id='name' />

you can trigger the function as you like.

and by the way, it's document.getElementByNames and it returns an array with the matching elements.

johanafm

avihai1;10959065 wrote:

try using it in a function.

<?php
     if( isset($_SESSION['cust_id']) ){
    echo "<script type='text/javascript'>";
	echo "function setVar() {";
        echo "var cust_name = '" . $_SESSION['fname'] . " " . $_SESSION['lname'] . "';";
		echo " }";
    echo "</script>\n";
    }
	?>

"var cust_name" is meeningless in function scope, since it will not be reachable from anywhere else this way. It would need to either be returned from the function so that you can retrieve it later or kept in global scope.
On the other hand, since the input with id 'name' holds the same value, there is little reason to keep it in a variable as well, which in turn means you could just as well

echo '<input type="text" ... value="'.$fname.' '.$lname.'"/>';

Either way, you should neither use this data in get query strings nor as post data. It could be changed, and you allready have it as session data anyway. As such, the only reason to use it on the page is if you want to show the user that they are "Logged in as: John Doe". So you don't even need the input to hold this data.