Storing data from checkbox

northview

I know this should be easy, but as usual I have no idea what I am doing. 🙂

What I am trying to do is use a tick box to determine if a link should be displayed on another page. I have created the following ENUM (Y,N) field: directory_disable in the user table. Once the data is stored it should return to the specific users' account edit page with the tick in the box if the value from directory)_disabled is Y. Then I can use a simple If statement (I hope) on the page I want to control this link from displaying.

Here is the code I have so far. It is not displaying any errors:

<form action="" name="form1" method="post">
    <tr>
    <td width="100" colspan="3"><p align="right"><b>Disable Member Access to Church Directory</b><br>Checking this box will remove the member's link to the Church directory.</p>
    </td>
    <td>

   <?php
	 if($directory_disable['value']=='Y'){
	?>
    <input type="checkbox" name="directory_disable" checked onClick="location.href='user-edit.php?id=<?=$id?>'";/>
    <?php }
	else{
	?>
    <input type="checkbox" name="directory_disable" onClick="location.href='user-edit.php?id=<?=$id?>'"/>

Thank you.

northview

Here is the second part which is not working either:

<?php
if ($directory_disable == 'N') {
echo '<a class="leftmenu" href="<?=$SITE_PATH?>user-directory.php">Church Directory</a>';
}else{

echo '';
}
?>

For some reason it will not distinguish between the data in the table. The above code does indeed wipe out the link...but it leaves the space where the link should go.

In other words it displays like this:

• Account Home
• Prayer Request
•
• My Tithes & Offering

Instead of:

• Account Home
• Prayer Request
• My Tithes & Offering

The action should be:

If directory_disable (for the specific logged in user) is N then display the link. If the it is Y then display nothing.

Here is what the code looks like on the entire page:

<table width="100%"  border="0" align="center" cellpadding="5" cellspacing="10" STYLE="background-color: #FAFAF8">
    <tr align="left">
        <td colspan="2" class="left_menu"><strong>Account</strong> </td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-main.php">Account Home</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-request.php">Prayer Request</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu">
<?php
if ($directory_disable == 'N') {
echo '<a class="leftmenu" href="<?=$SITE_PATH?>user-directory.php">Church Directory</a>';
}else{

echo '';
}
?> 

</td>
    </tr>
     <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-givings.php">My Tithes & Offering</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-flyers.php">Flyers & Tracts</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-testimony.php">Give your Testimony</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-account.php">Personal Info</a></td>
    </tr>
    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu"><a class="leftmenu" href="<?=$SITE_PATH?>user-login.php?mode=logout">Logout</a></td>
    </tr>
</table>

Thank you so much for your help.

Krik

I hope I understood your questions

<input type="checkbox" name="directory_disable" checked onClick="location.href='user-edit.php?id=<?=$id?>'";/>

What you have happening here is when they click the checkbox the user is redirected to another page. And the only value being sent is the "id". The next page can not tell if the user is checking or unchecking the box.

If you need the "user-edit.php" page to be able to tell if the box is being checked or unchecked you need to add the another GET value to the url

<input type="checkbox" name="directory_disable" checked onClick="location.href='user-edit.php?id=<?=$id?>&disable=yes' />

Now I should note that doing a redirect is bit unusual. Usually you would assign a "value" to the <input> and then have javascript submit the form onclick.

Should also note there appears to be an extra ;" at the end of one of the input fields and the other has an extra " at the end of it.

On your next problem your code is doing exactly as you told it to. And you are telling it to no matter what display the table row whether it is empty or not.

Basically your code say if $directory_disable == 'N' do this

    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu">
            <a class="leftmenu" href="<?=$SITE_PATH?>user-directory.php">Church Directory</a>
        </td>
    </tr>

else do this

    <tr>
        <td width="6%" align="center" >&bull;</td>
        <td width="94%" class="left_menu">
        </td>
    </tr>

It doesn't matter whether the link is visible or not the HTML is still creating another table row and 2 table cells, one with the "•" and the other is blank.

So if that link is not to be displayed you need to also not display the table row either.