[RESOLVED] Advancing die() to use an include

[neilmasters]

Hi everyone,
thank you for reading, I am sure that the advice you give will be helpful.

main.php

include "errorForm.php";
$SQL = "SELECT * FROM contacts where contact_id = '$id'"; 
$result = mysql_query($SQL) or die($errorForm); 

errorForm.php(truncate)

<?php
$errorForm = '
<h1>Error</h1>
<table>
	<tr>
		<td>...</td>
	</tr>
	<tr>
		<td>
			<form name="report" action="" method="post">
				...
				<textarea name="message">' . mysql_error() . '</textarea>
				<input type="submit" value="Send bug report"  style="width: auto; margin-right: 2px;"/>
			</form>
		</td>
	</tr>
</table>';
?>

Basically: upon die display $errorForm which is working fine, however mysql_error() is not being displayed. I figured that mysql_error() is not able to function when it is an include?

Any advice you might have will be brilliant.

[laserlight]

I suggest that you define a function instead:

<?php

function errorForm($message) {
    return '<h1>Error</h1>
<table>
    <tr>
        <td>...</td>
    </tr>
    <tr>
        <td>
            <form name="report" action="" method="post">
                ...
                <textarea name="message">' . htmlspecialchars($message) . '</textarea>
                <input type="submit" value="Send bug report"  style="width: auto; margin-right: 2px;"/>
            </form>
        </td>
    </tr>
</table>';
}

Now you can write:

include "errorForm.php";
$SQL = "SELECT * FROM contacts where contact_id = '$id'";
$result = mysql_query($SQL) or die(errorForm(mysql_error()));

[neilmasters]

Sigh. Im such a tard sometimes. I have no idea why i did not think of this, i blame it on the morning blues.

Ta very much.

[laserlight]

You're welcome 🙂

Remember to mark this thread as resolved using the thread tools.