two inserts

[michaelwelfle]

Hey there.

I actually have it the way I want it to work BUT its giving me duplicate inserts. When I sumbit and look on the mysql tables, it all looks fine, but just double of the two inserts. Here is my code

<?php include("common.php");

$fname = $_POST[fname];
$lname = $_POST[lname];
$title = $_POST[title];
$company = $_POST[company];
$address1 = $_POST[address1];
$address2 = $_POST[address2];
$city = $_POST[city];
$prov = $_POST[prov];
$postcode = $_POST[postcode];
$source = $_POST[source];
$phone = $_POST[phone];
$email = $_POST[email];
$businesstype = $_POST[businesstype];
$lastupdate = $_POST[lastupdate];
$fleetsum = $_POST[fleetsum];

$string = $_POST[lname];
$source = "NEWONLINE";
$username = "autofleet";
$password = substr($string, 0, 4);
$question = $_POST[question];
$firstname = $_POST[fname];
$lastname = $_POST[lname];

$ufname = strtoupper($fname);
$ulname = strtoupper($lname);
$utitle = strtoupper($title);
$ucompany = strtoupper($company);
$uaddress1 = strtoupper($address1);
$uaddress2 = strtoupper($address2);
$ucity = strtoupper($city);
$uprov = strtoupper($prov);
$upostcode = strtoupper($postcode);
$uphone = strtoupper($phone);
$uemail = strtoupper($email);
$ubusinesstype = strtoupper($businesstype);
$ufleetsum = strtoupper($fleetsum);

$sql = "INSERT INTO Autofleet (fname, lname, title, company, address1, address2, city, prov, postcode, source, phone, email, businesstype, lastupdate, fleetsum, username, password) VALUES('$ufname', '$ulname', '$utitle', '$ucompany', '$uaddress1', '$uaddress2', '$ucity', '$uprov', '$upostcode', '$source', '$uphone', '$uemail', '$ubusinesstype', '$lastupdate', '$ufleetsum', '$username', '$password')";

if(!mysql_query($sql) || $userid = mysql_insert_id(); !mysql_query($sql2))
{
   echo "Your information is being processed....";
}
else
{
   echo "Error";
}

mysql_close($con);

?>

MOD EDIT: [noparse]

 bbcode tags changed to [code=php] tags.[/noparse]

[michaelwelfle]

that was an older version, heres an update.

<?php
$mysql_host = "xxxx";
$mysql_database = "xxxxxx";
$mysql_user = "xxxxxxx";
$mysql_password = "xxxxxx";

$con = mysql_connect($mysql_host,$mysql_user,$mysql_password);

mysql_select_db($mysql_database, $con);

$fname = $_POST[fname];
$lname = $_POST[lname];
$title = $_POST[title];
$company = $_POST[company];
$address1 = $_POST[address1];
$address2 = $_POST[address2];
$city = $_POST[city];
$prov = $_POST[prov];
$postcode = $_POST[postcode];
$source = $_POST[source];
$phone = $_POST[phone];
$email = $_POST[email];
$businesstype = $_POST[businesstype];
$lastupdate = $_POST[lastupdate];
$fleetsum = $_POST[fleetsum];

$string = $_POST[lname];
$source = "NEWONLINE";
$username = "autofleet";
$password = substr($string, 0, 4);
$question = $_POST[question];
$firstname = $_POST[fname];
$lastname = $_POST[lname];

$ufname = strtoupper($fname);
$ulname = strtoupper($lname);
$utitle = strtoupper($title);
$ucompany = strtoupper($company);
$uaddress1 = strtoupper($address1);
$uaddress2 = strtoupper($address2);
$ucity = strtoupper($city);
$uprov = strtoupper($prov);
$upostcode = strtoupper($postcode);
$uphone = strtoupper($phone);
$uemail = strtoupper($email);
$ubusinesstype = strtoupper($businesstype);
$ufleetsum = strtoupper($fleetsum);

$sql = "INSERT INTO Autofleet (fname, lname, title, company, address1, address2, city, prov, postcode, source, phone, email, businesstype, lastupdate, fleetsum, username, password) VALUES('$ufname', '$ulname', '$utitle', '$ucompany', '$uaddress1', '$uaddress2', '$ucity', '$uprov', '$upostcode', '$source', '$uphone', '$uemail', '$ubusinesstype', '$lastupdate', '$ufleetsum', '$username', '$password')";

if(mysql_query($sql))
{
   echo "Your information is being processed....";
}
else
{
   echo "Error";
}

$userid = mysql_insert_id();

$sql2 = "INSERT INTO PromotionList (userid, firstname, lastname, question) VALUES('$userid', '$firstname', '$lastname', '$question')";

if(mysql_query($sql2))
{
   header('Refresh: 2; url="http://site.com"');
   echo "Your information is being processed....";
}
else
{
   echo "Error";
}

mysql_close($con);

?>

[Crowly]

Can't see anything wrong with the code, but header('Refresh: 2; url="http://site.com"'); in the 2nd insert execution might be the culprit, try to comment it out and see if you just get a single row from each insert, if you do thats your problem.

Also remember that you can't output anything before header()

from http://php.net/header

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP. It is a very common error to read code with include(), or require(), functions, or another file access function, and have spaces or empty lines that are output before header() is called. The same problem exists when using a single PHP/HTML file.