adding records to mysql with OOP aproach in php

[tamayo]

Hi, I'm changing some php script to OOP aproach, when I try to execute the new class i don't get any result, no error message but also the record is not saved and the redirect function doesn't work, so my question is:

what am I missing in my code? I have the constructor, and from it I call the other 2 function, here is my code, please take a look, regards

<?php
class addemp{
	//constructor de la clase
	function addemp(){
		session_start();
		if (@$_SESSION['auth'] !="yes"){
			header("Location: 	nologin.php");
			exit();
			}
		else{	
		if($_POST['btnenviar']=="Cancelar"){
			header('Location: pnomina.php');		
			}
		else{
			include("vars.php");
			$xnombres=$_POST['txtnombres'];
			$xapellidos=$_POST['txtapellidos'];
			$xtelefono=$_POST['txttelefono'];
			$xdireccion=$_POST['txtdireccion'];
			$xciudad=$_POST['txtciudad'];
			$xdepto=$_POST['txtdepto'];
			$xdui=$_POST['txtdui'];
			$xnit=$_POST['txtnit'];
			$xnup=$_POST['txtnup'];
			$xisss=$_POST['txtisss'];
			$xprofesion=$_POST['txtprofesion'];
			$xfoto=$_POST['txtfoto'];
			$this->agregar;
			$this->desplegar;
			}
		}	
	}
			//fin del constructor

		//funcion agregar: graba los datos en la tabla
		function agregar(){
			$conn=mysqli_connect($host, $user, $password) or die("No se pudo establecer comunicacion");
			$db=mysqli_select_db($conn, $basedatos) or die("Error en la base de datos");				
			$sql="INSERT INTO $tabla1 (apellidos, nombres, profesion, direccion, depto, ciudad, telefono, nit, nup, isss, dui, foto) VALUES ('$xapellidos', '$xnombres', '$xprofesion', '$xdireccion', '$xdepto', '$xciudad', '$xtelefono', '$xnit', '$xnup', '$xisss', '$xdui', '$xfoto')";
			mysqli_query($conn, $sql) or die(mysqli_error($conn));

			$_SESSION['curnom']=$xnombres;
			$_SESSION['curape']=$xapellidos;	
			$sql="SELECT id FROM $tabla1 WHERE apellidos='$xapellidos' AND nombres='$xnombres'";
			$resultado=mysqli_query($conn, $sql) or die(mysqli_error($conn));
			$filas=mysqli_num_rows($resultado);

			if($filas == 1){
				$xid=mysqli_fetch_assoc($resultado);
				$_SESSION[ 'curid' ]=$xid['id'];	
				}
			}

			function desplegar(){
				switch($_POST['btnenviar']){
					case "Almacenar":
					header('Location: pnomina.php');	
					break;

					case "Contratacion":
					header('Location: plaemp.php');		
					break;
				}
				}
			//fin de funcion agregar()
}//fin de la clase
?>	

[Res]

A few things, the first is why it's not getting called, the second issue may prevent it from working once it does get called.

//these two lines in yoru constructor, you are calling functions
            $this->agregar;
            $this->desplegar;

//so you need to put the ()'s on them.
$this->agregar();
$this->desplegar();

Second issue is with variables being used before they are declared.

$conn=mysqli_connect($host, $user, $password) or die("No se pudo establecer comunicacion");
$db=mysqli_select_db($conn, $basedatos) or die("Error en la base de datos"); 

Did you remove the variables $host, $user, $password and $basedatos from that function prior to posting it here? You will have to define them locally to use them (in that function), more assign them as member variables in the constructor.

[NogDog]

A general suggestion would be to try to design each class to focus narrowly on one specific part of your application. Right now you have this one class doing everything from user authorization to form input processing to database connection to database inserts to application flow control. Therefore a more robust OOP design here might have this functionality split up between several classes, with maybe one "controller" class to organize things and play "traffic cop".

Anyway, in the addemp() method, you probably want to store all those variables as class variables, or possibly array elements of one class variable. That way they will be available to the agregar() method via the $this variable, e.g. $this->xnombres, $this->xapellidos, etc. (or $this->array_name['xnombres'], $this->array_name['xapellidos'], etc.).