Query_String Redirect

igorek

Good Evening.
I am working on my website right now. Let me know if you have any suggestions for me for catching invalid Query_String values and redirecting the user to an error page.

<?php
// faulty query string
function faulty_query_string() {
	$ak = array_keys($_GET);
	// if get array key doesnt match one of mines
	$getkeys = array('view','id','act','m','p');
	$c = count($ak);
	for($i=1;$i<=$c;$i++):
		if (!empty($ak)) {$var = array_shift($ak);}		
		foreach ($getkeys as $val):
			if (!in_array($var,$getkeys)) {
				$faulty = true; 
				break;									
			} else {
				$faulty = false;
			}
		endforeach;
		if ($faulty)  { break; }
	endfor;
	return $faulty;
}
?>

bradgrafelman

function faulty_query_string() {
    $getkeys = array('view','id','act','m','p');

return !empty(array_diff(array_keys($_GET), $getkeys));
}

Or if you wanted to be really ornery and reduce it down to a one-liner:

function faulty_query_string() {
    return !empty(array_diff(array_keys($_GET), array('view','id','act','m','p')));
}

igorek

that is good thank you didn't see the full functionality of this function right away, the difference if $_GET and mine got me off a bit but then it made sence. I cannot test !empty right away gives me a fatal with something about text content;

<?php
function faulty_query_string() {
	$result = array_diff(array_keys($_GET), array('view','id','act','m','p'));
    return (!empty($result)) ? true : false ;
} 
?>

bradgrafelman

Ah yeah, that was my bad... oops.

Also... I'm curious, what's the application of this function? Why would it matter if the query string contained elements you didn't care about?

igorek

I am trying to make it so people dont type random variables or key/value pairs into my query string and restrict only to certain and in those only certain values can be passed to keys else it all redirects to a 404.