Simple error

zacron

I know there is a syntax error but for the life of me I cannot find it, can i have some assistance?

Cheers,
Zacron

header("Location: 'http://contest.netcheckup.ca/upload_page.php?file='. $var");

bradgrafelman

There are no syntax errors in the code snippet you posted (though the header value won't be what you want it to be).

zacron

Here's the portion of the script... I'm tryign to get the name of the uploaded file to be passed on to the next page fo the script.

move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
	  $var = $_FILES["file"]["name"]
	  header('Location: http://contest.netcheckup.ca/upload_page.php?file=' . $var');
	  echo "Redirecting to Part 2... Please Stand by...";

Zacron

bradgrafelman

The header() line in that code doesn't match the snippet you posted above...

Regardless, there are two parse errors in that code; you're missing a terminating semicolon on the line above the call to header(), and in the header() call itself you've got an extra quote after $var and before the closing ')' parenthesis.

zacron

Thank you, sorry about that, I was messing about with it.

Shouldn't do that. 🙂

ok so...

move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
	  $var = $_FILES["file"]["name"];
	  header("Location: 'http://contest.netcheckup.ca/upload_page.php?file='. $var'")';

would be the new correct method?

Zacron

bradgrafelman

Look at the header() line and see if it makes sense to you. It shouldn't. If it does, then you need to read the PHP manual page for a [man]string[/man] and understand how the syntax works.

Ignoring the extraneous single quote at the end of that line (although you shouldn't ignore it, since it'll cause a parse error), you've got single quotes and periods inside of the header() string.

zacron

Ok after looking at the manual page this is what I came up with...

header("Location: '/upload_page.php?file=' . $var')';

It is still wrong because it doesn't look right.

Thanks,

Zacron

P.S. PLEASE don't just give me the answer, instead point me to a specific section or article on the problem.

zacron

Ok, next revision...

header("Location: '/upload_page.php?file=' . '$var'")';

still erroring out :@ lol.

zacron

Warning: Unexpected character in input: ''' (ASCII=39) state=1 in /home/zacron/public_html/contest/upload_file.php on line 29
Invalid file

NogDog

Firstly, header() will fail if there is any output generated by the script before the header() command is executed (e.g. the echo right before it).

Secondly, you may need to url-encode the text being used in the URL query string value (and with some corrected quoting/concatenating here):

header('Location: http://contest.netcheckup.ca/upload_page.php?file=' . urlencode($var);