Parse error, unexpected ?

Keith_B

I'm green to PHP but wrote a script quite some time ago to calculate some values. I'm porting this to a new CMS that allows PHP, but I keep getting errors when saving the file, and have narrowed it down to just this one line. I had to remove " " on all the other lines.

echo "<form action="<? echo $_SERVER['../PHP_SELF'] ?>" method="POST" class="style2">";

Can anyone tell me what I am doing wrong here? It works fine in another CMS, but with this CMS I have to remove all <?php, etc.

The error received is:

# Parse error: syntax error, unexpected '?' in C:\Program Files\VertrigoServ\www\cms\admin\edituserplugin.php(108) : eval()'d code on line 18

Pulling this line out doesn't error the page save, so it definitely is this line.
TIA

bradgrafelman

Several things wrong:

You're trying to include PHP statements within a string... these statements won't get evaluated at all and just treated as part of the string.
You're using the '<?' deprecated short tags - you should always use the full '<?php' tags.
There is no such variable called $SERVER['../PHP_SELF']... perhaps you meant $SERVER['PHP_SELF'] ?
You have unescaped double quotes within a double-quote delimited string. If you want to use literal double quotes within the string, either escape all of them or use single quotes as your delimiter instead. More information/examples on this can be found in the manual: [man]string[/man].

KeyIDentity

Can someone please help me get the parse errors out of this script, telling me there's a parse error on line 30...

<html>
<body>

<?php
require('connect.php');
session_start();
$sesuser = @$_SESSION['username'];
$username = @$_POST['username'];
$password = @$_POST['password'];
$sumit= @$_POST['submit'];
if($sesuser)
{
	die("You are already logged in");
}else{
	if($submit)
	{
		if($username&&$password)
		{
			//$password = md5($password);
			$loginquery = mysql_query("SELECT * FROM users WHERE unsername='$username'");
			$numrows = mysql_num_rows($loginquery);

		if(!$numrows)
		{
			while($row = mysql_fetch_assoc($loginquery));
			{
				$password1 = $row['password'];
			}
			if($password==$password1);
			}
				echo "Passwords match!";
			}else{
				echo "Passwords do not match!";
			echo "Not a test";
		}else{
			echo "User does not exist!";
		}
		}else{

		echo "Please fill out all fields!";

		}
	}
}
}	
?>

<form action="login.php" method="POST">
	<table>
			<tr>
				<td>
				KeyIDentity
				</td>
				<td>
				<input type="text" name="username">
				</td>
			</tr>

		<tr>
			<tr>
			<td>
			Password
			</td>
			<td>
			<input type="password" name="password">
			</td>
		</tr>

		<tr>
			<td>
			<input type="submit" name="submit" value="Login" />
			</td>
		</tr>

</table>
</form>

</body>
</html>

sneakyimp

What does line 30 look like?